You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/20 16:49:18 UTC

[GitHub] [pulsar] dlg99 commented on pull request #15155: [Broker] Make health check fail if dead locked threads are detected

dlg99 commented on PR #15155:
URL: https://github.com/apache/pulsar/pull/15155#issuecomment-1104172625

   @lhotari What are the performance implications of this change?
   
   https://docs.oracle.com/javase/7/docs/api/java/lang/management/ThreadMXBean.html#findDeadlockedThreads() says "It might be an expensive operation."
   I think it may require a safepoint and can effectively pause JVM/result in the latency spikes every time health check runs (every minute?). 
   I'd at least put it behind a feature flag. 
   
   It is a good thing to have for the admin API/rest API to do this on demand, for troubleshooting. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org