[GitHub] [druid] paul-rogers commented on pull request #12816: Tidy up construction of the Guice Injectors

[GitBox <gi...@apache.org>]

paul-rogers commented on PR #12816:
URL: https://github.com/apache/druid/pull/12816#issuecomment-1201910686

   @gianm, thanks much for the review! Address your comments. You pointed out a couple of tender spots in areas I avoided changing. Please take a look at the responses so we can figure out if we need to do anything more.
   
   The suggestion for the default implementation of `getJacksonModules()` was good. So good, in fact, I went wild and removed all the now-redundant stub implementations. Let's see what IntelliJ inspections thinks of my handiwork before doing another review. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org