Re: Review Request 13793: Cast call to min for 32 bit systems.

[Ben Mahler <be...@gmail.com>]

> On Aug. 26, 2013, 10:56 p.m., Ben Mahler wrote:
> > Ship It!
> 
> Ben Mahler wrote:
>     Thanks Kevin! Can you mark this as submitted?

Ping for Kevin: Can you mark this review as submitted?


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13793/#review25581
-----------------------------------------------------------


On Aug. 24, 2013, 12:58 p.m., Kevin Lyda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13793/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2013, 12:58 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-664
>     https://issues.apache.org/jira/browse/MESOS-664
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> The call to min(ssize_t, long int) won't compile on 32 bit systems because ssize_t resolves to int on those systems. h/t to woggle on irc for helping me find this.
> 
> 
> Diffs
> -----
> 
>   src/files/files.cpp c609505 
> 
> Diff: https://reviews.apache.org/r/13793/diff/
> 
> 
> Testing
> -------
> 
> Builds on both 32 and 64 bit systems.  make check passes 83 tests; fails the OsTest.pstree (which it did before I put in the change).
> 
> 
> Thanks,
> 
> Kevin Lyda
> 
>