[jira] [Commented] (HADOOP-7178) copyToLocal API is creating .crc files in local, even after setting verifyChecksum to false at client side.

["Daryn Sharp (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-7178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010266#comment-13010266 ] 

Daryn Sharp commented on HADOOP-7178:
-------------------------------------

I'm not an expert on the filesystem code, but I have a few questions/concerns.

Should the code really be casting to a ChecksumFileSystem w/o first checking instanceof?

Should the default getVerifyChecksum() return instanceof ChecksumFileSystem instead of always true?  That may help prevent changing other filesystem classes which may do not implement setVerifyChecksum.

It looks like more fs classes may need to be changed than just Distributed.  Other filesystem appear to have private booleans for verifyChecksum.  The ChRoot will need to reach into its embedded fs.

> copyToLocal API is creating .crc files in local, even after setting verifyChecksum to false at client side.
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7178
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7178
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>         Attachments: HADOOP-7178_COMMON.patch, HADOOP-7178_HDFS.patch
>
>
> When we copy the files from DFS to local, it is creating the .crc file in local filesystem for the verification of checksum even if we disable the checksum verification at client side.
>         When user does not want to do any checksum verification, then what will be the use in creating of these files in local file system.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira