You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/07/21 00:26:00 UTC
[jira] [Commented] (ASTERIXDB-2417) Issues with LIMIT clause
[ https://issues.apache.org/jira/browse/ASTERIXDB-2417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551461#comment-16551461 ]
ASF subversion and git services commented on ASTERIXDB-2417:
------------------------------------------------------------
Commit a7aaf7110c5a3791f3f6a69827e22d6ee26a7175 in asterixdb's branch refs/heads/master from [~dlychagin-cb]
[ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=a7aaf71 ]
[ASTERIXDB-2417][COMP] Fix issues with LIMIT clause
- user model changes: yes
- storage format changes: no
- interface changes: no
Details:
- Fixed NPE in optimizer when limit/offset is non-integer
- Allow float/double values that are integers in limit/offset
- Make consistent limit/offset value types (integer) between
runtime and optimizer rules
- Add internal function treat-as-integer() that returns integer
if input number conforms to the integer type or fails otherwise
Change-Id: I986fab3e79b072aa2441af293f3e16c3f37bf508
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2788
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Contrib: Jenkins <je...@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Till Westmann <ti...@apache.org>
> Issues with LIMIT clause
> ------------------------
>
> Key: ASTERIXDB-2417
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-2417
> Project: Apache AsterixDB
> Issue Type: Bug
> Components: COMP - Compiler
> Reporter: Dmitry Lychagin
> Assignee: Dmitry Lychagin
> Priority: Minor
>
> 1. When limit or offset is a non-integer value the rule that pushes limits fails with NPE.
> 2. We should allow float/double values that are integers to be specified in limit/offset.
> 3. Make consistent offset/limit types. Currently StreamLimitRuntimeFactory expects limit/offset to be of type integer, but PushLimitIntoOrderByRule/PushLimitIntoPrimarySearchRule assume bigint. We should make those rules consistent with the runtime.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)