You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/06/04 18:40:50 UTC

[GitHub] [incubator-devlake] matrixji opened a new issue, #2081: Incorrect configuration handling while deploy with helm

matrixji opened a new issue, #2081:
URL: https://github.com/apache/incubator-devlake/issues/2081

   ## Describe the bug
   Incorrect configuration handling while deploying with helm
   
   ## To Reproduce
   Steps to reproduce the behavior:
   1. Deploy devlake with helm
   2. Configure some settings and Click `[Save Configuration]`
   3. The server return error with:
       ```json
       {"success":false,"message":"open .env: no such file or directory"}
       ````
   
   ## Expected behavior
   Configuration should be saved without error.
   
   ## Screenshots
   N/A
   
   ## Additional context
   
   There should be at least 2 things to be fixed.
   1. Need to create an empty `.env` config file if it does not exists while deploying with helm.
   2. The `WriteConfig` func in config/config.go need to use the path from ENV_PATH (if have), currently:
       ```go
       // WriteConfig save viper to .env file
       func WriteConfig(v *viper.Viper) error {
               return WriteConfigAs(v, `.env`)
       }
       ```
   
   I'll try to fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] warren830 closed issue #2081: Incorrect configuration handling while deploy with helm

Posted by GitBox <gi...@apache.org>.
warren830 closed issue #2081: Incorrect configuration handling while deploy with helm
URL: https://github.com/apache/incubator-devlake/issues/2081


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] Startrekzky commented on issue #2081: Incorrect configuration handling while deploy with helm

Posted by GitBox <gi...@apache.org>.
Startrekzky commented on issue #2081:
URL: https://github.com/apache/incubator-devlake/issues/2081#issuecomment-1147616381

   Hi @matrixji , thanks for the issue and pr.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org