You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/08 13:59:56 UTC
[GitHub] [incubator-seatunnel] Hisoka-X opened a new pull request, #2690: [ST-Engine][Starter] Add seatunnel own engine starter and e2e
Hisoka-X opened a new pull request, #2690:
URL: https://github.com/apache/incubator-seatunnel/pull/2690
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #2690: [ST-Engine][Starter] Add seatunnel own engine starter and e2e
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on code in PR #2690:
URL: https://github.com/apache/incubator-seatunnel/pull/2690#discussion_r970227918
##########
seatunnel-core/README.md:
##########
@@ -5,4 +5,7 @@ This module is the seatunnel job entrypoint. Seatunnel jobs are started by the b
- seatunnel-core-flink: The flink job starter.
- seatunnel-core-flink-sql: The flink sql job starter.
-- seatunnel-core-spark: The spark job starter.
\ No newline at end of file
+- seatunnel-core-spark: The spark job starter.
+- seatunnel-spark-starter: The spark job starter for connector-v2.
+- seatunnel-spark-starter: The flink job starter for connector-v2.
Review Comment:
`seatunnel-spark-starter` ?
##########
seatunnel-core/README.md:
##########
@@ -5,4 +5,7 @@ This module is the seatunnel job entrypoint. Seatunnel jobs are started by the b
- seatunnel-core-flink: The flink job starter.
- seatunnel-core-flink-sql: The flink sql job starter.
-- seatunnel-core-spark: The spark job starter.
\ No newline at end of file
+- seatunnel-core-spark: The spark job starter.
Review Comment:
`seatunnel-core-spark: The spark job starter` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #2690: [ST-Engine][Starter] Add seatunnel own engine starter and e2e
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #2690:
URL: https://github.com/apache/incubator-seatunnel/pull/2690#issuecomment-1246211940
> Can you split this into two PR? Since this involves a lot of non-engine modules, I would expect the changes to the starter module to be committed to the `dev` branch first.
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 merged pull request #2690: [ST-Engine][Starter] Add seatunnel own engine starter and e2e
Posted by GitBox <gi...@apache.org>.
EricJoy2048 merged PR #2690:
URL: https://github.com/apache/incubator-seatunnel/pull/2690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #2690: [ST-Engine][Starter] Add seatunnel own engine starter and e2e
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on PR #2690:
URL: https://github.com/apache/incubator-seatunnel/pull/2690#issuecomment-1246589606
> > Can you split this into two PR? Since this involves a lot of non-engine modules, I would expect the changes to the starter module to be committed to the `dev` branch first.
>
> OK
https://github.com/apache/incubator-seatunnel/pull/2726 has been merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #2690: [ST-Engine][Starter] Add seatunnel own engine starter and e2e
Posted by GitBox <gi...@apache.org>.
hailin0 commented on code in PR #2690:
URL: https://github.com/apache/incubator-seatunnel/pull/2690#discussion_r966598012
##########
seatunnel-core/seatunnel-spark-starter/src/main/java/org/apache/seatunnel/core/starter/spark/SparkStarter.java:
##########
@@ -134,7 +134,7 @@ static SparkStarter getInstance(String[] args) {
private static SparkCommandArgs parseCommandArgs(String[] args) {
SparkCommandArgs commandArgs = new SparkCommandArgs();
JCommander commander = JCommander.newBuilder()
- .programName("start-seatunnel-spark.sh")
+ .programName("start-seatunnel-spark-connector-v2.sh")
Review Comment:
as above
##########
seatunnel-core/seatunnel-flink-starter/src/main/java/org/apache/seatunnel/core/starter/flink/utils/CommandLineUtils.java:
##########
@@ -43,10 +42,10 @@ public static FlinkCommandArgs parseFlinkArgs(String[] args) {
return flinkCommandArgs;
}
- public static FlinkCommandArgs parseCommandArgs(String[] args, FlinkJobType jobType) {
+ public static FlinkCommandArgs parseCommandArgs(String[] args) {
FlinkCommandArgs flinkCommandArgs = new FlinkCommandArgs();
JCommander jCommander = JCommander.newBuilder()
- .programName(jobType.getType())
+ .programName("start-seatunnel-flink-connector-v2.sh")
Review Comment:
Need to update [this](https://github.com/apache/incubator-seatunnel/pull/2675/files#diff-d4c3677ccf36bf18f8b9fde06fbbca8c3b686d43afb7c65d19105069f142843dR34) when merging into dev later
##########
seatunnel-e2e/seatunnel-engine-e2e/pom.xml:
##########
@@ -27,6 +27,12 @@
<modelVersion>4.0.0</modelVersion>
<artifactId>seatunnel-engine-e2e</artifactId>
+ <packaging>pom</packaging>
+
+ <modules>
+ <module>seatunnel-engine-e2e-base</module>
+ <module>seatunnel-engine-connector-console-e2e</module>
Review Comment:
module name style
reference
https://github.com/apache/incubator-seatunnel/tree/dev/seatunnel-e2e/seatunnel-flink-connector-v2-e2e
https://github.com/apache/incubator-seatunnel/tree/dev/seatunnel-e2e/seatunnel-spark-connector-v2-e2e
##########
seatunnel-e2e/seatunnel-engine-e2e/seatunnel-engine-connector-console-e2e/src/test/resources/fakesource_to_console.conf:
##########
@@ -0,0 +1,42 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+######
+###### This config file is a demonstration of streaming processing in seatunnel config
+######
+
+env {
+ job.mode = "BATCH"
+}
+
+source {
+ # This is a example source plugin **only for test and demonstrate the feature source plugin**
+ FakeSource {
+ result_table_name = "fake"
+ field_name = "name,age"
+ }
+}
+
+transform {
+}
+
+sink {
+ console {
+ }
+
+ # If you would like to get more information about how to configure seatunnel and see full list of sink plugins,
+ # please go to https://seatunnel.apache.org/docs/flink/configuration/sink-plugins/Console
Review Comment:
remove
##########
seatunnel-engine/seatunnel-engine-client/pom.xml:
##########
@@ -68,7 +68,7 @@
</dependency>
<dependency>
<groupId>org.apache.seatunnel</groupId>
- <artifactId>connector-file-local</artifactId>
+ <artifactId>connector-console</artifactId>
Review Comment:
St-client depends on connector feeling strange
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #2690: [ST-Engine][Starter] Add seatunnel own engine starter and e2e
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on code in PR #2690:
URL: https://github.com/apache/incubator-seatunnel/pull/2690#discussion_r966625142
##########
seatunnel-e2e/seatunnel-engine-e2e/seatunnel-engine-connector-console-e2e/src/test/resources/fakesource_to_console.conf:
##########
@@ -0,0 +1,42 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+######
+###### This config file is a demonstration of streaming processing in seatunnel config
+######
+
+env {
+ job.mode = "BATCH"
+}
+
+source {
+ # This is a example source plugin **only for test and demonstrate the feature source plugin**
+ FakeSource {
+ result_table_name = "fake"
+ field_name = "name,age"
+ }
+}
+
+transform {
+}
+
+sink {
+ console {
+ }
+
+ # If you would like to get more information about how to configure seatunnel and see full list of sink plugins,
+ # please go to https://seatunnel.apache.org/docs/flink/configuration/sink-plugins/Console
Review Comment:
Done
##########
seatunnel-e2e/seatunnel-engine-e2e/pom.xml:
##########
@@ -27,6 +27,12 @@
<modelVersion>4.0.0</modelVersion>
<artifactId>seatunnel-engine-e2e</artifactId>
+ <packaging>pom</packaging>
+
+ <modules>
+ <module>seatunnel-engine-e2e-base</module>
+ <module>seatunnel-engine-connector-console-e2e</module>
Review Comment:
Done
##########
seatunnel-core/seatunnel-flink-starter/src/main/java/org/apache/seatunnel/core/starter/flink/utils/CommandLineUtils.java:
##########
@@ -43,10 +42,10 @@ public static FlinkCommandArgs parseFlinkArgs(String[] args) {
return flinkCommandArgs;
}
- public static FlinkCommandArgs parseCommandArgs(String[] args, FlinkJobType jobType) {
+ public static FlinkCommandArgs parseCommandArgs(String[] args) {
FlinkCommandArgs flinkCommandArgs = new FlinkCommandArgs();
JCommander jCommander = JCommander.newBuilder()
- .programName(jobType.getType())
+ .programName("start-seatunnel-flink-connector-v2.sh")
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #2690: [ST-Engine][Starter] Add seatunnel own engine starter and e2e
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on code in PR #2690:
URL: https://github.com/apache/incubator-seatunnel/pull/2690#discussion_r966623735
##########
seatunnel-engine/seatunnel-engine-client/pom.xml:
##########
@@ -68,7 +68,7 @@
</dependency>
<dependency>
<groupId>org.apache.seatunnel</groupId>
- <artifactId>connector-file-local</artifactId>
+ <artifactId>connector-console</artifactId>
Review Comment:
just for test in client test module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #2690: [ST-Engine][Starter] Add seatunnel own engine starter and e2e
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on code in PR #2690:
URL: https://github.com/apache/incubator-seatunnel/pull/2690#discussion_r970724559
##########
seatunnel-core/README.md:
##########
@@ -5,4 +5,7 @@ This module is the seatunnel job entrypoint. Seatunnel jobs are started by the b
- seatunnel-core-flink: The flink job starter.
- seatunnel-core-flink-sql: The flink sql job starter.
-- seatunnel-core-spark: The spark job starter.
\ No newline at end of file
+- seatunnel-core-spark: The spark job starter.
Review Comment:
Yes, any suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #2690: [ST-Engine][Starter] Add seatunnel own engine starter and e2e
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on code in PR #2690:
URL: https://github.com/apache/incubator-seatunnel/pull/2690#discussion_r970851107
##########
seatunnel-core/README.md:
##########
@@ -5,4 +5,7 @@ This module is the seatunnel job entrypoint. Seatunnel jobs are started by the b
- seatunnel-core-flink: The flink job starter.
- seatunnel-core-flink-sql: The flink sql job starter.
-- seatunnel-core-spark: The spark job starter.
\ No newline at end of file
+- seatunnel-core-spark: The spark job starter.
Review Comment:
> Yes, any suggestion?
Got it.
From the name `seatunnel-core-spark` I can not know it's a starter. But now we don't care about it.
##########
seatunnel-core/README.md:
##########
@@ -5,4 +5,7 @@ This module is the seatunnel job entrypoint. Seatunnel jobs are started by the b
- seatunnel-core-flink: The flink job starter.
- seatunnel-core-flink-sql: The flink sql job starter.
-- seatunnel-core-spark: The spark job starter.
\ No newline at end of file
+- seatunnel-core-spark: The spark job starter.
Review Comment:
Got it.
From the name `seatunnel-core-spark` I can not know it's a starter. But now we don't care about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org