You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "spmallette (GitHub)" <gi...@apache.org> on 2019/02/12 17:15:32 UTC
[GitHub] [tinkerpop] spmallette opened pull request #1059: Improve
download page
I didn't bother to create a ticket for this as it's more of a administrative thing, but I've reworked the download page to have a dropdown list of the archived versions. In that way, the page doesn't scroll so much and other content lower in the page is more immediately visible. This should also make our release days a bit less error prone in retiring old versions to archives as it's now just a matter of editing the dropdown to include the archived versions - easier that cut/paste.
What I have is functional though perhaps not awesome in terms of jquery/bootstrap/js so if this can be improved please let me know. I feel like I've tested pretty well, but it would be great if a few folks could `bin/generate-home.sh` and try the mechanics out directly.
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1059 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] spmallette commented on issue #1059: Improve
download page
Posted by "spmallette (GitHub)" <gi...@apache.org>.
yes - i will update that before i merge.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1059 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] robertdale commented on issue #1059: Improve
download page
Posted by "robertdale (GitHub)" <gi...@apache.org>.
The current instructions are:
https://tinkerpop.apache.org/docs/current/dev/developer/#_pmc_vote
> PMC Vote
> 4. d. Update Downloads page, when moving "Current Releases" to "Archived Releases" recall that the hyperlink must change to point to version in the Apache Archives.
With this, we would just add a new `<option>` line and not have to update the archive links, correct?
[ Full content available at: https://github.com/apache/tinkerpop/pull/1059 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] spmallette closed pull request #1059: Improve
download page
Posted by "spmallette (GitHub)" <gi...@apache.org>.
[ pull request closed by spmallette ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1059 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] robertdale commented on issue #1059: Improve
download page
Posted by "robertdale (GitHub)" <gi...@apache.org>.
Firefox renders the dropdown as black.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1059 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] robertdale commented on issue #1059: Improve
download page
Posted by "robertdale (GitHub)" <gi...@apache.org>.
I pushed a fix. Looks like there is no 'bootstrap-select' class. I changed it to use the standard bootstrap form/select - https://getbootstrap.com/docs/3.3/css/#forms-controls
[ Full content available at: https://github.com/apache/tinkerpop/pull/1059 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] dkuppitz commented on issue #1059: Improve
download page
Posted by "dkuppitz (GitHub)" <gi...@apache.org>.
Looks, good, much cleaner now. I haven't tested all the links, but I picked out some random releases and all links worked as expected.
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1059 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org