You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/12/25 11:46:37 UTC

[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #13273: [Improvement][dao] Optimized countInstanceStateByProjectCodes

EricGao888 commented on code in PR #13273:
URL: https://github.com/apache/dolphinscheduler/pull/13273#discussion_r1056940739


##########
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessInstanceMapper.xml:
##########
@@ -178,14 +178,13 @@
         select t.state, count(0) as count
         from t_ds_process_instance t
         join t_ds_process_definition d on d.code=t.process_definition_code
-        join t_ds_project p on p.code=d.project_code
-        where 1 = 1
-        and t.is_sub_process = 0
+        where t.is_sub_process = 0

Review Comment:
   @hiSandog @Radeity What about adding a foreign key in `t_ds_process_definition_code` referencing `project code` in `t_ds_project`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org