You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Kurt Greaves (JIRA)" <ji...@apache.org> on 2018/09/04 09:13:00 UTC

[jira] [Commented] (CASSANDRA-14687) Revert parameterization of AuthCacheMBean interface

    [ https://issues.apache.org/jira/browse/CASSANDRA-14687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602801#comment-16602801 ] 

Kurt Greaves commented on CASSANDRA-14687:
------------------------------------------

+1. My bad, should have checked that.

> Revert parameterization of AuthCacheMBean interface
> ---------------------------------------------------
>
>                 Key: CASSANDRA-14687
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14687
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Auth
>            Reporter: Sam Tunnicliffe
>            Assignee: Sam Tunnicliffe
>            Priority: Major
>             Fix For: 4.0
>
>
> In CASSANDRA-14662, a type parameter {{<T>}} and {{invalidate<T t>}} method were added to {{AuthCacheMBean}} with the intention that this would automatically expose via JMX the {{invalidate}} method from {{AuthCache}} itself. Actually, this is not the case, as type erasure obscures the actual type of the parameter and so JMX clients like jconsole and jmc disable access to the method. 
> Only {{PasswordAuthenticator.CredentialsCache}} provided method like this previously, via {{CredentialsCacheMBean extends AuthCacheMBean}}, so the most straightforward fix is to just revert the change to {{AuthCacheMBean}}. Future/alternative cache implementations can continue to specify their own MBean interfaces to add specialised methods as before.
> I should've caught this before committing the CASSANDRA-14662 as it broke a couple of dtests in AuthTest, mea culpa.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org