[jira] [Comment Edited] (HTRACE-16) Remove guava dependency for htrace-core

["Colin Patrick McCabe (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HTRACE-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243816#comment-14243816 ] 

Colin Patrick McCabe edited comment on HTRACE-16 at 12/12/14 7:26 AM:
----------------------------------------------------------------------

committed, thanks!

I'm still having intermittent build issues with htrace-hbase, will comment in the "circularity" JIRA, I guess

[edit: everything builds fine when I build from top-level.  It looks like the only build I can't do is building the htrace-hbase subproject on its own.... it complains about not being able to find htrace-core.  Not a big deal, though, since I can build from top-level just fine.]


was (Author: cmccabe):
committed, thanks!

I'm still having intermittent build issues with htrace-hbase, will comment in the "circularity" JIRA, I guess

> Remove guava dependency for htrace-core
> ---------------------------------------
>
>                 Key: HTRACE-16
>                 URL: https://issues.apache.org/jira/browse/HTRACE-16
>             Project: HTrace
>          Issue Type: Improvement
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HTRACE-16.001.patch, HTRACE-16.001b.patch
>
>
> htrace-core currently depends on Guava.  It seems like there are a few Guava types exposed in public interfaces too.  This is unfortunate because Guava has a history of making non-backwards compatible changes without changing the namespace of the library.  So we could end up locked to a specific (old) version of Guava due to this.  It also interacts poorly with the shading we're doing.  We should just remove guava as a depdency so we don't have to worry about this issue in the future.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)