You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/03/16 23:53:07 UTC

[GitHub] [kafka] jolshan opened a new pull request #11909: KAFKA-13750: Client Compatability KafkaTest uses invalid idempotency configs

jolshan opened a new pull request #11909:
URL: https://github.com/apache/kafka/pull/11909


   With the switch to idempotency as a default, ClientCompatibilityFeaturesTest.run_compatibility_test broke for versions prior to 0.11 where EOS was enabled. This PR disables idempotency for kafka versions prior to 0.11.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac commented on pull request #11909: KAFKA-13750: Client Compatability KafkaTest uses invalid idempotency configs

Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #11909:
URL: https://github.com/apache/kafka/pull/11909#issuecomment-1071077188






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac commented on pull request #11909: KAFKA-13750: Client Compatability KafkaTest uses invalid idempotency configs

Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #11909:
URL: https://github.com/apache/kafka/pull/11909#issuecomment-1071077188


   @jolshan Thanks. Do we need to backport it to older branches? I guess that we need it in 3.1 and 3.0, right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jolshan commented on a change in pull request #11909: KAFKA-13750: Client Compatability KafkaTest uses invalid idempotency configs

Posted by GitBox <gi...@apache.org>.
jolshan commented on a change in pull request #11909:
URL: https://github.com/apache/kafka/pull/11909#discussion_r829541377



##########
File path: tools/src/main/java/org/apache/kafka/tools/ClientCompatibilityTest.java
##########
@@ -172,6 +174,13 @@ public static void main(String[] args) throws Exception {
             .dest("describeConfigsSupported")
             .metavar("DESCRIBE_CONFIGS_SUPPORTED")
             .help("Whether describeConfigs is supported in the AdminClient.");
+        parser.addArgument("--idempotent-producer-supported")
+                .action(store())
+                .required(true)
+                .type(Boolean.class)
+                .dest("idempotentProducerSupported")
+                .metavar("IDEMPOTENT_PRODUCER_SUPPORTED")
+                .help("Whether the producer supports idempotency.");

Review comment:
       Ah. How did I miss this 🤦‍♀️
   Thanks




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac merged pull request #11909: KAFKA-13750: Client Compatability KafkaTest uses invalid idempotency configs

Posted by GitBox <gi...@apache.org>.
dajac merged pull request #11909:
URL: https://github.com/apache/kafka/pull/11909


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on a change in pull request #11909: KAFKA-13750: Client Compatability KafkaTest uses invalid idempotency configs

Posted by GitBox <gi...@apache.org>.
showuon commented on a change in pull request #11909:
URL: https://github.com/apache/kafka/pull/11909#discussion_r828704440



##########
File path: tools/src/main/java/org/apache/kafka/tools/ClientCompatibilityTest.java
##########
@@ -172,6 +174,13 @@ public static void main(String[] args) throws Exception {
             .dest("describeConfigsSupported")
             .metavar("DESCRIBE_CONFIGS_SUPPORTED")
             .help("Whether describeConfigs is supported in the AdminClient.");
+        parser.addArgument("--idempotent-producer-supported")
+                .action(store())
+                .required(true)
+                .type(Boolean.class)
+                .dest("idempotentProducerSupported")
+                .metavar("IDEMPOTENT_PRODUCER_SUPPORTED")
+                .help("Whether the producer supports idempotency.");

Review comment:
       indent is not aligned with above lines.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac commented on pull request #11909: KAFKA-13750: Client Compatability KafkaTest uses invalid idempotency configs

Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #11909:
URL: https://github.com/apache/kafka/pull/11909#issuecomment-1070707701


   @jolshan Would you have a link to a successful run of the tests with your change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jolshan commented on a change in pull request #11909: KAFKA-13750: Client Compatability KafkaTest uses invalid idempotency configs

Posted by GitBox <gi...@apache.org>.
jolshan commented on a change in pull request #11909:
URL: https://github.com/apache/kafka/pull/11909#discussion_r829541377



##########
File path: tools/src/main/java/org/apache/kafka/tools/ClientCompatibilityTest.java
##########
@@ -172,6 +174,13 @@ public static void main(String[] args) throws Exception {
             .dest("describeConfigsSupported")
             .metavar("DESCRIBE_CONFIGS_SUPPORTED")
             .help("Whether describeConfigs is supported in the AdminClient.");
+        parser.addArgument("--idempotent-producer-supported")
+                .action(store())
+                .required(true)
+                .type(Boolean.class)
+                .dest("idempotentProducerSupported")
+                .metavar("IDEMPOTENT_PRODUCER_SUPPORTED")
+                .help("Whether the producer supports idempotency.");

Review comment:
       Ah. How did I miss this 🤦‍♀️
   Thanks




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac merged pull request #11909: KAFKA-13750: Client Compatability KafkaTest uses invalid idempotency configs

Posted by GitBox <gi...@apache.org>.
dajac merged pull request #11909:
URL: https://github.com/apache/kafka/pull/11909


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jolshan commented on pull request #11909: KAFKA-13750: Client Compatability KafkaTest uses invalid idempotency configs

Posted by GitBox <gi...@apache.org>.
jolshan commented on pull request #11909:
URL: https://github.com/apache/kafka/pull/11909#issuecomment-1070978591


   Here is a link to a successful run:
   
   http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2022-03-17--001.system-test-kafka-branch-builder--1647476641--jolshan--KAFKA-13750--4447ebdb4c/report.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jolshan commented on pull request #11909: KAFKA-13750: Client Compatability KafkaTest uses invalid idempotency configs

Posted by GitBox <gi...@apache.org>.
jolshan commented on pull request #11909:
URL: https://github.com/apache/kafka/pull/11909#issuecomment-1070978591


   Here is a link to a successful run:
   
   http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2022-03-17--001.system-test-kafka-branch-builder--1647476641--jolshan--KAFKA-13750--4447ebdb4c/report.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac commented on pull request #11909: KAFKA-13750: Client Compatability KafkaTest uses invalid idempotency configs

Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #11909:
URL: https://github.com/apache/kafka/pull/11909#issuecomment-1071090738


   We don't need to wait for the build as this is a python change. Merging to trunk, 3.1 and 3.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org