You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2018/07/03 08:30:32 UTC

[GitHub] flink pull request #6140: [FLINK-9554] flink scala shell doesn't work in yar...

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6140#discussion_r199724031
  
    --- Diff: flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala ---
    @@ -255,14 +257,25 @@ object FlinkShell {
         yarnConfig.queue.foreach((queue) => args ++= Seq("-yqu", queue.toString))
         yarnConfig.slots.foreach((slots) => args ++= Seq("-ys", slots.toString))
     
    +    val customCommandLines = CliFrontend.loadCustomCommandLines(
    +      configuration,configurationDirectory)
    +    val commandOptions = CliFrontendParser.getRunCommandOptions
    +    val customCommandLineOptions = new Options()
    +    customCommandLines.asScala.foreach(cmd => {
    --- End diff --
    
    this is already done int he `CliFrontend` constructor. It may be sufficient to switch the initialization of `frontend` and `commandLine`.


---