You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dlab.apache.org by dg...@apache.org on 2020/07/15 12:31:30 UTC
[incubator-dlab] branch DLAB-1748 updated: [DLAB-1750] small fix
This is an automated email from the ASF dual-hosted git repository.
dgnatyshyn pushed a commit to branch DLAB-1748
in repository https://gitbox.apache.org/repos/asf/incubator-dlab.git
The following commit(s) were added to refs/heads/DLAB-1748 by this push:
new 2295bde [DLAB-1750] small fix
2295bde is described below
commit 2295bde1da8bd22f51d41d6bb5d2ef6cda6f043b
Author: Dmytro_Gnatyshyn <di...@ukr.net>
AuthorDate: Wed Jul 15 15:31:13 2020 +0300
[DLAB-1750] small fix
---
.../exploratory/install-libraries/install-libraries.component.html | 6 +++---
.../exploratory/install-libraries/install-libraries.component.ts | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.html b/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.html
index 4cdc9f1..76edd7b 100644
--- a/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.html
+++ b/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.html
@@ -230,7 +230,7 @@
<div class="lib-destination-col">{{ item.resource }}</div>
<div class="lib-resource-type-col">{{ item.resourceType }}</div>
<div class="lib-status-col" ngClass="{{ item.status.toLowerCase() || 'failed' }}">{{ item.status }}
- <div class="warn-action" *ngIf="item.status === 'failed' && notebook?.status === 'running'">
+ <div class="warn-action" *ngIf="(item.status === 'failed' || item.status === 'invalid version') && notebook?.status === 'running'">
<div *ngIf="!item.available_versions">
<span *ngIf="!installingInProgress" (click)="reinstallLibrary(item, lib)" matTooltip="Retry installation" matTooltipPosition="above">
<i class="material-icons">replay</i>
@@ -240,11 +240,11 @@
<i class="material-icons">replay</i>
</span>
</div>
- <div *ngIf="item.status === 'failed' && item.error && !item.available_versions" class="lib-error" (click)="showErrorMessage(item)">
+ <div *ngIf="item.status === 'failed' && item.error" class="lib-error" (click)="showErrorMessage(item)">
<i class="material-icons">error_outline</i>
</div>
<div class="lib-error"
- *ngIf="(item.status === 'failed' || item.status?.toLowerCase() === 'invalid version') && item.available_versions?.length" class="lib-error"
+ *ngIf="item.status === 'invalid version' && item.available_versions?.length" class="lib-error"
(click)="openLibInfo(item, 'available');$event.stopPropagation()"
matTooltip="Show available version" matTooltipPosition="above"
>
diff --git a/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.ts b/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.ts
index 0976568..fa26a34 100644
--- a/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.ts
+++ b/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.ts
@@ -407,7 +407,7 @@ export class ErrorLibMessageDialogComponent {
public dialogRef: MatDialogRef<ErrorLibMessageDialogComponent>,
@Inject(MAT_DIALOG_DATA) public data: any
) {
- console.log(data);
+
}
}
@@ -495,6 +495,6 @@ export class LibInfoDialogComponent {
public dialogRef: MatDialogRef<ErrorLibMessageDialogComponent>,
@Inject(MAT_DIALOG_DATA) public data: any
) {
- console.log(data);
+
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@dlab.apache.org
For additional commands, e-mail: commits-help@dlab.apache.org