[jira] Commented: (HADOOP-2413) Is FSNamesystem.fsNamesystemObject unique?

["Konstantin Shvachko (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-2413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666751#action_12666751 ] 

Konstantin Shvachko commented on HADOOP-2413:
---------------------------------------------

You probably want to deprecate the {{static fsNamesystemObject}} member somewhere along the lines.

> Is FSNamesystem.fsNamesystemObject unique?
> ------------------------------------------
>
>                 Key: HADOOP-2413
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2413
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.15.1
>            Reporter: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>
> FSNamesystem is unique in almost all cases but it is not universally true.  So we should either remove the static variable FSNamesystem.fsNamesystemObject or make it final (so that it cannot be overwritten).
> When I am working on HADOOP-1298, I use the convenient static method FSNamesystem.getFSNamesystem() to get "the" FSNamesystem object.  However, it keeps failing on TestCheckpoint.  Why?  It is because TestCheckpoint uses NameNode and SecondaryNameNode.  Both of them are creating FSNamesystem.  So FSNamesystem.fsNamesystemObject does not remain constant.  The kind of bug is hard to be detected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.