You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/01/12 22:08:01 UTC
[GitHub] [geode] jdeppe-pivotal opened a new pull request #5897: GEODE-8782: Add getPrincipal method to FunctionContext interface
jdeppe-pivotal opened a new pull request #5897:
URL: https://github.com/apache/geode/pull/5897
- Add the ability to retrieve the Principal from the FunctionContext
when a SecurityManager is enabled.
- For rolling upgrade purposes this also includes a new ordinal
version for GEODE_1_12_1.
(cherry picked from commit a42f89ab48aaca9aac96a34e80a9b3b2d46bcddd)
(cherry picked from commit 0ab677199d189527be354fd1427ce29b91ed6b31)
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on a change in pull request #5897: GEODE-8782: Add getPrincipal method to FunctionContext interface
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on a change in pull request #5897:
URL: https://github.com/apache/geode/pull/5897#discussion_r556133161
##########
File path: settings.gradle
##########
@@ -85,7 +85,8 @@ include 'static-analysis:pmd-rules'
'1.9.2',
'1.10.0',
'1.11.0',
- '1.12.0'].each {
+ '1.12.0',
+ '1.13.0'].each {
Review comment:
this list should actually include 1.13.1 as well (release Nov 18). Thanks for spotting this. I'll fix release scripts, which should have kept this up to date...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on pull request #5897: GEODE-8782: Add getPrincipal method to FunctionContext interface
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on pull request #5897:
URL: https://github.com/apache/geode/pull/5897#issuecomment-761084589
looks good!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal edited a comment on pull request #5897: GEODE-8782: Add getPrincipal method to FunctionContext interface
Posted by GitBox <gi...@apache.org>.
onichols-pivotal edited a comment on pull request #5897:
URL: https://github.com/apache/geode/pull/5897#issuecomment-759637240
If memory serves, we had similar port conflict errors on develop after 1.13.1 was released, which was solved by 9d139b54a2d5229e5415bbed6e01ee95dc5151ec. I've cherry-picked that fix to your PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on a change in pull request #5897: GEODE-8782: Add getPrincipal method to FunctionContext interface
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on a change in pull request #5897:
URL: https://github.com/apache/geode/pull/5897#discussion_r556135343
##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CommandInitializer.java
##########
@@ -338,7 +338,9 @@ public static void registerCommand(int messageType, Map<Version, Command> versio
allCommands.put(Version.GEODE_1_10_0, geode18Commands);
allCommands.put(Version.GEODE_1_11_0, geode18Commands);
allCommands.put(Version.GEODE_1_12_0, geode18Commands);
+ allCommands.put(Version.GEODE_1_12_1, geode18Commands);
allCommands.put(Version.GEODE_1_13_0, geode18Commands);
+ allCommands.put(Version.GEODE_1_13_1, geode18Commands);
Review comment:
Will need another PR to add GEODE_1_12_1 and GEODE_1_13_1 to develop as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5897: GEODE-8782: Add getPrincipal method to FunctionContext interface
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal commented on a change in pull request #5897:
URL: https://github.com/apache/geode/pull/5897#discussion_r556138016
##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CommandInitializer.java
##########
@@ -338,7 +338,9 @@ public static void registerCommand(int messageType, Map<Version, Command> versio
allCommands.put(Version.GEODE_1_10_0, geode18Commands);
allCommands.put(Version.GEODE_1_11_0, geode18Commands);
allCommands.put(Version.GEODE_1_12_0, geode18Commands);
+ allCommands.put(Version.GEODE_1_12_1, geode18Commands);
allCommands.put(Version.GEODE_1_13_0, geode18Commands);
+ allCommands.put(Version.GEODE_1_13_1, geode18Commands);
Review comment:
ðŸ˜
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on a change in pull request #5897: GEODE-8782: Add getPrincipal method to FunctionContext interface
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on a change in pull request #5897:
URL: https://github.com/apache/geode/pull/5897#discussion_r556133161
##########
File path: settings.gradle
##########
@@ -85,7 +85,8 @@ include 'static-analysis:pmd-rules'
'1.9.2',
'1.10.0',
'1.11.0',
- '1.12.0'].each {
+ '1.12.0',
+ '1.13.0'].each {
Review comment:
was this branched from latest support/1.13...? 1.13.0 *and 1.13.1* were already in this list on support/1.13, and have been since 6a29ffbef5f when we released Geode 1.13.1 on Nov 18.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on a change in pull request #5897: GEODE-8782: Add getPrincipal method to FunctionContext interface
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on a change in pull request #5897:
URL: https://github.com/apache/geode/pull/5897#discussion_r556133161
##########
File path: settings.gradle
##########
@@ -85,7 +85,8 @@ include 'static-analysis:pmd-rules'
'1.9.2',
'1.10.0',
'1.11.0',
- '1.12.0'].each {
+ '1.12.0',
+ '1.13.0'].each {
Review comment:
was this branched from latest support/1.13...? 1.13.0 *and 1.13.1* are already in this list on support/1.13 since we released Geode 1.13.1 on Nov 18.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on a change in pull request #5897: GEODE-8782: Add getPrincipal method to FunctionContext interface
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on a change in pull request #5897:
URL: https://github.com/apache/geode/pull/5897#discussion_r556133161
##########
File path: settings.gradle
##########
@@ -85,7 +85,8 @@ include 'static-analysis:pmd-rules'
'1.9.2',
'1.10.0',
'1.11.0',
- '1.12.0'].each {
+ '1.12.0',
+ '1.13.0'].each {
Review comment:
this list should actually include 1.13.1 (released Nov 18) as well. Thanks for spotting this. I'll fix release scripts, which should have kept this up to date. I can fix this separately after you merge if you have no other changes to make for this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on a change in pull request #5897: GEODE-8782: Add getPrincipal method to FunctionContext interface
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on a change in pull request #5897:
URL: https://github.com/apache/geode/pull/5897#discussion_r556133161
##########
File path: settings.gradle
##########
@@ -85,7 +85,8 @@ include 'static-analysis:pmd-rules'
'1.9.2',
'1.10.0',
'1.11.0',
- '1.12.0'].each {
+ '1.12.0',
+ '1.13.0'].each {
Review comment:
good catch on this. release script should have been keeping this up to date, hmm. and both 1.13.0 **and 1.13.1** should be listed here, as both are released
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on a change in pull request #5897: GEODE-8782: Add getPrincipal method to FunctionContext interface
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on a change in pull request #5897:
URL: https://github.com/apache/geode/pull/5897#discussion_r556133161
##########
File path: settings.gradle
##########
@@ -85,7 +85,8 @@ include 'static-analysis:pmd-rules'
'1.9.2',
'1.10.0',
'1.11.0',
- '1.12.0'].each {
+ '1.12.0',
+ '1.13.0'].each {
Review comment:
was this branched from latest support/1.13...? 1.13.0 *and 1.13.1* were already in this list on support/1.13, and have been since we released Geode 1.13.1 on Nov 18.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal edited a comment on pull request #5897: GEODE-8782: Add getPrincipal method to FunctionContext interface
Posted by GitBox <gi...@apache.org>.
onichols-pivotal edited a comment on pull request #5897:
URL: https://github.com/apache/geode/pull/5897#issuecomment-759637240
If memory serves, we had similar port conflict errors on develop after 1.13.1 was released, which were solved by 9d139b54a2d5229e5415bbed6e01ee95dc5151ec or maybe 430debe91d14d3bccec3772e9dd31dd79d3d4529
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on pull request #5897: GEODE-8782: Add getPrincipal method to FunctionContext interface
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on pull request #5897:
URL: https://github.com/apache/geode/pull/5897#issuecomment-759637240
If memory serves, we had similar port conflict errors on develop after 1.13.1 was released, which were solved by 430debe91d14d3bccec3772e9dd31dd79d3d4529
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal merged pull request #5897: GEODE-8782: Add getPrincipal method to FunctionContext interface
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal merged pull request #5897:
URL: https://github.com/apache/geode/pull/5897
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org