[PR] [ISSUE-3844][test] Deepen ApacheRocketMqClusterMetricsCollectorTest with master-less brokers, missing stats and invalid ratios [rocketmq-dashboard]

["yyqdbngt (via GitHub)" <gi...@apache.org>]

yyqdbngt opened a new pull request, #3844:
URL: https://github.com/apache/rocketmq-dashboard/pull/3844

   ### Motivation
   
   The existing `ApacheRocketMqClusterMetricsCollectorTest` covers the healthy topology, the nameserver failure and vendor skipping. Three broker-level shapes were untested: brokers without a master address, brokers without runtime stats and out-of-range ratio values.
   
   ### Changes
   
   - `brokerWithoutMasterAddressIsMarkedUnavailable`: a broker with only slave addresses reports unavailable broker availability without a brokerAddr label.
   - `brokerWithoutRuntimeStatsIsMarkedUnavailable`: a null runtime stats response marks the broker unavailable and emits no disk ratio.
   - `outOfRangeRatioValuesAreOmitted`: disk ratios above 100 and heap usage above capacity are dropped while the valid send-queue ratio is still reported.
   
   ### Verification
   
   ```
   mvn -B test -Dtest=ApacheRocketMqClusterMetricsCollectorTest
   [INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0
   [INFO] BUILD SUCCESS
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ISSUE-3844][test] Deepen ApacheRocketMqClusterMetricsCollectorTest with master-less brokers, missing stats and invalid ratios [rocketmq-dashboard]

["lizhimins (via GitHub)" <gi...@apache.org>]

lizhimins closed pull request #3844: [ISSUE-3844][test] Deepen ApacheRocketMqClusterMetricsCollectorTest with master-less brokers, missing stats and invalid ratios
URL: https://github.com/apache/rocketmq-dashboard/pull/3844


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org