You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/10 14:22:36 UTC
[GitHub] [superset] michael-s-molina opened a new pull request #13548: test: Fixes PropertiesModal_spec
michael-s-molina opened a new pull request #13548:
URL: https://github.com/apache/superset/pull/13548
### SUMMARY
Fixes `PropertiesModal_spec` error in Node 15.
<img width="1320" alt="109978301-81f68c00-7cdc-11eb-826c-86a3874da8fa" src="https://user-images.githubusercontent.com/70410625/110642858-36d3f180-8192-11eb-94b8-2d3330d2dd7a.png">
In Node 15 they changed the way to handle [promise rejections](https://developer.ibm.com/languages/node-js/blogs/nodejs-15-release-blog/). In previous versions of Node, promise rejections are handled as warnings, so the test pass but that doesn't mean that the test is correct. I fixed the code that was causing the promise rejection and now the test also passes in Node 15.
### TEST PLAN
1 - Execute `PropertiesModal_spec` tests
2 - All tests should pass
@rusackas @simcha90
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13548: test: Fixes PropertiesModal_spec
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13548:
URL: https://github.com/apache/superset/pull/13548#issuecomment-795520729
# [Codecov](https://codecov.io/gh/apache/superset/pull/13548?src=pr&el=h1) Report
> Merging [#13548](https://codecov.io/gh/apache/superset/pull/13548?src=pr&el=desc) (84d461c) into [master](https://codecov.io/gh/apache/superset/commit/1d1a1cdc208a7df6e45bffaac3e99675a61e0a20?el=desc) (1d1a1cd) will **decrease** coverage by `3.74%`.
> The diff coverage is `28.23%`.
[](https://codecov.io/gh/apache/superset/pull/13548?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13548 +/- ##
==========================================
- Coverage 77.31% 73.56% -3.75%
==========================================
Files 903 603 -300
Lines 45926 21406 -24520
Branches 5624 5641 +17
==========================================
- Hits 35508 15748 -19760
+ Misses 10282 5524 -4758
+ Partials 136 134 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.21% <13.63%> (+0.75%)` | :arrow_up: |
| javascript | `63.39% <28.23%> (-0.10%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13548?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13548/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/13548/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `64.10% <0.00%> (-3.47%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/13548/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `40.90% <ø> (ø)` | |
| [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/13548/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `39.13% <0.00%> (-1.78%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13548/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
| [.../nativeFilters/FilterBar/FilterSets/FilterSets.tsx](https://codecov.io/gh/apache/superset/pull/13548/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0cy50c3g=) | `18.30% <8.33%> (+0.12%)` | :arrow_up: |
| [...onents/nativeFilters/FilterBar/FilterSets/utils.ts](https://codecov.io/gh/apache/superset/pull/13548/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvdXRpbHMudHM=) | `27.58% <21.42%> (-5.75%)` | :arrow_down: |
| [...d/components/nativeFilters/FilterBar/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/13548/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckJhci50c3g=) | `91.37% <33.33%> (-2.32%)` | :arrow_down: |
| [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/13548/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `35.55% <35.55%> (ø)` | |
| [...ents/nativeFilters/FilterBar/FilterSets/Footer.tsx](https://codecov.io/gh/apache/superset/pull/13548/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRm9vdGVyLnRzeA==) | `56.25% <50.00%> (ø)` | |
| ... and [313 more](https://codecov.io/gh/apache/superset/pull/13548/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13548?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13548?src=pr&el=footer). Last update [1d1a1cd...261dda5](https://codecov.io/gh/apache/superset/pull/13548?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #13548: test: Fixes PropertiesModal_spec
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #13548:
URL: https://github.com/apache/superset/pull/13548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org