You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Puneet Gupta <pu...@gmail.com> on 2016/01/14 13:32:15 UTC

Review Request 42300: Lens Session Config gets corrupted on server restart

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42300/
-----------------------------------------------------------

Review request for lens.


Bugs: LENS-924
    https://issues.apache.org/jira/browse/LENS-924


Repository: lens


Description
-------

Lens Session Config gets corrupted on server restart


Diffs
-----

  lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java cc62d92 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java c5d75de 

Diff: https://reviews.apache.org/r/42300/diff/


Testing
-------

[INFO] Lens Checkstyle Rules .............................. SUCCESS [  4.097 s]
[INFO] Lens ............................................... SUCCESS [  6.401 s]
[INFO] Lens API ........................................... SUCCESS [  2.702 s]
[INFO] Lens API for server and extensions ................. SUCCESS [  6.560 s]
[INFO] Lens Cube .......................................... SUCCESS [  2.008 s]
[INFO] Lens DB storage .................................... SUCCESS [  0.742 s]
[INFO] Lens Query Library ................................. SUCCESS [  0.615 s]
[INFO] Lens Hive Driver ................................... SUCCESS [  3.452 s]
[INFO] Lens Driver for JDBC ............................... SUCCESS [  1.441 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [  1.964 s]
[INFO] Lens Server ........................................ SUCCESS [ 58.329 s]
[INFO] Lens client ........................................ SUCCESS [  2.403 s]
[INFO] Lens CLI ........................................... SUCCESS [  2.153 s]
[INFO] Lens Examples ...................................... SUCCESS [  0.829 s]
[INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [  0.486 s]
[INFO] Lens Distribution .................................. SUCCESS [  1.076 s]
[INFO] Lens ML Lib ........................................ SUCCESS [  4.890 s]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [  2.728 s]
[INFO] Lens Regression .................................... SUCCESS [  0.778 s]
[INFO] Lens UI ............................................ SUCCESS [ 17.700 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:03 min
[INFO] Finished at: 2016-01-14T17:05:12+05:30
[INFO] Final Memory: 94M/723M


1. New check added to test case checkDefaultConfig : TestQueryService.checkDefaultConfigConsistency()
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.lens.server.query.TestQueryService
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 35.182 sec - in org.apache.lens.server.query.TestQueryService

Results :

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0


Thanks,

Puneet Gupta


Re: Review Request 42300: Lens Session Config gets corrupted on server restart

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42300/#review114469
-----------------------------------------------------------



lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java (line 69)
<https://reviews.apache.org/r/42300/#comment175322>

    Can we avoid creation here if creation is already happening in createDefaultConf() ?


- Amareshwari Sriramadasu


On Jan. 14, 2016, 12:32 p.m., Puneet Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42300/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2016, 12:32 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-924
>     https://issues.apache.org/jira/browse/LENS-924
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Lens Session Config gets corrupted on server restart
> 
> 
> Diffs
> -----
> 
>   lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java cc62d92 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java c5d75de 
> 
> Diff: https://reviews.apache.org/r/42300/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [  4.097 s]
> [INFO] Lens ............................................... SUCCESS [  6.401 s]
> [INFO] Lens API ........................................... SUCCESS [  2.702 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [  6.560 s]
> [INFO] Lens Cube .......................................... SUCCESS [  2.008 s]
> [INFO] Lens DB storage .................................... SUCCESS [  0.742 s]
> [INFO] Lens Query Library ................................. SUCCESS [  0.615 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [  3.452 s]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [  1.441 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [  1.964 s]
> [INFO] Lens Server ........................................ SUCCESS [ 58.329 s]
> [INFO] Lens client ........................................ SUCCESS [  2.403 s]
> [INFO] Lens CLI ........................................... SUCCESS [  2.153 s]
> [INFO] Lens Examples ...................................... SUCCESS [  0.829 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [  0.486 s]
> [INFO] Lens Distribution .................................. SUCCESS [  1.076 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [  4.890 s]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [  2.728 s]
> [INFO] Lens Regression .................................... SUCCESS [  0.778 s]
> [INFO] Lens UI ............................................ SUCCESS [ 17.700 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 02:03 min
> [INFO] Finished at: 2016-01-14T17:05:12+05:30
> [INFO] Final Memory: 94M/723M
> 
> 
> 1. New check added to test case checkDefaultConfig : TestQueryService.checkDefaultConfigConsistency()
> -------------------------------------------------------
>  T E S T S
> -------------------------------------------------------
> Running org.apache.lens.server.query.TestQueryService
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 35.182 sec - in org.apache.lens.server.query.TestQueryService
> 
> Results :
> 
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> 
> 
> Thanks,
> 
> Puneet Gupta
> 
>


Re: Review Request 42300: Lens Session Config gets corrupted on server restart

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42300/#review114939
-----------------------------------------------------------

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Jan. 18, 2016, 2:28 a.m., Puneet Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42300/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2016, 2:28 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-924
>     https://issues.apache.org/jira/browse/LENS-924
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Lens Session Config gets corrupted on server restart
> 
> 
> Diffs
> -----
> 
>   lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java cc62d92 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java c5d75de 
> 
> Diff: https://reviews.apache.org/r/42300/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [  4.097 s]
> [INFO] Lens ............................................... SUCCESS [  6.401 s]
> [INFO] Lens API ........................................... SUCCESS [  2.702 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [  6.560 s]
> [INFO] Lens Cube .......................................... SUCCESS [  2.008 s]
> [INFO] Lens DB storage .................................... SUCCESS [  0.742 s]
> [INFO] Lens Query Library ................................. SUCCESS [  0.615 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [  3.452 s]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [  1.441 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [  1.964 s]
> [INFO] Lens Server ........................................ SUCCESS [ 58.329 s]
> [INFO] Lens client ........................................ SUCCESS [  2.403 s]
> [INFO] Lens CLI ........................................... SUCCESS [  2.153 s]
> [INFO] Lens Examples ...................................... SUCCESS [  0.829 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [  0.486 s]
> [INFO] Lens Distribution .................................. SUCCESS [  1.076 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [  4.890 s]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [  2.728 s]
> [INFO] Lens Regression .................................... SUCCESS [  0.778 s]
> [INFO] Lens UI ............................................ SUCCESS [ 17.700 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 02:03 min
> [INFO] Finished at: 2016-01-14T17:05:12+05:30
> [INFO] Final Memory: 94M/723M
> 
> 
> 1. New check added to test case checkDefaultConfig : TestQueryService.checkDefaultConfigConsistency()
> -------------------------------------------------------
>  T E S T S
> -------------------------------------------------------
> Running org.apache.lens.server.query.TestQueryService
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 35.182 sec - in org.apache.lens.server.query.TestQueryService
> 
> Results :
> 
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> 
> 
> Thanks,
> 
> Puneet Gupta
> 
>


Re: Review Request 42300: Lens Session Config gets corrupted on server restart

Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42300/
-----------------------------------------------------------

(Updated Jan. 18, 2016, 2:28 a.m.)


Review request for lens.


Bugs: LENS-924
    https://issues.apache.org/jira/browse/LENS-924


Repository: lens


Description
-------

Lens Session Config gets corrupted on server restart


Diffs (updated)
-----

  lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java cc62d92 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java c5d75de 

Diff: https://reviews.apache.org/r/42300/diff/


Testing
-------

[INFO] Lens Checkstyle Rules .............................. SUCCESS [  4.097 s]
[INFO] Lens ............................................... SUCCESS [  6.401 s]
[INFO] Lens API ........................................... SUCCESS [  2.702 s]
[INFO] Lens API for server and extensions ................. SUCCESS [  6.560 s]
[INFO] Lens Cube .......................................... SUCCESS [  2.008 s]
[INFO] Lens DB storage .................................... SUCCESS [  0.742 s]
[INFO] Lens Query Library ................................. SUCCESS [  0.615 s]
[INFO] Lens Hive Driver ................................... SUCCESS [  3.452 s]
[INFO] Lens Driver for JDBC ............................... SUCCESS [  1.441 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [  1.964 s]
[INFO] Lens Server ........................................ SUCCESS [ 58.329 s]
[INFO] Lens client ........................................ SUCCESS [  2.403 s]
[INFO] Lens CLI ........................................... SUCCESS [  2.153 s]
[INFO] Lens Examples ...................................... SUCCESS [  0.829 s]
[INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [  0.486 s]
[INFO] Lens Distribution .................................. SUCCESS [  1.076 s]
[INFO] Lens ML Lib ........................................ SUCCESS [  4.890 s]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [  2.728 s]
[INFO] Lens Regression .................................... SUCCESS [  0.778 s]
[INFO] Lens UI ............................................ SUCCESS [ 17.700 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:03 min
[INFO] Finished at: 2016-01-14T17:05:12+05:30
[INFO] Final Memory: 94M/723M


1. New check added to test case checkDefaultConfig : TestQueryService.checkDefaultConfigConsistency()
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.lens.server.query.TestQueryService
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 35.182 sec - in org.apache.lens.server.query.TestQueryService

Results :

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0


Thanks,

Puneet Gupta