[GitHub] [calcite] yanlin-Lynn commented on a change in pull request #2189: [CALCITE-4251] Overload RelMetadataQuery#getColumnOrigin method (xzh)

[GitBox <gi...@apache.org>]

yanlin-Lynn commented on a change in pull request #2189:
URL: https://github.com/apache/calcite/pull/2189#discussion_r521350910



##########
File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMetadataQuery.java
##########
@@ -351,11 +353,32 @@ public Double getPercentageOriginalRows(RelNode rel) {
    * returns null
    */
   public RelColumnOrigin getColumnOrigin(RelNode rel, int column) {
+    return getColumnOrigin(rel, column, false);
+  }
+
+  /**
+   * Determines the origin of a column. If the param derived is false, provided the column maps
+   * to a single column that isn't derived, otherwise the column is derived.

Review comment:
       I think what you mean is 
   "
   Determines the origin of a column, allow users to choose whether to include the derived column."




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org