[jira] [Commented] (XBEAN-263) creating ClassInfo for an annotated Class object throws NPE

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/XBEAN-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14002084#comment-14002084 ] 

ASF GitHub Bot commented on XBEAN-263:
--------------------------------------

GitHub user mbenson opened a pull request:

    https://github.com/apache/geronimo-xbean/pull/6

    XBEAN-263

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mbenson/geronimo-xbean XBEAN-263

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geronimo-xbean/pull/6.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6
    
----
commit ae673934468b8729372f4dd2178d435613f74658
Author: Matt Benson <gu...@gmail.com>
Date:   2014-05-19T18:05:42Z

    failing testcase

commit 88331796b0ef70966d4d31ebc14f831aee720632
Author: Matt Benson <gu...@gmail.com>
Date:   2014-05-19T18:06:13Z

    [XBEAN-263] fix

----


> creating ClassInfo for an annotated Class object throws NPE
> -----------------------------------------------------------
>
>                 Key: XBEAN-263
>                 URL: https://issues.apache.org/jira/browse/XBEAN-263
>             Project: XBean
>          Issue Type: Bug
>          Components: finder
>    Affects Versions: 3.17
>            Reporter: Matt Benson
>
> The class-based, as opposed to signature-based. portion of {{AnnotationFinder}} is rather difficult to test, but I have been able to create a failing test case. The issue is that {{Annotatable(AnnotatedElement)}} calls the {{AnnotationInfo}} constructor using the classname of the {{annotationType}} which, in turn, calls ASM's {{Type.getType(String)}}; however, this method wants a type descriptor (the method's Javadoc actually says "a field or method type descriptor"). Calling {{AnnotationInfo(Class)}} instead solves the problem. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)