You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2018/03/26 21:49:49 UTC

Review Request 66293: Added test for default executor support of max_duration.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66293/
-----------------------------------------------------------

Review request for mesos, Jason Lai and James Peach.


Bugs: MESOS-8725
    https://issues.apache.org/jira/browse/MESOS-8725


Repository: mesos


Description
-------

Added test for default executor support of max_duration.


Diffs
-----

  src/tests/default_executor_tests.cpp 293dd20d882447401572835bd31e197faf76861b 


Diff: https://reviews.apache.org/r/66293/diff/1/


Testing
-------


Thanks,

Zhitao Li

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66293/#review201051
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66258', '66591', '66259', '66260', '66283', '66284', '66291', '66293']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66293

Relevant logs:

- [mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66293/logs/mesos-tests-cmake-stdout.log):

```
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3500): warning C4996: 'inet_ntoa': Use inet_ntop() or InetNtop() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3501): warning C4996: 'sprintf': This function or variable may be unsafe. Consider using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3479): warning C4101: 'addrstr': unreferenced local variable [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\recordio.c(170): warning C4267: '=': conversion from 'size_t' to 'int32_t', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\mt_adaptor.c(496): warning C4244: '=': conversion from 'time_t' to 'int32_t', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(256): warning C4090: 'function': different 'const' qualifiers [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(166): warning C4716: 'pthread_cond_broadcast': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205): warning C4716: 'pthread_cond_wait': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(372): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(512): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(543): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(548): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(569): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]


       "D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
       (Link target) -> 
         mesos.lib(validation.cpp.obj) : error LNK2019: unresolved external symbol "class Option<class Error> __cdecl mesos::internal::master::validation::task::internal::validateMaxCompletionTime(class mesos::TaskInfo const &)" (?validateMaxCompletionTime@internal@task@validation@master@1mesos@@YA?AV?$Option@VError@@@@AEBVTaskInfo@5@@Z) referenced in function "class Option<class Error> __cdecl mesos::internal::master::validation::task::internal::validateTask(class mesos::TaskInfo const &,struct mesos::internal::master::Framework *,struct mesos::internal::master::Slave *)" (?validateTask@internal@task@validation@master@1mesos@@YA?AV?$Option@VError@@@@AEBVTaskInfo@5@PEAUFramework@415@PEAUSlave@415@@Z) [D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
         D:\DCOS\mesos\src\mesos-tests.exe : fatal error LNK1120: 1 unresolved externals [D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]

    172 Warning(s)
    2 Error(s)

Time Elapsed 00:31:30.62
```

- Mesos Reviewbot Windows


On April 7, 2018, 5:54 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66293/
> -----------------------------------------------------------
> 
> (Updated April 7, 2018, 5:54 p.m.)
> 
> 
> Review request for mesos, Jason Lai and James Peach.
> 
> 
> Bugs: MESOS-8725
>     https://issues.apache.org/jira/browse/MESOS-8725
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Tested default executor support of `max_completion_time`.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp 293dd20d882447401572835bd31e197faf76861b 
> 
> 
> Diff: https://reviews.apache.org/r/66293/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66293/#review200720
-----------------------------------------------------------



Patch looks great!

Reviews applied: [66481, 66258, 66259, 66260, 66283, 66284, 66291, 66293]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 8, 2018, 12:54 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66293/
> -----------------------------------------------------------
> 
> (Updated April 8, 2018, 12:54 a.m.)
> 
> 
> Review request for mesos, Jason Lai and James Peach.
> 
> 
> Bugs: MESOS-8725
>     https://issues.apache.org/jira/browse/MESOS-8725
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Tested default executor support of `max_completion_time`.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp 293dd20d882447401572835bd31e197faf76861b 
> 
> 
> Diff: https://reviews.apache.org/r/66293/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66293/#review201813
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66258', '66591', '66259', '66260', '66283', '66284', '66291', '66293']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66293

Relevant logs:

- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66293/logs/mesos-tests-stdout.log):

```
[ RUN      ] ContentType/SchedulerTest.KillTask/1
[       OK ] ContentType/SchedulerTest.KillTask/1 (14927 ms)
[ RUN      ] ContentType/SchedulerTest.OperationFeedbackValidationWithResourceProviderCapability/0
[       OK ] ContentType/SchedulerTest.OperationFeedbackValidationWithResourceProviderCapability/0 (14682 ms)
[ RUN      ] ContentType/SchedulerTest.OperationFeedbackValidationWithResourceProviderCapability/1
[       OK ] ContentType/SchedulerTest.OperationFeedbackValidationWithResourceProviderCapability/1 (14627 ms)
[ RUN      ] ContentType/SchedulerTest.OperationFeedbackValidationNoResourceProviderCapability/0
[       OK ] ContentType/SchedulerTest.OperationFeedbackValidationNoResourceProviderCapability/0 (14801 ms)
[ RUN      ] ContentType/SchedulerTest.OperationFeedbackValidationNoResourceProviderCapability/1
[       OK ] ContentType/SchedulerTest.OperationFeedbackValidationNoResourceProviderCapability/1 (14179 ms)
[ RUN      ] ContentType/SchedulerTest.OperationFeedbackValidationSchedulerDriverFramework/0
[       OK ] ContentType/SchedulerTest.OperationFeedbackValidationSchedulerDriverFramework/0 (14767 ms)
[ RUN      ] ContentType/SchedulerTest.OperationFeedbackValidationSchedulerDriverFramework/1
[       OK ] ContentType/SchedulerTest.OperationFeedbackValidationSchedulerDriverFramework/1 (14841 ms)
[ RUN      ] ContentType/SchedulerTest.ShutdownExecutor/0
[       OK ] ContentType/SchedulerTest.ShutdownExecutor/0 (14660 ms)
[ RUN      ] ContentType/SchedulerTest.ShutdownExecutor/1
[       OK ] ContentType/SchedulerTest.ShutdownExecutor/1 (14903 ms)
[ RUN      ] ContentType/SchedulerTest.Decline/0
[       OK ] ContentType/SchedulerTest.Decline/0 (14539 ms)
[ RUN      ] ContentType/SchedulerTest.Decline/1
[       OK ] ContentType/SchedulerTest.Decline/1 (14427 ms)
[ RUN      ] ContentType/SchedulerTest.Revive/0
[       OK ] ContentType/SchedulerTest.Revive/0 (14650 ms)
[ RUN      ] ContentType/SchedulerTest.Revive/1
[       OK ] ContentType/SchedulerTest.Revive/1 (14386 ms)
[ RUN      ] ContentType/SchedulerTest.Suppress/0
[       OK ] ContentType/SchedulerTest.Suppress/0 (14642 ms)
[ RUN      ] ContentType/SchedulerTest.Suppress/1
```

- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66293/logs/mesos-tests-stderr.log):

```
I0424 05:04:34.089884  8184 master.cpp:1411] Framework 364e13be-0829-4622-a1d3-aafe15544912-0000 (default) disconnected
I0424 05:04:34.089884  8184 master.cpp:3259] Deactivating framework 364e13be-0829-4622-a1d3-aafe15544912-0000 (default)
I0424 05:04:34.090879 13968 hierarchical.cpp:405] Deactivated framework 364e13be-0829-4622-a1d3-aafe15544912-0000
W0424 05:04:34.091893  8184 master.hpp:2342] Unable to send event to framework 364e13be-0829-4622-a1d3-aafe15544912-0000 (default): connection closed
I0424 05:04:34.091893  8184 master.cpp:11069] Removing offer 364e13be-0829-4622-a1d3-aafe15544912-O1
I0424 05:04:34.091893  8184 master.cpp:3236] Disconnecting framework 364e13be-0829-4622-a1d3-aafe15544912-0000 (default)
I0424 05:04:34.092893  8184 master.cpp:1426] Giving framework 364e13be-0829-4622-a1d3-aafe15544912-0000 (default) 0ns to failover
I0424 05:04:34.094152 12436 master.cpp:8935] Framework failover timeout, removing framework 364e13be-0829-4622-a1d3-aafe15544912-0000 (default)
I0424 05:04:34.094152 12436 master.cpp:9829] Removing framework 364e13be-0829-4622-a1d3-aafe15544912-0000 (default)
W0424 05:04:34.094152 11476 slave.cpp:3902] Ignoring shutdown framework message for 364e13be-0829-4622-a1d3-aafe15544912-0000 because the agent has not yet registered with the master
I0424 05:04:34.094894  7956 hierarchical.cpp:344] Removed framework 364e13be-0829-4622-a1d3-aafe15544912-0000
I0424 05:04:34.096894 15552 slave.cpp:919] Agent terminating
I0424 05:04:34.096894  7292 master.cpp:1296] Agent 364e13be-0829-4622-a1d3-aafe15544912-S0 at slave(419)@172.27.128.1:59222 (winbldsrv-02) disconnected
I0424 05:04:34.096894  7292 master.cpp:3296] Disconnecting agent 364e13be-0829-4622-a1d3-aafe15544912-S0 at slave(419)@172.27.128.1:59222 (winbldsrv-02)
I0424 05:04:34.097995  7292 master.cpp:3315] Deactivating agent 364e13be-0829-4622-a1d3-aafe15544912-S0 at slave(419)@172.27.128.1:59222 (winbldsrv-02)
I0424 05:04:34.098883 11476 hierarchical.cpp:766] Agent 364e13be-0829-4622-a1d3-aafe15544912-S0 deactivated
I0424 05:04:34.123895 15552 master.cpp:1138] Master terminating
I0424 05:04:34.126891 11520 hierarchical.cpp:609] Removed agent 364e13be-0829-4622-a1d3-aafe15544912-S0
I0424 05:04:34.161900 15552 cluster.cpp:172] Creating default 'local' authorizer
I0424 05:04:38.727352 15128 master.cpp:463] Master 594c8167-298b-4506-9dac-adc18149e533 (winbldsrv-02) started on 172.27.128.1:59222
I0424 05:04:38.727352 15128 master.cpp:466] Flags at startup: --acls="" --agent_ping_timeout="15secs" --agent_reregister_timeout="10mins" --allocation_interval="1secs" --allocator="HierarchicalDRF" --authenticate_agents="true" --authenticate_frameworks="true" --authenticate_http_frameworks="true" --authenticate_http_readonly="true" --authenticate_http_readwrite="true" --authenticators="crammd5" --authorizers="local" --credentials="C:\Users\mesos\AppData\Local\Temp\weK0JM\credentials" --filter_gpu_resources="true" --framework_sorter="drf" --help="false" --hostname_lookup="true" --http_authenticators="basic" --http_framework_authenticators="basic" --initialize_driver_logging="true" --log_auto_initialize="true" --logbufsecs="0" --logging_level="INFO" --max_agent_ping_timeouts="5" --max_completed_frameworks="50" --max_completed_tasks_per_framework="1000" --max_unreachable_tasks_per_framework="1000" --memory_profiling="false" --port="5050" --quiet="false" --recovery_agent_removal_limit="1
 00%" --registry="in_memory" --registry_fetch_timeout="1mins" --registry_gc_interval="15mins" --registry_max_agent_age="2weeks" --registry_max_agent_count="102400" --registry_store_timeout="100secs" --registry_strict="false" --require_agent_domain="false" --root_submissions="true" --user_sorter="drf" --version="false" --webui_dir="/webui" --work_dir="C:\Users\mesos\AppData\Local\Temp\weK0JM\master" --zk_session_timeout="10secs"
I0424 05:04:38.731704 15128 master.cpp:515] Master only allowing authenticated frameworks to register
I0424 05:04:38.731704 15128 master.cpp:521] Master only allowing authenticated agents to register
I0424 05:04:38.731704 15128 master.cpp:527] Master only allowing authenticated HTTP frameworks to register
I0424 05:04:38.731704 15128 credentials.hpp:37] Loading credentials for authentication from 'C:\Users\mesos\AppData\Local\Temp\weK0JM\credentials'
I0424 05:04:38.733781 15128 master.cpp:571] Using default 'crammd5' authenticator
I0424 05:04:38.734776 15128 http.cpp:959] Creating default 'basic' HTTP authenticator for realm 'mesos-master-readonly'
I0424 05:04:38.734776 15128 http.cpp:959] Creating default 'basic' HTTP authenticator for realm 'mesos-master-readwrite'
I0424 05:04:38.735776 15128 http.cpp:959] Creating default 'basic' HTTP authenticator for realm 'mesos-master-scheduler'
I0424 05:04:38.735776 15128 master.cpp:652```

- Mesos Reviewbot Windows


On April 8, 2018, 2:54 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66293/
> -----------------------------------------------------------
> 
> (Updated April 8, 2018, 2:54 a.m.)
> 
> 
> Review request for mesos, Jason Lai and James Peach.
> 
> 
> Bugs: MESOS-8725
>     https://issues.apache.org/jira/browse/MESOS-8725
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Tested default executor support of `max_completion_time`.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp bf849c4b636e81ec267112bff9621579998941f5 
> 
> 
> Diff: https://reviews.apache.org/r/66293/diff/5/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66293/#review201085
-----------------------------------------------------------



Patch looks great!

Reviews applied: [66481, 66258, 66591, 66259, 66260, 66283, 66284, 66291, 66293]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 8, 2018, 12:54 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66293/
> -----------------------------------------------------------
> 
> (Updated April 8, 2018, 12:54 a.m.)
> 
> 
> Review request for mesos, Jason Lai and James Peach.
> 
> 
> Bugs: MESOS-8725
>     https://issues.apache.org/jira/browse/MESOS-8725
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Tested default executor support of `max_completion_time`.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp 293dd20d882447401572835bd31e197faf76861b 
> 
> 
> Diff: https://reviews.apache.org/r/66293/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66293/#review202212
-----------------------------------------------------------



Patch looks great!

Reviews applied: [66258, 66591, 66259, 66260, 66283, 66284, 66291, 66293]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 1, 2018, 4:43 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66293/
> -----------------------------------------------------------
> 
> (Updated May 1, 2018, 4:43 p.m.)
> 
> 
> Review request for mesos, Jason Lai and James Peach.
> 
> 
> Bugs: MESOS-8725
>     https://issues.apache.org/jira/browse/MESOS-8725
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Tested default executor support of `max_completion_time`.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp bf849c4b636e81ec267112bff9621579998941f5 
> 
> 
> Diff: https://reviews.apache.org/r/66293/diff/6/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66293/#review202203
-----------------------------------------------------------



PASS: Mesos patch 66293 was successfully built and tested.

Reviews applied: `['66258', '66591', '66259', '66260', '66283', '66284', '66291', '66293']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66293

- Mesos Reviewbot Windows


On May 1, 2018, 9:43 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66293/
> -----------------------------------------------------------
> 
> (Updated May 1, 2018, 9:43 a.m.)
> 
> 
> Review request for mesos, Jason Lai and James Peach.
> 
> 
> Bugs: MESOS-8725
>     https://issues.apache.org/jira/browse/MESOS-8725
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Tested default executor support of `max_completion_time`.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp bf849c4b636e81ec267112bff9621579998941f5 
> 
> 
> Diff: https://reviews.apache.org/r/66293/diff/6/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66293/
-----------------------------------------------------------

(Updated May 1, 2018, 9:43 a.m.)


Review request for mesos, Jason Lai and James Peach.


Changes
-------

Review comments.


Bugs: MESOS-8725
    https://issues.apache.org/jira/browse/MESOS-8725


Repository: mesos


Description
-------

Tested default executor support of `max_completion_time`.


Diffs (updated)
-----

  src/tests/default_executor_tests.cpp bf849c4b636e81ec267112bff9621579998941f5 


Diff: https://reviews.apache.org/r/66293/diff/6/

Changes: https://reviews.apache.org/r/66293/diff/5-6/


Testing
-------


Thanks,

Zhitao Li

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66293/#review200714
-----------------------------------------------------------



PASS: Mesos patch 66293 was successfully built and tested.

Reviews applied: `['66481', '66258', '66259', '66260', '66283', '66284', '66291', '66293']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66293

- Mesos Reviewbot Windows


On April 8, 2018, 12:54 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66293/
> -----------------------------------------------------------
> 
> (Updated April 8, 2018, 12:54 a.m.)
> 
> 
> Review request for mesos, Jason Lai and James Peach.
> 
> 
> Bugs: MESOS-8725
>     https://issues.apache.org/jira/browse/MESOS-8725
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Tested default executor support of `max_completion_time`.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp 293dd20d882447401572835bd31e197faf76861b 
> 
> 
> Diff: https://reviews.apache.org/r/66293/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66293/#review201819
-----------------------------------------------------------



Patch looks great!

Reviews applied: [66481, 66258, 66591, 66259, 66260, 66283, 66284, 66291, 66293]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 8, 2018, 12:54 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66293/
> -----------------------------------------------------------
> 
> (Updated April 8, 2018, 12:54 a.m.)
> 
> 
> Review request for mesos, Jason Lai and James Peach.
> 
> 
> Bugs: MESOS-8725
>     https://issues.apache.org/jira/browse/MESOS-8725
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Tested default executor support of `max_completion_time`.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp bf849c4b636e81ec267112bff9621579998941f5 
> 
> 
> Diff: https://reviews.apache.org/r/66293/diff/5/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66293/#review202160
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/default_executor_tests.cpp
Lines 1764 (patched)
<https://reviews.apache.org/r/66293/#comment283809>

    I think it would be a little safer to make this task just run "exit 0" since it might take a long time to start up on a slow CI host.


- James Peach


On April 8, 2018, 12:54 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66293/
> -----------------------------------------------------------
> 
> (Updated April 8, 2018, 12:54 a.m.)
> 
> 
> Review request for mesos, Jason Lai and James Peach.
> 
> 
> Bugs: MESOS-8725
>     https://issues.apache.org/jira/browse/MESOS-8725
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Tested default executor support of `max_completion_time`.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp bf849c4b636e81ec267112bff9621579998941f5 
> 
> 
> Diff: https://reviews.apache.org/r/66293/diff/5/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66293/
-----------------------------------------------------------

(Updated April 7, 2018, 5:54 p.m.)


Review request for mesos, Jason Lai and James Peach.


Changes
-------

Rename and updated test.


Summary (updated)
-----------------

Tested default executor support of `max_completion_time`.


Bugs: MESOS-8725
    https://issues.apache.org/jira/browse/MESOS-8725


Repository: mesos


Description (updated)
-------

Tested default executor support of `max_completion_time`.


Diffs (updated)
-----

  src/tests/default_executor_tests.cpp 293dd20d882447401572835bd31e197faf76861b 


Diff: https://reviews.apache.org/r/66293/diff/2/

Changes: https://reviews.apache.org/r/66293/diff/1-2/


Testing
-------


Thanks,

Zhitao Li

Re: Review Request 66293: Added test for default executor support of max_duration.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66293/#review200002
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66258', '66259', '66260', '66283', '66284', '66291', '66292', '66293']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66293

Relevant logs:

- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66293/logs/mesos-tests-stdout.log):

```
[       OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (116 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1067 ms total)

[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN      ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[       OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (36 ms)
[ RUN      ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[       OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (37 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (74 ms total)

[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN      ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[       OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (798 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (826 ms total)

[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN      ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[       OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (840 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (864 ms total)

[----------] Global test environment tear-down
[==========] 953 tests from 94 test cases ran. (461003 ms total)
[  PASSED  ] 952 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] CommandExecutorCheckTest.CommandCheckTimeout

 1 FAILED TEST
  YOU HAVE 214 DISABLED TESTS

```

- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66293/logs/mesos-tests-stderr.log):

```
I0326 22:43:41.258496 12972 master.cpp:10446] UpdI0326 22:43:41.048491  6044 exec.cpp:162] Version: 1.6.0
I0326 22:43:41.078502  5904 exec.cpp:236] Executor registered on agent 665db9cb-b15b-4b30-8812-ce8b60527c57-S0
I0326 22:43:41.082491  8160 executor.cpp:176] Received SUBSCRIBED event
I0326 22:43:41.087472  8160 executor.cpp:180] Subscribed executor on winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0326 22:43:41.088474  8160 executor.cpp:176] Received LAUNCH event
I0326 22:43:41.093468  8160 executor.cpp:656] Starting task 8279bd2c-1099-4eed-9f26-48411be4b0e4
I0326 22:43:41.194470  8160 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0326 22:43:41.230479  8160 executor.cpp:669] Forked command at 7540
I0326 22:43:41.260778 15184 exec.cpp:445] Executor asked to shutdown
I0326 22:43:41.260778 11352 executor.cpp:176] Received SHUTDOWN event
I0326 22:43:41.260778 11352 executor.cpp:773] Shutting down
I0326 22:43:41.261471 11352 executor.cpp:884] Sending SIGTERM to process tree at pid 7ating the state of task 8279bd2c-1099-4eed-9f26-48411be4b0e4 of framework 665db9cb-b15b-4b30-8812-ce8b60527c57-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0326 22:43:41.258496 13568 slave.cpp:3873] Shutting down framework 665db9cb-b15b-4b30-8812-ce8b60527c57-0000
I0326 22:43:41.258496 13568 slave.cpp:6566] Shutting down executor '8279bd2c-1099-4eed-9f26-48411be4b0e4' of framework 665db9cb-b15b-4b30-8812-ce8b60527c57-0000 at executor(1)@10.3.1.8:65127
I0326 22:43:41.259497 13568 slave.cpp:919] Agent terminating
W0326 22:43:41.259497 13568 slave.cpp:3869] Ignoring shutdown framework 665db9cb-b15b-4b30-8812-ce8b60527c57-0000 because it is terminating
I0326 22:43:41.261471 12972 master.cpp:10545] Removing task 8279bd2c-1099-4eed-9f26-48411be4b0e4 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 665db9cb-b15b-4b30-8812-ce8b60527c57-0000 on agent 665db9cb-b15b-4b30-8812-ce8b60527c57-S0 at slave(422)@10.3.1.8:65106 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0326 22:43:41.263465 13832 containerizer.cpp:2338] Destroying container 3695b9f1-4f43-4d9b-af83-7ab6276daa57 in RUNNING state
I0326 22:43:41.263465 13832 containerizer.cpp:2952] Transitioning the state of container 3695b9f1-4f43-4d9b-af83-7ab6276daa57 from RUNNING to DESTROYING
I0326 22:43:41.264467 13832 launcher.cpp:156] Asked to destroy container 3695b9f1-4f43-4d9b-af83-7ab6276daa57
I0326 22:43:41.264467 12972 master.cpp:1295] Agent 665db9cb-b15b-4b30-8812-ce8b60527c57-S0 at slave(422)@10.3.1.8:65106 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0326 22:43:41.264467 12972 master.cpp:3283] Disconnecting agent 665db9cb-b15b-4b30-8812-ce8b60527c57-S0 at slave(422)@10.3.1.8:65106 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0326 22:43:41.265471  8400 hierarchical.cpp:344] Removed framework 665db9cb-b15b-4b30-8812-ce8b60527c57-0000
I0326 22:43:41.265471 12972 master.cpp:3302] Deactivating agent 665db9cb-b15b-4b30-8812-ce8b60527c57-S0 at slave(422)@10.3.1.8:65106 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0326 22:43:41.266477 13568 hierarchical.cpp:766] Agent 665db9cb-b15b-4b30-8812-ce8b60527c57-S0 deactivated
I0326 22:43:41.330899 11920 containerizer.cpp:2791] Container 3695b9f1-4f43-4d9b-af83-7ab6276daa57 has exited
I0326 22:43:41.361912 10764 master.cpp:1137] Master terminating
I0326 22:43:41.364907  1664 hierarchical.cpp:609] Removed agent 665db9cb-b15b-4b30-8812-ce8b60527c57-S0
I0326 22:43:41.814915 12420 process.cpp:929] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On March 26, 2018, 9:49 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66293/
> -----------------------------------------------------------
> 
> (Updated March 26, 2018, 9:49 p.m.)
> 
> 
> Review request for mesos, Jason Lai and James Peach.
> 
> 
> Bugs: MESOS-8725
>     https://issues.apache.org/jira/browse/MESOS-8725
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test for default executor support of max_duration.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp 293dd20d882447401572835bd31e197faf76861b 
> 
> 
> Diff: https://reviews.apache.org/r/66293/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66293: Added test for default executor support of max_duration.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66293/#review200004
-----------------------------------------------------------



Patch looks great!

Reviews applied: [66258, 66259, 66260, 66283, 66284, 66291, 66292, 66293]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On March 26, 2018, 9:49 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66293/
> -----------------------------------------------------------
> 
> (Updated March 26, 2018, 9:49 p.m.)
> 
> 
> Review request for mesos, Jason Lai and James Peach.
> 
> 
> Bugs: MESOS-8725
>     https://issues.apache.org/jira/browse/MESOS-8725
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test for default executor support of max_duration.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp 293dd20d882447401572835bd31e197faf76861b 
> 
> 
> Diff: https://reviews.apache.org/r/66293/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>