You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Brett Porter <br...@apache.org> on 2008/06/10 00:37:14 UTC

Re: svn commit: r664037 - in /maven/components/branches/john-2.0.x-dynamicBuild: ./ maven-project/src/main/java/org/apache/maven/project/ maven-project/src/main/java/org/apache/maven/project/interpolation/

Interesting - I've thought a bit about this myself, though not for  
2.0.x. What are you working towards?

- Brett

On 07/06/2008, at 3:08 AM, jdcasey@apache.org wrote:

> Author: jdcasey
> Date: Fri Jun  6 10:08:36 2008
> New Revision: 664037
>
> URL: http://svn.apache.org/viewvc?rev=664037&view=rev
> Log:
> Creating feature branch for dynamic build section in the POM.
>

--
Brett Porter
brett@apache.org
http://blogs.exist.com/bporter/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


RE: svn commit: r664037 - in /maven/components/branches/john-2.0.x-dynamicBuild: ./ maven-project/src/main/java/org/apache/maven/project/ maven-project/src/main/java/org/apache/maven/project/interpolation/

Posted by "Brian E. Fox" <br...@reply.infinity.nu>.
John can provide some more details, but he's trying a few things on this
branch and then will take it to the list.


-----Original Message-----
From: Brett Porter [mailto:brett@apache.org] 
Sent: Monday, June 09, 2008 7:42 PM
To: Maven Developers List
Subject: Re: svn commit: r664037 - in
/maven/components/branches/john-2.0.x-dynamicBuild: ./
maven-project/src/main/java/org/apache/maven/project/
maven-project/src/main/java/org/apache/maven/project/interpolation/

Yeah, that was particularly hazardous when I fixed one thing in 2.0.9.

How are you going about it?

- Brett

On 10/06/2008, at 9:31 AM, Brian E. Fox wrote:

> We're experimenting with some ways to fix several of the issues that
> keep getting broken/fixed/broken etc (think
> project.build.outputDirectory in 2.0.8/2.0.9)
>
> -----Original Message-----
> From: Brett Porter [mailto:brett@apache.org]
> Sent: Monday, June 09, 2008 6:37 PM
> To: dev@maven.apache.org
> Subject: Re: svn commit: r664037 - in
> /maven/components/branches/john-2.0.x-dynamicBuild: ./
> maven-project/src/main/java/org/apache/maven/project/
> maven-project/src/main/java/org/apache/maven/project/interpolation/
>
> Interesting - I've thought a bit about this myself, though not for
> 2.0.x. What are you working towards?
>
> - Brett
>
> On 07/06/2008, at 3:08 AM, jdcasey@apache.org wrote:
>
>> Author: jdcasey
>> Date: Fri Jun  6 10:08:36 2008
>> New Revision: 664037
>>
>> URL: http://svn.apache.org/viewvc?rev=664037&view=rev
>> Log:
>> Creating feature branch for dynamic build section in the POM.
>>
>
> --
> Brett Porter
> brett@apache.org
> http://blogs.exist.com/bporter/
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>

--
Brett Porter
brett@apache.org
http://blogs.exist.com/bporter/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r664037 - in /maven/components/branches/john-2.0.x-dynamicBuild: ./ maven-project/src/main/java/org/apache/maven/project/ maven-project/src/main/java/org/apache/maven/project/interpolation/

Posted by Brett Porter <br...@apache.org>.
Yeah, that was particularly hazardous when I fixed one thing in 2.0.9.

How are you going about it?

- Brett

On 10/06/2008, at 9:31 AM, Brian E. Fox wrote:

> We're experimenting with some ways to fix several of the issues that
> keep getting broken/fixed/broken etc (think
> project.build.outputDirectory in 2.0.8/2.0.9)
>
> -----Original Message-----
> From: Brett Porter [mailto:brett@apache.org]
> Sent: Monday, June 09, 2008 6:37 PM
> To: dev@maven.apache.org
> Subject: Re: svn commit: r664037 - in
> /maven/components/branches/john-2.0.x-dynamicBuild: ./
> maven-project/src/main/java/org/apache/maven/project/
> maven-project/src/main/java/org/apache/maven/project/interpolation/
>
> Interesting - I've thought a bit about this myself, though not for
> 2.0.x. What are you working towards?
>
> - Brett
>
> On 07/06/2008, at 3:08 AM, jdcasey@apache.org wrote:
>
>> Author: jdcasey
>> Date: Fri Jun  6 10:08:36 2008
>> New Revision: 664037
>>
>> URL: http://svn.apache.org/viewvc?rev=664037&view=rev
>> Log:
>> Creating feature branch for dynamic build section in the POM.
>>
>
> --
> Brett Porter
> brett@apache.org
> http://blogs.exist.com/bporter/
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>

--
Brett Porter
brett@apache.org
http://blogs.exist.com/bporter/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


RE: svn commit: r664037 - in /maven/components/branches/john-2.0.x-dynamicBuild: ./ maven-project/src/main/java/org/apache/maven/project/ maven-project/src/main/java/org/apache/maven/project/interpolation/

Posted by "Brian E. Fox" <br...@reply.infinity.nu>.
We're experimenting with some ways to fix several of the issues that
keep getting broken/fixed/broken etc (think
project.build.outputDirectory in 2.0.8/2.0.9)

-----Original Message-----
From: Brett Porter [mailto:brett@apache.org] 
Sent: Monday, June 09, 2008 6:37 PM
To: dev@maven.apache.org
Subject: Re: svn commit: r664037 - in
/maven/components/branches/john-2.0.x-dynamicBuild: ./
maven-project/src/main/java/org/apache/maven/project/
maven-project/src/main/java/org/apache/maven/project/interpolation/

Interesting - I've thought a bit about this myself, though not for  
2.0.x. What are you working towards?

- Brett

On 07/06/2008, at 3:08 AM, jdcasey@apache.org wrote:

> Author: jdcasey
> Date: Fri Jun  6 10:08:36 2008
> New Revision: 664037
>
> URL: http://svn.apache.org/viewvc?rev=664037&view=rev
> Log:
> Creating feature branch for dynamic build section in the POM.
>

--
Brett Porter
brett@apache.org
http://blogs.exist.com/bporter/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r664037 - in /maven/components/branches/john-2.0.x-dynamicBuild: ./ maven-project/src/main/java/org/apache/maven/project/ maven-project/src/main/java/org/apache/maven/project/interpolation/

Posted by Brett Porter <br...@apache.org>.
On 11/06/2008, at 1:05 AM, John Casey wrote:

> Since the project can change in legitimate ways during the course of  
> a build - especially for forked executions, such as changing the  
> build directories - that means that expressions used to configure  
> subsequent plugin executions MUST be synchronized to the internal  
> state of the project itself. This is problematic when we interpolate  
> all of these expressions up front, since we lose the dynamism. So,  
> I'm experimenting with interpolating the POM without the build  
> section up front, then interpolating the build section for each  
> plugin execution, and back-propagating the changes to that section  
> into the original, uninterpolated Build instance for future plugin  
> executions.

How important is the propagation of changes to this? This seems the  
more complex part of it.

WRT delayed evaluation of expressions - that makes sense to me. In  
fact, I think that is already the case for plugin configuration  
elements - they are just evaluated at execution time, right?

>
>
> It's a little heavy, but I haven't been able to imagine any other  
> way out of this without changing the APIs used to manipulate project  
> data. In the longer term, I think that's the right way forward, but  
> or 2.0.x I don't want to force a massive re-release party for the  
> plugins.

I think I'm agreed WRT propagating model changes from plugins in the  
future.

>
>
> At any rate, I'm planning to write it all up and submit it to the  
> dev list once I have working code that people can look at. I'm  
> currently 4 ITs short of that.

Cool. Let me know if you need any specific feedback.

Cheers,
Brett

--
Brett Porter
brett@apache.org
http://blogs.exist.com/bporter/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r664037 - in /maven/components/branches/john-2.0.x-dynamicBuild: ./ maven-project/src/main/java/org/apache/maven/project/ maven-project/src/main/java/org/apache/maven/project/interpolation/

Posted by John Casey <jd...@commonjava.org>.
I just wanted a place to park an experiment until I have something I can 
show the dev list, but the idea is that we need to retain dynamism at 
least in the build section of the POM. I don't think it's appropriate 
for the whole POM, as this could really damage determinism...for 
instance, plugins should not be able to add dependencies to projects, 
since this hurts our ability to manage the project-dependency relationships.

Since the project can change in legitimate ways during the course of a 
build - especially for forked executions, such as changing the build 
directories - that means that expressions used to configure subsequent 
plugin executions MUST be synchronized to the internal state of the 
project itself. This is problematic when we interpolate all of these 
expressions up front, since we lose the dynamism. So, I'm experimenting 
with interpolating the POM without the build section up front, then 
interpolating the build section for each plugin execution, and 
back-propagating the changes to that section into the original, 
uninterpolated Build instance for future plugin executions.

It's a little heavy, but I haven't been able to imagine any other way 
out of this without changing the APIs used to manipulate project data. 
In the longer term, I think that's the right way forward, but or 2.0.x I 
don't want to force a massive re-release party for the plugins.

At any rate, I'm planning to write it all up and submit it to the dev 
list once I have working code that people can look at. I'm currently 4 
ITs short of that.

-john

Brett Porter wrote:
> Interesting - I've thought a bit about this myself, though not for 
> 2.0.x. What are you working towards?
>
> - Brett
>
> On 07/06/2008, at 3:08 AM, jdcasey@apache.org wrote:
>
>> Author: jdcasey
>> Date: Fri Jun  6 10:08:36 2008
>> New Revision: 664037
>>
>> URL: http://svn.apache.org/viewvc?rev=664037&view=rev
>> Log:
>> Creating feature branch for dynamic build section in the POM.
>>
>
> -- 
> Brett Porter
> brett@apache.org
> http://blogs.exist.com/bporter/
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>

-- 
John Casey
Developer, PMC Member - Apache Maven (http://maven.apache.org)
Blog: http://www.ejlife.net/blogs/buildchimp/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org