You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/03/06 15:03:03 UTC
[GitHub] [superset] stephenLYZ opened a new pull request #19038: feat: improve color consistency (save all labels)
stephenLYZ opened a new pull request #19038:
URL: https://github.com/apache/superset/pull/19038
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
The difference between this [PR](https://github.com/apache/superset/pull/17792) and this one is that all label colors of the dashboard are saved to handle the native filter scenario.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### before
https://user-images.githubusercontent.com/11830681/156928847-737aceea-c80e-4f92-81bd-b3d53fbb7324.mov
### after
https://user-images.githubusercontent.com/11830681/156928791-ed4ccef5-3fbc-4c42-9f68-5b61a1ec4f42.mov
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1059982016
# [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19038](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cdb4940) into [master](https://codecov.io/gh/apache/superset/commit/70081a698fd423ab953d0943fc15ce88c24311ae?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70081a6) will **increase** coverage by `0.02%`.
> The diff coverage is `34.81%`.
[](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19038 +/- ##
==========================================
+ Coverage 66.49% 66.52% +0.02%
==========================================
Files 1645 1645
Lines 63515 63527 +12
Branches 6464 6464
==========================================
+ Hits 42237 42263 +26
+ Misses 19606 19592 -14
Partials 1672 1672
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.63% <50.00%> (+0.03%)` | :arrow_up: |
| mysql | `81.83% <100.00%> (?)` | |
| postgres | `81.88% <100.00%> (+0.01%)` | :arrow_up: |
| presto | `52.47% <50.00%> (+0.03%)` | :arrow_up: |
| python | `82.31% <100.00%> (+0.05%)` | :arrow_up: |
| sqlite | `81.63% <100.00%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...end/plugins/legacy-plugin-chart-chord/src/Chord.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9DaG9yZC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-chord/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../legacy-plugin-chart-country-map/src/CountryMap.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9Db3VudHJ5TWFwLmpz) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-country-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-histogram/src/Histogram.jsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvSGlzdG9ncmFtLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-histogram/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-partition/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ntend/plugins/legacy-plugin-chart-rose/src/Rose.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL1Jvc2UuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-rose/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL3RyYW5zZm9ybVByb3BzLmpz) | `0.00% <0.00%> (ø)` | |
| ... and [103 more](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [70081a6...cdb4940](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
stephenLYZ edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1072914409
@geido You can see Michael's comment, it only exists in the test environment. But in my local it cannot be reproduce.
> @stephenLYZ I think I know what's the problem here. This https://github.com/apache/superset/pull/18976 changed the default cache type to NullCache when not in debug mode. I think this is affecting the test environments. @villebro do you know how can we change this config for test environments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1059982016
# [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19038](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a440419) into [master](https://codecov.io/gh/apache/superset/commit/7524e1e3c86f3de2b3b0343c3ec5efc0b345937a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7524e1e) will **decrease** coverage by `0.00%`.
> The diff coverage is `34.81%`.
[](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19038 +/- ##
==========================================
- Coverage 66.52% 66.51% -0.01%
==========================================
Files 1646 1646
Lines 63540 63542 +2
Branches 6466 6466
==========================================
- Hits 42268 42266 -2
- Misses 19596 19600 +4
Partials 1676 1676
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.63% <50.00%> (-0.01%)` | :arrow_down: |
| mysql | `81.83% <100.00%> (+<0.01%)` | :arrow_up: |
| postgres | `81.87% <100.00%> (-0.02%)` | :arrow_down: |
| presto | `52.47% <50.00%> (-0.01%)` | :arrow_down: |
| python | `82.30% <100.00%> (-0.02%)` | :arrow_down: |
| sqlite | `81.63% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...end/plugins/legacy-plugin-chart-chord/src/Chord.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9DaG9yZC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-chord/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../legacy-plugin-chart-country-map/src/CountryMap.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9Db3VudHJ5TWFwLmpz) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-country-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-histogram/src/Histogram.jsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvSGlzdG9ncmFtLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-histogram/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-partition/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ntend/plugins/legacy-plugin-chart-rose/src/Rose.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL1Jvc2UuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-rose/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL3RyYW5zZm9ybVByb3BzLmpz) | `0.00% <0.00%> (ø)` | |
| ... and [100 more](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7524e1e...a440419](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1059982016
# [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19038](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cdb4940) into [master](https://codecov.io/gh/apache/superset/commit/70081a698fd423ab953d0943fc15ce88c24311ae?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70081a6) will **decrease** coverage by `0.13%`.
> The diff coverage is `34.81%`.
[](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19038 +/- ##
==========================================
- Coverage 66.49% 66.36% -0.14%
==========================================
Files 1645 1645
Lines 63515 63527 +12
Branches 6464 6464
==========================================
- Hits 42237 42162 -75
- Misses 19606 19693 +87
Partials 1672 1672
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.63% <50.00%> (+0.03%)` | :arrow_up: |
| postgres | `?` | |
| presto | `52.47% <50.00%> (+0.03%)` | :arrow_up: |
| python | `81.99% <100.00%> (-0.28%)` | :arrow_down: |
| sqlite | `81.63% <100.00%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...end/plugins/legacy-plugin-chart-chord/src/Chord.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9DaG9yZC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-chord/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../legacy-plugin-chart-country-map/src/CountryMap.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9Db3VudHJ5TWFwLmpz) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-country-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-histogram/src/Histogram.jsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvSGlzdG9ncmFtLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-histogram/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-partition/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ntend/plugins/legacy-plugin-chart-rose/src/Rose.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL1Jvc2UuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-rose/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL3RyYW5zZm9ybVByb3BzLmpz) | `0.00% <0.00%> (ø)` | |
| ... and [116 more](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [70081a6...cdb4940](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1072041435
@geido do you want to give this a final code pass? Sounds like we're about to have a beast of a problem behind us!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1059982016
# [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19038](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ee0f8fc) into [master](https://codecov.io/gh/apache/superset/commit/70081a698fd423ab953d0943fc15ce88c24311ae?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70081a6) will **decrease** coverage by `0.00%`.
> The diff coverage is `34.81%`.
> :exclamation: Current head ee0f8fc differs from pull request most recent head 3312ce7. Consider uploading reports for the commit 3312ce7 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19038 +/- ##
==========================================
- Coverage 66.49% 66.49% -0.01%
==========================================
Files 1645 1645
Lines 63515 63517 +2
Branches 6464 6464
==========================================
- Hits 42237 42235 -2
- Misses 19606 19610 +4
Partials 1672 1672
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.59% <50.00%> (-0.01%)` | :arrow_down: |
| postgres | `81.86% <100.00%> (-0.02%)` | :arrow_down: |
| presto | `52.44% <50.00%> (-0.01%)` | :arrow_down: |
| python | `82.25% <100.00%> (-0.02%)` | :arrow_down: |
| sqlite | `81.62% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...end/plugins/legacy-plugin-chart-chord/src/Chord.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9DaG9yZC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-chord/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../legacy-plugin-chart-country-map/src/CountryMap.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9Db3VudHJ5TWFwLmpz) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-country-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-histogram/src/Histogram.jsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvSGlzdG9ncmFtLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-histogram/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-partition/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ntend/plugins/legacy-plugin-chart-rose/src/Rose.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL1Jvc2UuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-rose/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL3RyYW5zZm9ybVByb3BzLmpz) | `0.00% <0.00%> (ø)` | |
| ... and [100 more](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [70081a6...3312ce7](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ commented on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1064315260
@jinghua-qa @geido This scenario is a bit tricky. Fixed here. Thanks for testing!!
https://user-images.githubusercontent.com/11830681/157720596-bd4f9b8e-e93d-4297-905b-9dd1c25d4049.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1063962638
Yes @stephenLYZ just reproduced what @jinghua-qa reported above.
##### Before applying filters
<img width="963" alt="Screen Shot 2022-03-10 at 13 33 25" src="https://user-images.githubusercontent.com/60598000/157653953-11aa4cf0-0466-49c3-a729-bf1cf7838f63.png">
##### After applying filters
<img width="1027" alt="Screen Shot 2022-03-10 at 13 33 58" src="https://user-images.githubusercontent.com/60598000/157654002-5f17274c-ccc9-4f0f-b6ac-6d01f24ab709.png">
##### Changing color scheme and going back to the previous one
<img width="966" alt="Screen Shot 2022-03-10 at 13 35 58" src="https://user-images.githubusercontent.com/60598000/157654070-68b2571c-d065-488a-8233-0c78ecb7afe8.png">
As you see now both series have the same color even if originally they didn't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1059982016
# [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19038](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5ce4707) into [master](https://codecov.io/gh/apache/superset/commit/bc6aad0a88bbbbfd6c592f8813d1b72471788897?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bc6aad0) will **increase** coverage by `0.00%`.
> The diff coverage is `52.00%`.
> :exclamation: Current head 5ce4707 differs from pull request most recent head 4ac8e61. Consider uploading reports for the commit 4ac8e61 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19038 +/- ##
=======================================
Coverage 66.51% 66.51%
=======================================
Files 1644 1645 +1
Lines 63491 63583 +92
Branches 6458 6468 +10
=======================================
+ Hits 42231 42294 +63
- Misses 19590 19618 +28
- Partials 1670 1671 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.30% <51.35%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...et-ui-chart-controls/src/shared-controls/index.tsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3NoYXJlZC1jb250cm9scy9pbmRleC50c3g=) | `37.25% <0.00%> (-0.37%)` | :arrow_down: |
| [...ntend/packages/superset-ui-core/src/color/index.ts](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29sb3IvaW5kZXgudHM=) | `100.00% <ø> (ø)` | |
| [...end/plugins/legacy-plugin-chart-chord/src/Chord.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9DaG9yZC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-chord/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../legacy-plugin-chart-country-map/src/CountryMap.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9Db3VudHJ5TWFwLmpz) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-country-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-histogram/src/Histogram.jsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvSGlzdG9ncmFtLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-histogram/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <ø> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-partition/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <ø> (ø)` | |
| ... and [52 more](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bc6aad0...4ac8e61](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1068976719
> I tested this PR locally, found another issue that, when applied native filter in different series of the same color, after filtered the it will still show same color of different series, is this acceptable?
@jinghua-qa I think this is the expected behavior and objective of this PR. If you check before/after videos you'll see the same example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1072637068
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1063215387
@jinghua-qa in your case it looks like they just preserved their original colors. I tested with filtring labels using different colors and it works normally. Let me know if that requires additional discussion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1059982016
# [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19038](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (77c54b5) into [master](https://codecov.io/gh/apache/superset/commit/7524e1e3c86f3de2b3b0343c3ec5efc0b345937a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7524e1e) will **increase** coverage by `0.00%`.
> The diff coverage is `51.35%`.
> :exclamation: Current head 77c54b5 differs from pull request most recent head a440419. Consider uploading reports for the commit a440419 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19038 +/- ##
=======================================
Coverage 66.52% 66.52%
=======================================
Files 1646 1647 +1
Lines 63540 63630 +90
Branches 6466 6476 +10
=======================================
+ Hits 42268 42330 +62
- Misses 19596 19623 +27
- Partials 1676 1677 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.32% <51.35%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...et-ui-chart-controls/src/shared-controls/index.tsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3NoYXJlZC1jb250cm9scy9pbmRleC50c3g=) | `37.25% <0.00%> (-0.37%)` | :arrow_down: |
| [...ntend/packages/superset-ui-core/src/color/index.ts](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29sb3IvaW5kZXgudHM=) | `100.00% <ø> (ø)` | |
| [...end/plugins/legacy-plugin-chart-chord/src/Chord.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9DaG9yZC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-chord/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../legacy-plugin-chart-country-map/src/CountryMap.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9Db3VudHJ5TWFwLmpz) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-country-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-histogram/src/Histogram.jsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvSGlzdG9ncmFtLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-histogram/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <ø> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-partition/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <ø> (ø)` | |
| ... and [53 more](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7524e1e...a440419](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1072412753
@geido Ephemeral environment spinning up at http://54.218.201.167:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1059982016
# [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19038](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cd75467) into [master](https://codecov.io/gh/apache/superset/commit/bc6aad0a88bbbbfd6c592f8813d1b72471788897?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bc6aad0) will **increase** coverage by `0.01%`.
> The diff coverage is `51.35%`.
> :exclamation: Current head cd75467 differs from pull request most recent head 4ac8e61. Consider uploading reports for the commit 4ac8e61 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19038 +/- ##
==========================================
+ Coverage 66.51% 66.52% +0.01%
==========================================
Files 1644 1642 -2
Lines 63491 63568 +77
Branches 6458 6454 -4
==========================================
+ Hits 42231 42291 +60
- Misses 19590 19612 +22
+ Partials 1670 1665 -5
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.59% <50.00%> (-0.01%)` | :arrow_down: |
| javascript | `51.33% <50.68%> (+0.08%)` | :arrow_up: |
| mysql | `81.81% <100.00%> (-0.02%)` | :arrow_down: |
| postgres | `81.86% <100.00%> (-0.02%)` | :arrow_down: |
| presto | `52.43% <50.00%> (-0.01%)` | :arrow_down: |
| python | `82.29% <100.00%> (-0.02%)` | :arrow_down: |
| sqlite | `81.55% <100.00%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...et-ui-chart-controls/src/shared-controls/index.tsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3NoYXJlZC1jb250cm9scy9pbmRleC50c3g=) | `36.00% <0.00%> (-1.63%)` | :arrow_down: |
| [...ntend/packages/superset-ui-core/src/color/index.ts](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29sb3IvaW5kZXgudHM=) | `100.00% <ø> (ø)` | |
| [...end/plugins/legacy-plugin-chart-chord/src/Chord.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9DaG9yZC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-chord/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../legacy-plugin-chart-country-map/src/CountryMap.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9Db3VudHJ5TWFwLmpz) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-country-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-histogram/src/Histogram.jsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvSGlzdG9ncmFtLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-histogram/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <ø> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-partition/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <ø> (ø)` | |
| ... and [109 more](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bc6aad0...4ac8e61](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1059982016
# [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19038](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (722968d) into [master](https://codecov.io/gh/apache/superset/commit/e1d0b83885d89c50e96c6eef872beffe0de7cf50?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e1d0b83) will **increase** coverage by `0.00%`.
> The diff coverage is `34.81%`.
```diff
@@ Coverage Diff @@
## master #19038 +/- ##
=======================================
Coverage 66.53% 66.53%
=======================================
Files 1667 1667
Lines 64360 64362 +2
Branches 6493 6493
=======================================
+ Hits 42824 42826 +2
Misses 19853 19853
Partials 1683 1683
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.64% <50.00%> (-0.01%)` | :arrow_down: |
| mysql | `81.48% <100.00%> (+<0.01%)` | :arrow_up: |
| postgres | `81.53% <100.00%> (+<0.01%)` | :arrow_up: |
| presto | `52.49% <50.00%> (-0.01%)` | :arrow_down: |
| python | `81.95% <100.00%> (+<0.01%)` | :arrow_up: |
| sqlite | `81.29% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...end/plugins/legacy-plugin-chart-chord/src/Chord.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9DaG9yZC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-chord/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../legacy-plugin-chart-country-map/src/CountryMap.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9Db3VudHJ5TWFwLmpz) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-country-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-histogram/src/Histogram.jsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvSGlzdG9ncmFtLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-histogram/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-partition/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ntend/plugins/legacy-plugin-chart-rose/src/Rose.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL1Jvc2UuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-rose/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL3RyYW5zZm9ybVByb3BzLmpz) | `0.00% <0.00%> (ø)` | |
| ... and [96 more](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e1d0b83...722968d](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ commented on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1072914409
@geido You can see Michael's comment, it only exists in the test environment.
> @stephenLYZ I think I know what's the problem here. This https://github.com/apache/superset/pull/18976 changed the default cache type to NullCache when not in debug mode. I think this is affecting the test environments. @villebro do you know how can we change this config for test environments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1072412753
@geido Ephemeral environment spinning up at http://54.218.201.167:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1073547425
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1072402342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1072695991
@stephenLYZ I am worried that something happened to the ability to bring the colors of a chart from its Dashboard scheme to Explore. As you can see the colors in Explore look different from the Dashboard.
https://user-images.githubusercontent.com/60598000/159063652-36c0b258-bc0f-4ff2-9ed8-5b06b4405a39.mp4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1072526029
Hello @stephenLYZ after testing an existing dashboard with a color scheme and no custom label colors, I found that some labels are not sharing the same colors even if they should?
https://user-images.githubusercontent.com/60598000/159033589-c75e072a-f791-4c50-80cf-edd297e241b4.mp4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa commented on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
jinghua-qa commented on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1063152113
I tried to create the same test dashboard as in the demo video to test, but i think i saw the result as before?
https://user-images.githubusercontent.com/81597121/157492164-575b62a7-db2e-4e8b-9efd-eea577ddcd15.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1059982016
# [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19038](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a440419) into [master](https://codecov.io/gh/apache/superset/commit/7524e1e3c86f3de2b3b0343c3ec5efc0b345937a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7524e1e) will **decrease** coverage by `0.15%`.
> The diff coverage is `34.81%`.
[](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19038 +/- ##
==========================================
- Coverage 66.52% 66.36% -0.16%
==========================================
Files 1646 1646
Lines 63540 63542 +2
Branches 6466 6466
==========================================
- Hits 42268 42169 -99
- Misses 19596 19697 +101
Partials 1676 1676
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.63% <50.00%> (-0.01%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `52.47% <50.00%> (-0.01%)` | :arrow_down: |
| python | `81.99% <100.00%> (-0.33%)` | :arrow_down: |
| sqlite | `81.63% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...end/plugins/legacy-plugin-chart-chord/src/Chord.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9DaG9yZC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-chord/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../legacy-plugin-chart-country-map/src/CountryMap.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9Db3VudHJ5TWFwLmpz) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-country-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-histogram/src/Histogram.jsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvSGlzdG9ncmFtLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-histogram/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-partition/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ntend/plugins/legacy-plugin-chart-rose/src/Rose.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL1Jvc2UuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-rose/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL3RyYW5zZm9ybVByb3BzLmpz) | `0.00% <0.00%> (ø)` | |
| ... and [116 more](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7524e1e...a440419](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ commented on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1066312219
@jinghua-qa It seems to be related to the recent `form_data` key update, is there any context for this? @geido @michael-s-molina
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1059982016
# [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19038](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (66fef88) into [master](https://codecov.io/gh/apache/superset/commit/70081a698fd423ab953d0943fc15ce88c24311ae?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70081a6) will **increase** coverage by `0.00%`.
> The diff coverage is `34.81%`.
> :exclamation: Current head 66fef88 differs from pull request most recent head cdb4940. Consider uploading reports for the commit cdb4940 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19038 +/- ##
=======================================
Coverage 66.49% 66.50%
=======================================
Files 1645 1645
Lines 63515 63517 +2
Branches 6464 6464
=======================================
+ Hits 42237 42239 +2
Misses 19606 19606
Partials 1672 1672
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.59% <50.00%> (-0.01%)` | :arrow_down: |
| postgres | `81.87% <100.00%> (+<0.01%)` | :arrow_up: |
| presto | `52.44% <50.00%> (-0.01%)` | :arrow_down: |
| python | `82.26% <100.00%> (+<0.01%)` | :arrow_up: |
| sqlite | `81.62% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...end/plugins/legacy-plugin-chart-chord/src/Chord.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9DaG9yZC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-chord/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../legacy-plugin-chart-country-map/src/CountryMap.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9Db3VudHJ5TWFwLmpz) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-country-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-histogram/src/Histogram.jsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvSGlzdG9ncmFtLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-histogram/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-partition/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ntend/plugins/legacy-plugin-chart-rose/src/Rose.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL1Jvc2UuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-rose/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL3RyYW5zZm9ybVByb3BzLmpz) | `0.00% <0.00%> (ø)` | |
| ... and [96 more](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [70081a6...cdb4940](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
geido edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1063215387
@jinghua-qa in your case it looks like they just preserved their original colors. I tested with filtering labels using different colors and it works normally. Let me know if that requires additional discussion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1059982016
# [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19038](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cd75467) into [master](https://codecov.io/gh/apache/superset/commit/bd63a1bd98c1faf152205b3b862119a1c59b2f05?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bd63a1b) will **decrease** coverage by `0.05%`.
> The diff coverage is `51.35%`.
[](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19038 +/- ##
==========================================
- Coverage 66.58% 66.52% -0.06%
==========================================
Files 1641 1642 +1
Lines 63533 63568 +35
Branches 6424 6454 +30
==========================================
- Hits 42303 42291 -12
- Misses 19551 19612 +61
+ Partials 1679 1665 -14
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.59% <50.00%> (-0.01%)` | :arrow_down: |
| javascript | `51.33% <50.68%> (-0.05%)` | :arrow_down: |
| mysql | `81.81% <100.00%> (-0.02%)` | :arrow_down: |
| postgres | `81.86% <100.00%> (-0.02%)` | :arrow_down: |
| presto | `52.43% <50.00%> (-0.01%)` | :arrow_down: |
| python | `82.29% <100.00%> (-0.02%)` | :arrow_down: |
| sqlite | `81.55% <100.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...et-ui-chart-controls/src/shared-controls/index.tsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3NoYXJlZC1jb250cm9scy9pbmRleC50c3g=) | `36.00% <0.00%> (ø)` | |
| [...ntend/packages/superset-ui-core/src/color/index.ts](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29sb3IvaW5kZXgudHM=) | `100.00% <ø> (ø)` | |
| [...end/plugins/legacy-plugin-chart-chord/src/Chord.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9DaG9yZC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-chord/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../legacy-plugin-chart-country-map/src/CountryMap.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9Db3VudHJ5TWFwLmpz) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-country-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-histogram/src/Histogram.jsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvSGlzdG9ncmFtLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-histogram/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <ø> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-partition/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <ø> (ø)` | |
| ... and [138 more](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bd63a1b...cd75467](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ commented on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1072585101
@geido Nice catch! Fixed here.
<img width="1154" alt="image" src="https://user-images.githubusercontent.com/11830681/159044384-dd7b274b-4b18-4080-ab75-ffb05d2f6cfc.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
stephenLYZ edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1072914409
@geido Yes, it's a known issue and it only exists in the test environment, see Michael's comment. But in local env it cannot be reproduced.
> @stephenLYZ I think I know what's the problem here. This https://github.com/apache/superset/pull/18976 changed the default cache type to NullCache when not in debug mode. I think this is affecting the test environments. @villebro do you know how can we change this config for test environments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
stephenLYZ edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1072914409
@geido You can see Michael's comment, it only exists in the test environment. But in my local env it cannot be reproduced.
> @stephenLYZ I think I know what's the problem here. This https://github.com/apache/superset/pull/18976 changed the default cache type to NullCache when not in debug mode. I think this is affecting the test environments. @villebro do you know how can we change this config for test environments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1059982016
# [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19038](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cd75467) into [master](https://codecov.io/gh/apache/superset/commit/bd63a1bd98c1faf152205b3b862119a1c59b2f05?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bd63a1b) will **decrease** coverage by `0.03%`.
> The diff coverage is `34.81%`.
[](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19038 +/- ##
==========================================
- Coverage 66.58% 66.54% -0.04%
==========================================
Files 1641 1641
Lines 63533 63503 -30
Branches 6424 6424
==========================================
- Hits 42303 42260 -43
- Misses 19551 19564 +13
Partials 1679 1679
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.59% <50.00%> (-0.01%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `81.86% <100.00%> (-0.02%)` | :arrow_down: |
| presto | `52.43% <50.00%> (-0.01%)` | :arrow_down: |
| python | `82.25% <100.00%> (-0.06%)` | :arrow_down: |
| sqlite | `81.55% <100.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...end/plugins/legacy-plugin-chart-chord/src/Chord.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9DaG9yZC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-chord/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../legacy-plugin-chart-country-map/src/CountryMap.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9Db3VudHJ5TWFwLmpz) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-country-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-histogram/src/Histogram.jsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvSGlzdG9ncmFtLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-histogram/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-partition/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ntend/plugins/legacy-plugin-chart-rose/src/Rose.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL1Jvc2UuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-rose/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL3RyYW5zZm9ybVByb3BzLmpz) | `0.00% <0.00%> (ø)` | |
| ... and [117 more](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bd63a1b...cd75467](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1061284628
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1065321091
@jinghua-qa Ephemeral environment spinning up at http://54.190.44.153:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1059982016
# [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19038](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cdb4940) into [master](https://codecov.io/gh/apache/superset/commit/70081a698fd423ab953d0943fc15ce88c24311ae?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70081a6) will **increase** coverage by `0.00%`.
> The diff coverage is `34.81%`.
[](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19038 +/- ##
=======================================
Coverage 66.49% 66.50%
=======================================
Files 1645 1645
Lines 63515 63527 +12
Branches 6464 6464
=======================================
+ Hits 42237 42250 +13
+ Misses 19606 19605 -1
Partials 1672 1672
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.63% <50.00%> (+0.03%)` | :arrow_up: |
| postgres | `81.88% <100.00%> (+0.01%)` | :arrow_up: |
| presto | `52.47% <50.00%> (+0.03%)` | :arrow_up: |
| python | `82.27% <100.00%> (+0.01%)` | :arrow_up: |
| sqlite | `81.63% <100.00%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...end/plugins/legacy-plugin-chart-chord/src/Chord.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9DaG9yZC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-chord/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../legacy-plugin-chart-country-map/src/CountryMap.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9Db3VudHJ5TWFwLmpz) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-country-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-histogram/src/Histogram.jsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvSGlzdG9ncmFtLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-histogram/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-partition/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ntend/plugins/legacy-plugin-chart-rose/src/Rose.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL1Jvc2UuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-rose/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL3RyYW5zZm9ybVByb3BzLmpz) | `0.00% <0.00%> (ø)` | |
| ... and [99 more](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [70081a6...cdb4940](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1059982016
# [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19038](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a440419) into [master](https://codecov.io/gh/apache/superset/commit/7524e1e3c86f3de2b3b0343c3ec5efc0b345937a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7524e1e) will **decrease** coverage by `0.02%`.
> The diff coverage is `34.81%`.
[](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19038 +/- ##
==========================================
- Coverage 66.52% 66.49% -0.03%
==========================================
Files 1646 1646
Lines 63540 63542 +2
Branches 6466 6466
==========================================
- Hits 42268 42254 -14
- Misses 19596 19612 +16
Partials 1676 1676
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.63% <50.00%> (-0.01%)` | :arrow_down: |
| mysql | `81.83% <100.00%> (+<0.01%)` | :arrow_up: |
| postgres | `?` | |
| presto | `52.47% <50.00%> (-0.01%)` | :arrow_down: |
| python | `82.26% <100.00%> (-0.06%)` | :arrow_down: |
| sqlite | `81.63% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...end/plugins/legacy-plugin-chart-chord/src/Chord.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9DaG9yZC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-chord/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../legacy-plugin-chart-country-map/src/CountryMap.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9Db3VudHJ5TWFwLmpz) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-country-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-histogram/src/Histogram.jsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvSGlzdG9ncmFtLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-histogram/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-partition/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ntend/plugins/legacy-plugin-chart-rose/src/Rose.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL1Jvc2UuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-rose/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL3RyYW5zZm9ybVByb3BzLmpz) | `0.00% <0.00%> (ø)` | |
| ... and [103 more](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7524e1e...a440419](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1059982016
# [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19038](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (66fef88) into [master](https://codecov.io/gh/apache/superset/commit/70081a698fd423ab953d0943fc15ce88c24311ae?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70081a6) will **decrease** coverage by `0.13%`.
> The diff coverage is `34.81%`.
[](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19038 +/- ##
==========================================
- Coverage 66.49% 66.36% -0.14%
==========================================
Files 1645 1645
Lines 63515 63517 +2
Branches 6464 6464
==========================================
- Hits 42237 42151 -86
- Misses 19606 19694 +88
Partials 1672 1672
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.59% <50.00%> (-0.01%)` | :arrow_down: |
| postgres | `?` | |
| presto | `52.44% <50.00%> (-0.01%)` | :arrow_down: |
| python | `81.98% <100.00%> (-0.29%)` | :arrow_down: |
| sqlite | `81.62% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...end/plugins/legacy-plugin-chart-chord/src/Chord.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9DaG9yZC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-chord/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../legacy-plugin-chart-country-map/src/CountryMap.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9Db3VudHJ5TWFwLmpz) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-country-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-histogram/src/Histogram.jsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvSGlzdG9ncmFtLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-histogram/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-partition/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ntend/plugins/legacy-plugin-chart-rose/src/Rose.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL1Jvc2UuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-rose/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL3RyYW5zZm9ybVByb3BzLmpz) | `0.00% <0.00%> (ø)` | |
| ... and [113 more](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [70081a6...66fef88](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1059982016
# [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19038](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (722968d) into [master](https://codecov.io/gh/apache/superset/commit/e1d0b83885d89c50e96c6eef872beffe0de7cf50?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e1d0b83) will **decrease** coverage by `0.14%`.
> The diff coverage is `34.81%`.
```diff
@@ Coverage Diff @@
## master #19038 +/- ##
==========================================
- Coverage 66.53% 66.38% -0.15%
==========================================
Files 1667 1667
Lines 64360 64362 +2
Branches 6493 6493
==========================================
- Hits 42824 42729 -95
- Misses 19853 19950 +97
Partials 1683 1683
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.64% <50.00%> (-0.01%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `52.49% <50.00%> (-0.01%)` | :arrow_down: |
| python | `81.65% <100.00%> (-0.31%)` | :arrow_down: |
| sqlite | `81.29% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...end/plugins/legacy-plugin-chart-chord/src/Chord.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9DaG9yZC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-chord/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../legacy-plugin-chart-country-map/src/CountryMap.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9Db3VudHJ5TWFwLmpz) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-country-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-histogram/src/Histogram.jsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvSGlzdG9ncmFtLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-histogram/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-partition/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ntend/plugins/legacy-plugin-chart-rose/src/Rose.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL1Jvc2UuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-rose/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL3RyYW5zZm9ybVByb3BzLmpz) | `0.00% <0.00%> (ø)` | |
| ... and [115 more](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e1d0b83...722968d](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1059982016
# [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19038](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5ce4707) into [master](https://codecov.io/gh/apache/superset/commit/70081a698fd423ab953d0943fc15ce88c24311ae?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70081a6) will **increase** coverage by `0.01%`.
> The diff coverage is `52.00%`.
> :exclamation: Current head 5ce4707 differs from pull request most recent head 3312ce7. Consider uploading reports for the commit 3312ce7 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19038 +/- ##
==========================================
+ Coverage 66.49% 66.51% +0.01%
==========================================
Files 1645 1645
Lines 63515 63583 +68
Branches 6464 6468 +4
==========================================
+ Hits 42237 42294 +57
- Misses 19606 19618 +12
+ Partials 1672 1671 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.30% <51.35%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...et-ui-chart-controls/src/shared-controls/index.tsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3NoYXJlZC1jb250cm9scy9pbmRleC50c3g=) | `37.25% <0.00%> (-0.37%)` | :arrow_down: |
| [...ntend/packages/superset-ui-core/src/color/index.ts](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29sb3IvaW5kZXgudHM=) | `100.00% <ø> (ø)` | |
| [...end/plugins/legacy-plugin-chart-chord/src/Chord.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9DaG9yZC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-chord/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../legacy-plugin-chart-country-map/src/CountryMap.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9Db3VudHJ5TWFwLmpz) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-country-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-histogram/src/Histogram.jsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvSGlzdG9ncmFtLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-histogram/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <ø> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-partition/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <ø> (ø)` | |
| ... and [65 more](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [70081a6...3312ce7](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1059982016
# [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19038](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ee0f8fc) into [master](https://codecov.io/gh/apache/superset/commit/70081a698fd423ab953d0943fc15ce88c24311ae?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70081a6) will **increase** coverage by `0.02%`.
> The diff coverage is `34.81%`.
> :exclamation: Current head ee0f8fc differs from pull request most recent head 66fef88. Consider uploading reports for the commit 66fef88 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19038 +/- ##
==========================================
+ Coverage 66.49% 66.52% +0.02%
==========================================
Files 1645 1645
Lines 63515 63517 +2
Branches 6464 6464
==========================================
+ Hits 42237 42252 +15
+ Misses 19606 19593 -13
Partials 1672 1672
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.59% <50.00%> (-0.01%)` | :arrow_down: |
| mysql | `81.82% <100.00%> (?)` | |
| postgres | `81.87% <100.00%> (+<0.01%)` | :arrow_up: |
| presto | `52.44% <50.00%> (-0.01%)` | :arrow_down: |
| python | `82.30% <100.00%> (+0.04%)` | :arrow_up: |
| sqlite | `81.62% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...end/plugins/legacy-plugin-chart-chord/src/Chord.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9DaG9yZC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-chord/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../legacy-plugin-chart-country-map/src/CountryMap.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9Db3VudHJ5TWFwLmpz) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-country-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-histogram/src/Histogram.jsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvSGlzdG9ncmFtLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-histogram/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-partition/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ntend/plugins/legacy-plugin-chart-rose/src/Rose.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL1Jvc2UuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-rose/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL3RyYW5zZm9ybVByb3BzLmpz) | `0.00% <0.00%> (ø)` | |
| ... and [100 more](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [70081a6...66fef88](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1059982016
# [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19038](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a440419) into [master](https://codecov.io/gh/apache/superset/commit/7524e1e3c86f3de2b3b0343c3ec5efc0b345937a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7524e1e) will **increase** coverage by `0.00%`.
> The diff coverage is `34.81%`.
[](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19038 +/- ##
=======================================
Coverage 66.52% 66.52%
=======================================
Files 1646 1646
Lines 63540 63542 +2
Branches 6466 6466
=======================================
+ Hits 42268 42270 +2
Misses 19596 19596
Partials 1676 1676
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.63% <50.00%> (-0.01%)` | :arrow_down: |
| mysql | `81.83% <100.00%> (+<0.01%)` | :arrow_up: |
| postgres | `81.88% <100.00%> (+<0.01%)` | :arrow_up: |
| presto | `52.47% <50.00%> (-0.01%)` | :arrow_down: |
| python | `82.31% <100.00%> (+<0.01%)` | :arrow_up: |
| sqlite | `81.63% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...end/plugins/legacy-plugin-chart-chord/src/Chord.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9DaG9yZC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-chord/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../legacy-plugin-chart-country-map/src/CountryMap.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9Db3VudHJ5TWFwLmpz) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-country-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-histogram/src/Histogram.jsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvSGlzdG9ncmFtLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-histogram/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-partition/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ntend/plugins/legacy-plugin-chart-rose/src/Rose.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL1Jvc2UuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-rose/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL3RyYW5zZm9ybVByb3BzLmpz) | `0.00% <0.00%> (ø)` | |
| ... and [96 more](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7524e1e...a440419](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1059982016
# [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19038](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a440419) into [master](https://codecov.io/gh/apache/superset/commit/7524e1e3c86f3de2b3b0343c3ec5efc0b345937a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7524e1e) will **increase** coverage by `0.00%`.
> The diff coverage is `52.00%`.
[](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19038 +/- ##
=======================================
Coverage 66.52% 66.52%
=======================================
Files 1646 1647 +1
Lines 63540 63632 +92
Branches 6466 6476 +10
=======================================
+ Hits 42268 42332 +64
- Misses 19596 19623 +27
- Partials 1676 1677 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.63% <50.00%> (-0.01%)` | :arrow_down: |
| javascript | `51.32% <51.35%> (+0.04%)` | :arrow_up: |
| mysql | `81.83% <100.00%> (+<0.01%)` | :arrow_up: |
| postgres | `81.88% <100.00%> (+<0.01%)` | :arrow_up: |
| presto | `52.47% <50.00%> (-0.01%)` | :arrow_down: |
| python | `82.31% <100.00%> (+<0.01%)` | :arrow_up: |
| sqlite | `81.63% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...et-ui-chart-controls/src/shared-controls/index.tsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3NoYXJlZC1jb250cm9scy9pbmRleC50c3g=) | `37.25% <0.00%> (-0.37%)` | :arrow_down: |
| [...ntend/packages/superset-ui-core/src/color/index.ts](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29sb3IvaW5kZXgudHM=) | `100.00% <ø> (ø)` | |
| [...end/plugins/legacy-plugin-chart-chord/src/Chord.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9DaG9yZC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-chord/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../legacy-plugin-chart-country-map/src/CountryMap.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9Db3VudHJ5TWFwLmpz) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-country-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-histogram/src/Histogram.jsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvSGlzdG9ncmFtLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-histogram/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <ø> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-partition/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <ø> (ø)` | |
| ... and [51 more](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7524e1e...a440419](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa commented on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
jinghua-qa commented on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1065317532
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1059982016
# [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19038](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cd75467) into [master](https://codecov.io/gh/apache/superset/commit/bd63a1bd98c1faf152205b3b862119a1c59b2f05?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bd63a1b) will **decrease** coverage by `0.20%`.
> The diff coverage is `34.81%`.
[](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19038 +/- ##
==========================================
- Coverage 66.58% 66.38% -0.21%
==========================================
Files 1641 1641
Lines 63533 63503 -30
Branches 6424 6424
==========================================
- Hits 42303 42155 -148
- Misses 19551 19669 +118
Partials 1679 1679
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.59% <50.00%> (-0.01%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `52.43% <50.00%> (-0.01%)` | :arrow_down: |
| python | `81.91% <100.00%> (-0.40%)` | :arrow_down: |
| sqlite | `81.55% <100.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...end/plugins/legacy-plugin-chart-chord/src/Chord.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9DaG9yZC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-chord/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../legacy-plugin-chart-country-map/src/CountryMap.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9Db3VudHJ5TWFwLmpz) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-country-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-histogram/src/Histogram.jsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvSGlzdG9ncmFtLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-histogram/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-partition/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ntend/plugins/legacy-plugin-chart-rose/src/Rose.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL1Jvc2UuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-rose/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL3RyYW5zZm9ybVByb3BzLmpz) | `0.00% <0.00%> (ø)` | |
| ... and [132 more](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bd63a1b...cd75467](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1059982016
# [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19038](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cd75467) into [master](https://codecov.io/gh/apache/superset/commit/bd63a1bd98c1faf152205b3b862119a1c59b2f05?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bd63a1b) will **decrease** coverage by `0.01%`.
> The diff coverage is `34.81%`.
[](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19038 +/- ##
==========================================
- Coverage 66.58% 66.56% -0.02%
==========================================
Files 1641 1641
Lines 63533 63503 -30
Branches 6424 6424
==========================================
- Hits 42303 42273 -30
Misses 19551 19551
Partials 1679 1679
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.59% <50.00%> (-0.01%)` | :arrow_down: |
| mysql | `81.81% <100.00%> (-0.02%)` | :arrow_down: |
| postgres | `81.86% <100.00%> (-0.02%)` | :arrow_down: |
| presto | `52.43% <50.00%> (-0.01%)` | :arrow_down: |
| python | `82.29% <100.00%> (-0.02%)` | :arrow_down: |
| sqlite | `81.55% <100.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...end/plugins/legacy-plugin-chart-chord/src/Chord.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9DaG9yZC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-chord/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../legacy-plugin-chart-country-map/src/CountryMap.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9Db3VudHJ5TWFwLmpz) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-country-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-histogram/src/Histogram.jsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvSGlzdG9ncmFtLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-histogram/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-partition/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ntend/plugins/legacy-plugin-chart-rose/src/Rose.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL1Jvc2UuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-rose/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL3RyYW5zZm9ybVByb3BzLmpz) | `0.00% <0.00%> (ø)` | |
| ... and [114 more](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bd63a1b...cd75467](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa commented on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
jinghua-qa commented on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1063690244
I found out that the same color issue will exist when the native filter is applied:
1, select 'a', 'e' and applied native filter
2, do not remove native filter, go to dashboard edit mode and change color scheme
in this scenario, a, e always have the same color, and even clear native filter, a, e still show same color
https://user-images.githubusercontent.com/81597121/157598011-b4ab1eab-4fc5-4db7-9bb0-7d605bff8198.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1059982016
# [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19038](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4ac8e61) into [master](https://codecov.io/gh/apache/superset/commit/bc6aad0a88bbbbfd6c592f8813d1b72471788897?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bc6aad0) will **decrease** coverage by `0.15%`.
> The diff coverage is `34.81%`.
[](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19038 +/- ##
==========================================
- Coverage 66.51% 66.35% -0.16%
==========================================
Files 1644 1644
Lines 63491 63493 +2
Branches 6458 6458
==========================================
- Hits 42231 42131 -100
- Misses 19590 19692 +102
Partials 1670 1670
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.59% <50.00%> (-0.01%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `52.44% <50.00%> (-0.01%)` | :arrow_down: |
| python | `81.98% <100.00%> (-0.33%)` | :arrow_down: |
| sqlite | `81.62% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...end/plugins/legacy-plugin-chart-chord/src/Chord.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9DaG9yZC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-chord/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../legacy-plugin-chart-country-map/src/CountryMap.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9Db3VudHJ5TWFwLmpz) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-country-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-histogram/src/Histogram.jsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvSGlzdG9ncmFtLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-histogram/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-partition/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ntend/plugins/legacy-plugin-chart-rose/src/Rose.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL1Jvc2UuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-rose/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL3RyYW5zZm9ybVByb3BzLmpz) | `0.00% <0.00%> (ø)` | |
| ... and [117 more](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bc6aad0...4ac8e61](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1059982016
# [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19038](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4ac8e61) into [master](https://codecov.io/gh/apache/superset/commit/bc6aad0a88bbbbfd6c592f8813d1b72471788897?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bc6aad0) will **decrease** coverage by `0.02%`.
> The diff coverage is `34.81%`.
[](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19038 +/- ##
==========================================
- Coverage 66.51% 66.49% -0.03%
==========================================
Files 1644 1644
Lines 63491 63493 +2
Branches 6458 6458
==========================================
- Hits 42231 42219 -12
- Misses 19590 19604 +14
Partials 1670 1670
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.59% <50.00%> (-0.01%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `81.87% <100.00%> (-0.01%)` | :arrow_down: |
| presto | `52.44% <50.00%> (-0.01%)` | :arrow_down: |
| python | `82.26% <100.00%> (-0.05%)` | :arrow_down: |
| sqlite | `81.62% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...end/plugins/legacy-plugin-chart-chord/src/Chord.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9DaG9yZC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-chord/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../legacy-plugin-chart-country-map/src/CountryMap.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9Db3VudHJ5TWFwLmpz) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-country-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-histogram/src/Histogram.jsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvSGlzdG9ncmFtLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-histogram/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-partition/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ntend/plugins/legacy-plugin-chart-rose/src/Rose.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL1Jvc2UuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-rose/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL3RyYW5zZm9ybVByb3BzLmpz) | `0.00% <0.00%> (ø)` | |
| ... and [101 more](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bc6aad0...4ac8e61](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie merged pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
zhaoyongjie merged pull request #19038:
URL: https://github.com/apache/superset/pull/19038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1059982016
# [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19038](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a440419) into [master](https://codecov.io/gh/apache/superset/commit/30c97ad5bfe1dc9b074efc294c647c32fdd05fe0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (30c97ad) will **decrease** coverage by `0.02%`.
> The diff coverage is `52.00%`.
> :exclamation: Current head a440419 differs from pull request most recent head d59217f. Consider uploading reports for the commit d59217f to get more accurate results
```diff
@@ Coverage Diff @@
## master #19038 +/- ##
==========================================
- Coverage 66.55% 66.52% -0.03%
==========================================
Files 1646 1647 +1
Lines 63617 63632 +15
Branches 6471 6476 +5
==========================================
- Hits 42339 42332 -7
- Misses 19600 19623 +23
+ Partials 1678 1677 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.63% <50.00%> (+0.09%)` | :arrow_up: |
| javascript | `51.32% <51.35%> (+0.05%)` | :arrow_up: |
| mysql | `81.83% <100.00%> (-0.04%)` | :arrow_down: |
| postgres | `81.88% <100.00%> (-0.04%)` | :arrow_down: |
| presto | `52.47% <50.00%> (+0.09%)` | :arrow_up: |
| python | `82.31% <100.00%> (-0.04%)` | :arrow_down: |
| sqlite | `81.63% <100.00%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...et-ui-chart-controls/src/shared-controls/index.tsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3NoYXJlZC1jb250cm9scy9pbmRleC50c3g=) | `37.25% <0.00%> (-0.75%)` | :arrow_down: |
| [...ntend/packages/superset-ui-core/src/color/index.ts](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29sb3IvaW5kZXgudHM=) | `100.00% <ø> (ø)` | |
| [...end/plugins/legacy-plugin-chart-chord/src/Chord.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9DaG9yZC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-chord/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../legacy-plugin-chart-country-map/src/CountryMap.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9Db3VudHJ5TWFwLmpz) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-country-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-histogram/src/Histogram.jsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvSGlzdG9ncmFtLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-histogram/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <ø> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-partition/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <ø> (ø)` | |
| ... and [70 more](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [30c97ad...d59217f](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1059982016
# [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19038](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (722968d) into [master](https://codecov.io/gh/apache/superset/commit/e1d0b83885d89c50e96c6eef872beffe0de7cf50?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e1d0b83) will **increase** coverage by `0.00%`.
> The diff coverage is `52.00%`.
```diff
@@ Coverage Diff @@
## master #19038 +/- ##
=======================================
Coverage 66.53% 66.54%
=======================================
Files 1667 1668 +1
Lines 64360 64452 +92
Branches 6493 6503 +10
=======================================
+ Hits 42824 42888 +64
- Misses 19853 19881 +28
Partials 1683 1683
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.64% <50.00%> (-0.01%)` | :arrow_down: |
| javascript | `51.36% <51.35%> (+0.04%)` | :arrow_up: |
| mysql | `81.48% <100.00%> (+<0.01%)` | :arrow_up: |
| postgres | `81.53% <100.00%> (+<0.01%)` | :arrow_up: |
| presto | `52.49% <50.00%> (-0.01%)` | :arrow_down: |
| python | `81.95% <100.00%> (+<0.01%)` | :arrow_up: |
| sqlite | `81.29% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...et-ui-chart-controls/src/shared-controls/index.tsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3NoYXJlZC1jb250cm9scy9pbmRleC50c3g=) | `36.53% <0.00%> (-0.36%)` | :arrow_down: |
| [...ntend/packages/superset-ui-core/src/color/index.ts](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29sb3IvaW5kZXgudHM=) | `100.00% <ø> (ø)` | |
| [...end/plugins/legacy-plugin-chart-chord/src/Chord.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9DaG9yZC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-chord/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../legacy-plugin-chart-country-map/src/CountryMap.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9Db3VudHJ5TWFwLmpz) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-country-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-histogram/src/Histogram.jsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvSGlzdG9ncmFtLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-histogram/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <ø> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-partition/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <ø> (ø)` | |
| ... and [52 more](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e1d0b83...722968d](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1072402342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1072041435
@geido do you want to give this a final code pass? Sounds like we're about to have a beast of a problem behind us!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1059982016
# [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19038](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (77c54b5) into [master](https://codecov.io/gh/apache/superset/commit/70081a698fd423ab953d0943fc15ce88c24311ae?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70081a6) will **increase** coverage by `0.02%`.
> The diff coverage is `56.47%`.
> :exclamation: Current head 77c54b5 differs from pull request most recent head cdb4940. Consider uploading reports for the commit cdb4940 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19038 +/- ##
==========================================
+ Coverage 66.49% 66.52% +0.02%
==========================================
Files 1645 1647 +2
Lines 63515 63630 +115
Branches 6464 6476 +12
==========================================
+ Hits 42237 42330 +93
- Misses 19606 19623 +17
- Partials 1672 1677 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.32% <53.33%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...et-ui-chart-controls/src/shared-controls/index.tsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3NoYXJlZC1jb250cm9scy9pbmRleC50c3g=) | `37.25% <0.00%> (-0.37%)` | :arrow_down: |
| [...ntend/packages/superset-ui-core/src/color/index.ts](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29sb3IvaW5kZXgudHM=) | `100.00% <ø> (ø)` | |
| [...end/plugins/legacy-plugin-chart-chord/src/Chord.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9DaG9yZC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-chord/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../legacy-plugin-chart-country-map/src/CountryMap.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9Db3VudHJ5TWFwLmpz) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-country-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-histogram/src/Histogram.jsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvSGlzdG9ncmFtLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-histogram/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <ø> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-partition/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <ø> (ø)` | |
| ... and [66 more](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [70081a6...cdb4940](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa commented on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
jinghua-qa commented on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1068771081
I tested this PR locally, found another issue that, when applied native filter in different series of the same color, after filtered the it will still show same color of different series, is this acceptable?
https://user-images.githubusercontent.com/81597121/158527008-4162219e-1bd1-45eb-9877-2d0924d4fcf9.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa commented on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
jinghua-qa commented on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1065840551
Thank you for the fix! @stephenLYZ, i verified that the native filter issue has fixed. But i found another issue that when there is color scheme or customized label applied, if user open chart in explore, user will see warning that form data is lost and the color theme or label for the chart will be lost.
https://user-images.githubusercontent.com/81597121/158010313-b9947b9d-1817-45ba-a735-27f4bd95cb23.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1066617865
@stephenLYZ I think I know what's the problem here. This [PR](https://github.com/apache/superset/pull/18976) changed the default cache type to `NullCache` when not in debug mode. I think this is affecting the test environments. @villebro do you know how can we change this config for test environments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1059982016
# [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19038](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (722968d) into [master](https://codecov.io/gh/apache/superset/commit/e1d0b83885d89c50e96c6eef872beffe0de7cf50?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e1d0b83) will **decrease** coverage by `0.01%`.
> The diff coverage is `34.81%`.
```diff
@@ Coverage Diff @@
## master #19038 +/- ##
==========================================
- Coverage 66.53% 66.51% -0.02%
==========================================
Files 1667 1667
Lines 64360 64362 +2
Branches 6493 6493
==========================================
- Hits 42824 42813 -11
- Misses 19853 19866 +13
Partials 1683 1683
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.64% <50.00%> (-0.01%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `81.53% <100.00%> (+<0.01%)` | :arrow_up: |
| presto | `52.49% <50.00%> (-0.01%)` | :arrow_down: |
| python | `81.91% <100.00%> (-0.04%)` | :arrow_down: |
| sqlite | `81.29% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...end/plugins/legacy-plugin-chart-chord/src/Chord.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9DaG9yZC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-chord/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../legacy-plugin-chart-country-map/src/CountryMap.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9Db3VudHJ5TWFwLmpz) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-country-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-histogram/src/Histogram.jsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvSGlzdG9ncmFtLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-histogram/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-partition/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ntend/plugins/legacy-plugin-chart-rose/src/Rose.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL1Jvc2UuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-rose/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL3RyYW5zZm9ybVByb3BzLmpz) | `0.00% <0.00%> (ø)` | |
| ... and [100 more](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e1d0b83...722968d](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1072641914
@geido Ephemeral environment spinning up at http://50.112.38.121:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1059982016
# [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19038](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ee0f8fc) into [master](https://codecov.io/gh/apache/superset/commit/70081a698fd423ab953d0943fc15ce88c24311ae?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70081a6) will **decrease** coverage by `0.02%`.
> The diff coverage is `34.81%`.
> :exclamation: Current head ee0f8fc differs from pull request most recent head 3312ce7. Consider uploading reports for the commit 3312ce7 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19038 +/- ##
==========================================
- Coverage 66.49% 66.47% -0.03%
==========================================
Files 1645 1645
Lines 63515 63517 +2
Branches 6464 6464
==========================================
- Hits 42237 42222 -15
- Misses 19606 19623 +17
Partials 1672 1672
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.59% <50.00%> (-0.01%)` | :arrow_down: |
| postgres | `81.86% <100.00%> (-0.02%)` | :arrow_down: |
| presto | `52.44% <50.00%> (-0.01%)` | :arrow_down: |
| python | `82.21% <100.00%> (-0.06%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...end/plugins/legacy-plugin-chart-chord/src/Chord.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9DaG9yZC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-chord/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../legacy-plugin-chart-country-map/src/CountryMap.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9Db3VudHJ5TWFwLmpz) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-country-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-histogram/src/Histogram.jsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvSGlzdG9ncmFtLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-histogram/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-partition/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ntend/plugins/legacy-plugin-chart-rose/src/Rose.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL1Jvc2UuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-rose/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL3RyYW5zZm9ybVByb3BzLmpz) | `0.00% <0.00%> (ø)` | |
| ... and [108 more](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [70081a6...3312ce7](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1059982016
# [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19038](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ee0f8fc) into [master](https://codecov.io/gh/apache/superset/commit/70081a698fd423ab953d0943fc15ce88c24311ae?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70081a6) will **increase** coverage by `0.02%`.
> The diff coverage is `34.81%`.
> :exclamation: Current head ee0f8fc differs from pull request most recent head 3312ce7. Consider uploading reports for the commit 3312ce7 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19038 +/- ##
==========================================
+ Coverage 66.49% 66.52% +0.02%
==========================================
Files 1645 1645
Lines 63515 63517 +2
Branches 6464 6464
==========================================
+ Hits 42237 42252 +15
+ Misses 19606 19593 -13
Partials 1672 1672
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.59% <50.00%> (-0.01%)` | :arrow_down: |
| mysql | `81.82% <100.00%> (?)` | |
| postgres | `81.87% <100.00%> (+<0.01%)` | :arrow_up: |
| presto | `52.44% <50.00%> (-0.01%)` | :arrow_down: |
| python | `82.30% <100.00%> (+0.04%)` | :arrow_up: |
| sqlite | `81.62% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...end/plugins/legacy-plugin-chart-chord/src/Chord.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9DaG9yZC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-chord/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../legacy-plugin-chart-country-map/src/CountryMap.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9Db3VudHJ5TWFwLmpz) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-country-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-histogram/src/Histogram.jsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvSGlzdG9ncmFtLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-histogram/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-partition/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ntend/plugins/legacy-plugin-chart-rose/src/Rose.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL1Jvc2UuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-rose/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL3RyYW5zZm9ybVByb3BzLmpz) | `0.00% <0.00%> (ø)` | |
| ... and [100 more](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [70081a6...3312ce7](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1059982016
# [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19038](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (66fef88) into [master](https://codecov.io/gh/apache/superset/commit/70081a698fd423ab953d0943fc15ce88c24311ae?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70081a6) will **decrease** coverage by `0.00%`.
> The diff coverage is `34.81%`.
[](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19038 +/- ##
==========================================
- Coverage 66.49% 66.49% -0.01%
==========================================
Files 1645 1645
Lines 63515 63517 +2
Branches 6464 6464
==========================================
- Hits 42237 42235 -2
- Misses 19606 19610 +4
Partials 1672 1672
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.59% <50.00%> (-0.01%)` | :arrow_down: |
| postgres | `81.86% <100.00%> (-0.02%)` | :arrow_down: |
| presto | `52.44% <50.00%> (-0.01%)` | :arrow_down: |
| python | `82.25% <100.00%> (-0.02%)` | :arrow_down: |
| sqlite | `81.62% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...end/plugins/legacy-plugin-chart-chord/src/Chord.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9DaG9yZC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-chord/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../legacy-plugin-chart-country-map/src/CountryMap.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9Db3VudHJ5TWFwLmpz) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-country-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-histogram/src/Histogram.jsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvSGlzdG9ncmFtLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-histogram/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-partition/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ntend/plugins/legacy-plugin-chart-rose/src/Rose.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL1Jvc2UuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-rose/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL3RyYW5zZm9ybVByb3BzLmpz) | `0.00% <0.00%> (ø)` | |
| ... and [100 more](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [70081a6...66fef88](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1059982016
# [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19038](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (66fef88) into [master](https://codecov.io/gh/apache/superset/commit/70081a698fd423ab953d0943fc15ce88c24311ae?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70081a6) will **increase** coverage by `0.00%`.
> The diff coverage is `34.81%`.
[](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19038 +/- ##
=======================================
Coverage 66.49% 66.50%
=======================================
Files 1645 1645
Lines 63515 63517 +2
Branches 6464 6464
=======================================
+ Hits 42237 42239 +2
Misses 19606 19606
Partials 1672 1672
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.59% <50.00%> (-0.01%)` | :arrow_down: |
| postgres | `81.87% <100.00%> (+<0.01%)` | :arrow_up: |
| presto | `52.44% <50.00%> (-0.01%)` | :arrow_down: |
| python | `82.26% <100.00%> (+<0.01%)` | :arrow_up: |
| sqlite | `81.62% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...end/plugins/legacy-plugin-chart-chord/src/Chord.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9DaG9yZC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-chord/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../legacy-plugin-chart-country-map/src/CountryMap.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9Db3VudHJ5TWFwLmpz) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-country-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-histogram/src/Histogram.jsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvSGlzdG9ncmFtLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-histogram/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-partition/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ntend/plugins/legacy-plugin-chart-rose/src/Rose.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL1Jvc2UuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-rose/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL3RyYW5zZm9ybVByb3BzLmpz) | `0.00% <0.00%> (ø)` | |
| ... and [96 more](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [70081a6...66fef88](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1061285935
@rusackas Ephemeral environment spinning up at http://34.210.220.243:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1059982016
# [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19038](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4ac8e61) into [master](https://codecov.io/gh/apache/superset/commit/bc6aad0a88bbbbfd6c592f8813d1b72471788897?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bc6aad0) will **decrease** coverage by `0.00%`.
> The diff coverage is `34.81%`.
[](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19038 +/- ##
==========================================
- Coverage 66.51% 66.51% -0.01%
==========================================
Files 1644 1644
Lines 63491 63493 +2
Branches 6458 6458
==========================================
+ Hits 42231 42232 +1
- Misses 19590 19591 +1
Partials 1670 1670
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.59% <50.00%> (-0.01%)` | :arrow_down: |
| mysql | `81.82% <100.00%> (+<0.01%)` | :arrow_up: |
| postgres | `81.87% <100.00%> (-0.01%)` | :arrow_down: |
| presto | `52.44% <50.00%> (-0.01%)` | :arrow_down: |
| python | `82.30% <100.00%> (-0.01%)` | :arrow_down: |
| sqlite | `81.62% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...end/plugins/legacy-plugin-chart-chord/src/Chord.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9DaG9yZC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-chord/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../legacy-plugin-chart-country-map/src/CountryMap.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9Db3VudHJ5TWFwLmpz) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-country-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ns/legacy-plugin-chart-histogram/src/Histogram.jsx](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvSGlzdG9ncmFtLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-histogram/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhpc3RvZ3JhbS9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...egacy-plugin-chart-partition/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ntend/plugins/legacy-plugin-chart-rose/src/Rose.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL1Jvc2UuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-rose/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL3RyYW5zZm9ybVByb3BzLmpz) | `0.00% <0.00%> (ø)` | |
| ... and [97 more](https://codecov.io/gh/apache/superset/pull/19038/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bc6aad0...4ac8e61](https://codecov.io/gh/apache/superset/pull/19038?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa commented on pull request #19038: feat: improve color consistency (save all labels)
Posted by GitBox <gi...@apache.org>.
jinghua-qa commented on pull request #19038:
URL: https://github.com/apache/superset/pull/19038#issuecomment-1063402058
> @jinghua-qa in your case it looks like they just preserved their original colors. I tested with filtring labels using different colors and it works normally. Let me know if that requires additional discussion
I have tried use other color theme, i will got same color for a and e, i think i am expecting different color?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org