[jira] [Commented] (TOMEE-2287) MicroProfile Metrics Example for @Histogram

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TOMEE-2287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713661#comment-16713661 ] 

ASF GitHub Bot commented on TOMEE-2287:
---------------------------------------

GitHub user mpredli01 opened a pull request:

    https://github.com/apache/tomee/pull/263

    Add Metrics Histogram example in foler examples/mp-metrics-histogram

    Hello everyone:
    
    I added the Metrics Histogram example as described in TOMEE-2287.
    
    Mike.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mpredli01/tomee master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tomee/pull/263.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #263
    
----
commit d1e06dbb2e20c74e95b8d52261f121a8d62c87bf
Author: Michael P. Redlich <mi...@...>
Date:   2018-12-08T12:39:36Z

    Add Metrics Histogram example in foler examples/mp-metrics-histogram

----


> MicroProfile Metrics Example for @Histogram
> -------------------------------------------
>
>                 Key: TOMEE-2287
>                 URL: https://issues.apache.org/jira/browse/TOMEE-2287
>             Project: TomEE
>          Issue Type: Sub-task
>            Reporter: Ivan Junckes Filho
>            Assignee: Ivan Junckes Filho
>            Priority: Major
>              Labels: examples, pull-request-available
>
> We would like to have an example for MicroProfile Metrics @Histogram annotation.
> Here is a quick tutorial on MicroProfile Metrics if you are not aware of it:
> [https://www.tomitribe.com/blog/getting-started-with-microprofile-metrics/]
> Fork / clone the TomEE project from here:
> [https://github.com/apache/tomee]
> Example name should be _mp-metrics-histogram_, following the standard already in the project.
> All the examples are in:
> [https://github.com/apache/tomee/tree/master/examples]
> See this example of @Counted for reference:
> [https://github.com/apache/tomee/tree/master/examples/mp-metrics-counted]
> See these two PRs for the diff for @Counted, it will help you see how simple it is:
> [https://github.com/apache/tomee/pull/203]
> [https://github.com/apache/tomee/pull/207]
> What you have to do is:
> 1 - Create a method in the WeatherService class with @Histogram
> 2 - Have a WeatherServiceTest for the GET and OPTIONS scenarios of @Histogram
> 3 - Make sure you have tests for Prometheus and JSON formats
> 4 - Make sure all the tests pass
> After that submit a PR and we'll review it.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)