[GitHub] [incubator-apisix] membphis commented on a change in pull request #1133: bugfix: use `ss.listen_port` to generate https listening port.

[GitBox <gi...@apache.org>]

membphis commented on a change in pull request #1133: bugfix: use `ss.listen_port` to generate https listening port.
URL: https://github.com/apache/incubator-apisix/pull/1133#discussion_r380443183
 
 

 ##########
 File path: .travis/apisix_cli_test.sh
 ##########
 @@ -17,13 +17,38 @@
 # limitations under the License.
 #
 
-#check whether the 'reuseport' is in nginx.conf .
-matched=`grep -E "listen.*reuseport" conf/nginx.conf | wc -l`
-if [ $matched -eq 0 ]; then
+# 'make init' operates scripts and related configuration files in the current directory
+# The 'apisix' command is a command in the /usr/local/apisix,
+# and the configuration file for the operation is in the /usr/local/apisix/conf
+
+set -ex
+
+# check whether the 'reuseport' is in nginx.conf .
+make init
+
+grep -E "listen 9080.*reuseport" conf/nginx.conf > /dev/null
+if [ ! $? -eq 0 ]; then
     echo "failed: nginx.conf file is missing reuseport configuration"
     exit 1
-else
-    echo "passed: nginx.conf file contains reuseport configuration"
 fi
 
-exit 0
+echo "passed: nginx.conf file contains reuseport configuration"
+
+# check default ssl port
+sed  -i 's/listen_port: 9443/listen_port: 8443/g'  conf/config.yaml
+
+make init
 
 Review comment:
   This is to make each test unit relatively independent.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services