You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "qqu0127 (via GitHub)" <gi...@apache.org> on 2023/02/02 15:56:07 UTC

[GitHub] [helix] qqu0127 commented on pull request #2353: Implement direct child change listener in ZkMetaClient

qqu0127 commented on PR #2353:
URL: https://github.com/apache/helix/pull/2353#issuecomment-1413968899

   > We should have consistent terminology:
   > 
   > 1. Native ZK Client - this is how Apache Zk client has contract.
   > 2. Helix ZK Client - this is our client which we have taken from IO???
   > 3. MetaClient -
   > 4. Curator ZK client
   > 
   > I am saying this here as when i read the description of the review, I get a bit confused.
   
   Thanks @desaikomal , to clarify on the terminology:
   - The "native zkclient" was forked from I0Itech, open source, not a Apache project. It's now part of our source code
   - Helix zkclient, with a few different flavors, is built on top of the native zkclient.
   - ZkMetaClient is the zk impl of metaclient interface, it eventually uses the native zkclient
   - Curator is a Apache top project, itself is a zkclient, but quite different from any above.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org