You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/03/13 06:32:23 UTC
[GitHub] [helix] narendly opened a new pull request #893: Format
ZkBaseDataAccessor and fix minor bugs and documentation
narendly opened a new pull request #893: Format ZkBaseDataAccessor and fix minor bugs and documentation
URL: https://github.com/apache/helix/pull/893
### Issues
- [x] My PR addresses the following Helix issues and references them in the PR description:
Fixes #891
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
I accidentally reformatted the entire file. I am sorry. But it is for the better :) - this PR doesn't change any logic but the following:
Changelist:
1. Add generic type markers to Builder (<T>)
2. Fix a bug in validate function
3. Default to ZNRecordSerializer to preserve existing behavior
### Tests
Tested in https://github.com/apache/helix/pull/892
### Commits
- [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation (Optional)
- [ ] In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Code Quality
- [x] My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly commented on issue #893: Format ZkBaseDataAccessor
and fix minor bugs and documentation
Posted by GitBox <gi...@apache.org>.
narendly commented on issue #893: Format ZkBaseDataAccessor and fix minor bugs and documentation
URL: https://github.com/apache/helix/pull/893#issuecomment-598980832
This PR is ready to be merged, approved by @pkuwm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly merged pull request #893: Format
ZkBaseDataAccessor and fix minor bugs and documentation
Posted by GitBox <gi...@apache.org>.
narendly merged pull request #893: Format ZkBaseDataAccessor and fix minor bugs and documentation
URL: https://github.com/apache/helix/pull/893
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org