You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hama.apache.org by "Suraj Menon (JIRA)" <ji...@apache.org> on 2013/07/05 18:47:49 UTC
[jira] [Commented] (HAMA-776) localQueue is set as Send queue in
init function of AbstractMessageManager
[ https://issues.apache.org/jira/browse/HAMA-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13700990#comment-13700990 ]
Suraj Menon commented on HAMA-776:
----------------------------------
+1. We never saw the issue because the the localQueue was never used in first superstep. I don't think we need to have thread-safety for now.?
> localQueue is set as Send queue in init function of AbstractMessageManager
> --------------------------------------------------------------------------
>
> Key: HAMA-776
> URL: https://issues.apache.org/jira/browse/HAMA-776
> Project: Hama
> Issue Type: Bug
> Components: bsp core
> Affects Versions: 0.6.2
> Reporter: MaoYuan Xian
>
> In init method of AbstractMessageManager, the following codes found:
> {code}
> public void init(TaskAttemptID attemptId, BSPPeer<?, ?, ?, ?, M> peer,
> Configuration conf, InetSocketAddress peerAddress) {
> ...
> this.peerAddress = peerAddress;
> this.localQueue = getSenderQueue();
> this.localQueueForNextIteration = getSynchronizedReceiverQueue();
> this.maxCachedConnections = conf.getInt(MAX_CACHED_CONNECTIONS_KEY, 100);
> }
> {code}
> The localQueue should be a receiveQueue but it is assigned here, should it be changed as following?:
> {code}
> this.localQueue = getSynchronizedReceiverQueue();
> {code}
> Is there any special purpose here when set it as senderQueue?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira