You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/03/04 20:53:16 UTC
[GitHub] [incubator-superset] villebro commented on issue #9195: [Explore]
Add Test SQL button to table explore view
villebro commented on issue #9195: [Explore] Add Test SQL button to table explore view
URL: https://github.com/apache/incubator-superset/pull/9195#issuecomment-594832401
To address @willbarrett 's concern, instead of actually running the query, I wonder if it would be feasible to implement some type of sql statement dry run functionality in `BaseEngineSpec`. For instance, in Postgres one can prefix the query with `EXPLAIN`, which returns the following for a valid query:
When doing the same for an invalid query, it returns the following:
For other dbs without `EXPLAIN`, one could potentially do a `ROLLBACK` at the end or some other trickery.
Personally, I don't particularly like the idea of running a query out of context like this, and can imagine some dbs potentially getting overloaded if the query generates a large number of rows.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org