[jira] [Commented] (CB-11136) InAppBrowser fails to close with WKWebView OAuth

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15444031#comment-15444031 ] 

ASF GitHub Bot commented on CB-11136:
-------------------------------------

Github user dotNetkow commented on the issue:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/162
  
    hi @shazron - any way your team could consider this? OAuth is a major reason folks use InAppBrowser, and for years now it's been feasible and "supported" in a sense with UIWebView.  
    
    One alternative is to use the "toolbar=yes" option, which shows a "done" link that will close the browser.  Developer's would have to have a self hosted page that tells the user to tap the link, like "Successfully connected! Please tap Done to continue".  Not the best usability but possible:
    
    `inAppBrowserRef = window.open("www.google.com", '_blank', 'toolbar=yes');`
    
    However, I once had Apple reject my app with this option in place - they didn't like that it obviously loading "something" outside of my app.  So that's probably out :(
    
    Thanks for considering.  The performance gains from WKWebView are immense, so I'd hate to miss out on using it!


> InAppBrowser fails to close with WKWebView OAuth 
> -------------------------------------------------
>
>                 Key: CB-11136
>                 URL: https://issues.apache.org/jira/browse/CB-11136
>             Project: Apache Cordova
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Plugin InAppBrowser, Plugin WKWebViewEngine
>    Affects Versions: 4.1.0
>         Environment: iOS 8+ with WKWebView
>            Reporter: Geordie Jay
>            Assignee: Shazron Abdullah
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> Launching InAppBrowser from Cordova iOS Platform 4+ with its WKWebView for OAuth (e.g. Facebook or Google login) fails to close as it should.
> The reason is that the entire WKWebView thread seems to pause when another view controller is presented. This can be confirmed by inspecting the WKWebView session in Safari, running `window.open('http://something.com')` and then trying to enter another command into that Safari console.
> I made a hacky but working version of this that animated in the InAppBrowser's view manually, rather than 'presenting' the ViewController in the traditional iOS style. In that instance the WKWebView thread continues as normal and receives the confirmation to close the other InAppBrowser when the OAuth process is complete.
> Maybe there is a better way around this, but at the moment this is a big usability fail for all WKWebView users.
> What do you all think, is the 'not-actually-presenting' way of presenting the InAppBrowser acceptable? Would be happy to make a pull request along these lines if it is.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org