You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/09/24 14:26:17 UTC

[GitHub] [cloudstack-primate] davidjumani opened a new pull request #751: Adding multi disk selection for supported templates

davidjumani opened a new pull request #751:
URL: https://github.com/apache/cloudstack-primate/pull/751


   Adding support for non deploy as is templates which have multiple data disks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #751: Adding multi disk selection for supported templates

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #751:
URL: https://github.com/apache/cloudstack-primate/pull/751#issuecomment-698721333


   @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #751: Adding multi disk selection for supported templates

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #751:
URL: https://github.com/apache/cloudstack-primate/pull/751#issuecomment-698400438


   @andrijapanicsb a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] andrijapanicsb commented on pull request #751: Adding multi disk selection for supported templates

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #751:
URL: https://github.com/apache/cloudstack-primate/pull/751#issuecomment-698758378


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #751: Adding multi disk selection for supported templates

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #751:
URL: https://github.com/apache/cloudstack-primate/pull/751#issuecomment-698428775


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/751 (JID-3514)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] nvazquez commented on a change in pull request #751: Adding multi disk selection for supported templates

Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #751:
URL: https://github.com/apache/cloudstack-primate/pull/751#discussion_r494735051



##########
File path: src/views/compute/DeployVM.vue
##########
@@ -1484,6 +1524,12 @@ export default {
           deployVmData.bootintosetup = values.bootintosetup
         }
 
+        // if (deployVmData) {

Review comment:
       Remove me :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] nvazquez commented on a change in pull request #751: Adding multi disk selection for supported templates

Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #751:
URL: https://github.com/apache/cloudstack-primate/pull/751#discussion_r494735051



##########
File path: src/views/compute/DeployVM.vue
##########
@@ -1484,6 +1524,12 @@ export default {
           deployVmData.bootintosetup = values.bootintosetup
         }
 
+        // if (deployVmData) {

Review comment:
       Remove me :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #751: Adding multi disk selection for supported templates

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #751:
URL: https://github.com/apache/cloudstack-primate/pull/751#issuecomment-698422773


   @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] andrijapanicsb commented on pull request #751: Adding multi disk selection for supported templates

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #751:
URL: https://github.com/apache/cloudstack-primate/pull/751#issuecomment-698400120


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] andrijapanicsb merged pull request #751: Adding multi disk selection for supported templates

Posted by GitBox <gi...@apache.org>.
andrijapanicsb merged pull request #751:
URL: https://github.com/apache/cloudstack-primate/pull/751


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani commented on pull request #751: Adding multi disk selection for supported templates

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #751:
URL: https://github.com/apache/cloudstack-primate/pull/751#issuecomment-698721217


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #751: Adding multi disk selection for supported templates

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #751:
URL: https://github.com/apache/cloudstack-primate/pull/751#issuecomment-698724499


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/751 (JID-3516)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] andrijapanicsb merged pull request #751: Adding multi disk selection for supported templates

Posted by GitBox <gi...@apache.org>.
andrijapanicsb merged pull request #751:
URL: https://github.com/apache/cloudstack-primate/pull/751


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani commented on pull request #751: Adding multi disk selection for supported templates

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #751:
URL: https://github.com/apache/cloudstack-primate/pull/751#issuecomment-698422257






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #751: Adding multi disk selection for supported templates

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #751:
URL: https://github.com/apache/cloudstack-primate/pull/751#issuecomment-698400438






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani commented on pull request #751: Adding multi disk selection for supported templates

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #751:
URL: https://github.com/apache/cloudstack-primate/pull/751#issuecomment-698422257


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #751: Adding multi disk selection for supported templates

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #751:
URL: https://github.com/apache/cloudstack-primate/pull/751#issuecomment-698406656


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/751 (JID-3513)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] andrijapanicsb commented on pull request #751: Adding multi disk selection for supported templates

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #751:
URL: https://github.com/apache/cloudstack-primate/pull/751#issuecomment-698400120






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org