You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/03/30 18:04:09 UTC

[GitHub] [beam] kennknowles commented on a change in pull request #14374: [BEAM-12071] Don't re-use WriteToPandasSink instances across windows

kennknowles commented on a change in pull request #14374:
URL: https://github.com/apache/beam/pull/14374#discussion_r604320333



##########
File path: sdks/python/apache_beam/dataframe/io.py
##########
@@ -521,7 +521,7 @@ def expand(self, pcoll):
     return pcoll | fileio.WriteToFiles(
         path=dir,
         file_naming=fileio.default_file_naming(name),
-        sink=_WriteToPandasFileSink(
+        sink=lambda _: _WriteToPandasFileSink(

Review comment:
       Based on the ease of making this mistake, is the `WriteToFiles` API a hazard to other contributors and users?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org