[jira] [Commented] (YUNIKORN-678) Refactoring REST API re-design changes in handlers.go, handlers_test.go

["Weiwei Yang (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YUNIKORN-678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356056#comment-17356056 ] 

Weiwei Yang commented on YUNIKORN-678:
--------------------------------------

hi [~manirajv06@gmail.com]

To simplify this, let's add a convention: the partition name *must be a unique string* while registering to yunikorn.
This can avoid a lot of issues. For this issue, we can add a function in https://github.com/apache/incubator-yunikorn-core/blob/master/pkg/scheduler/context.go, something like {{GetPartitionWithoutClusterID()}}, then we simply loop all the partitions and find the one that matches the partition name string.
This is for the simplicity of using the APIs. Hope this makes sense to you.

> Refactoring REST API re-design changes in handlers.go, handlers_test.go
> -----------------------------------------------------------------------
>
>                 Key: YUNIKORN-678
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-678
>             Project: Apache YuniKorn
>          Issue Type: Sub-task
>            Reporter: Manikandan R
>            Assignee: Manikandan R
>            Priority: Major
>              Labels: pull-request-available
>
> Tasks:
> 1. Avoid repeating "Partition not found", "Queue not found" etc asserts.
> 2. Make use of utils.GetNormalizedPartitionName to avoid cluster id in partition name
> 3. Address https://github.com/apache/incubator-yunikorn-core/pull/224#discussion_r636531149



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org