You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Justin Edelson <ju...@justinedelson.com> on 2017/03/27 18:52:37 UTC
Maven dependency to org.apache.sling.commons.johnzon
As part of the Commons JSON migration (kudos to all those plugging away at
this thankless task), I see that some dependencies are being created
directly to org.apache.sling.commons.johnzon, e.g.
https://github.com/apache/sling/blob/trunk/bundles/extensions/adapter/pom.xml#L89
.
IIUC, we should really be depending upon the javax.json API, not our
bundling of it. While I don't see any problems related to this right now,
it seems like we could end up accidentally creating a dependency to the
Johnzon implementation (or our wrapper of the Johnzon implementation).
WDYT?
Re: Maven dependency to org.apache.sling.commons.johnzon
Posted by Karl Pauls <ka...@gmail.com>.
I know. Not saying it was wrong - this way it just hit the trunk before I
could cleanup my mess :-)
Don't worry about it. I'm close to getting this committed anyways. I'll
update it together with the rest.
regards,
Karl
On Tuesday, March 28, 2017, Carsten Ziegeler <cz...@apache.org> wrote:
> Karl Pauls wrote
> > I agree. I'm not at the point where I can commit anything so all the
> > patches are subject to clean-up and I wouldn't want them to get out
> > before that. Carsten jumped the gun somewhat on this one but I'll
> > clean-up when I'm ready to commit all of this.
> >
> :) I just applied one of your patches to spare the pain of merging.
> So what are the coordinates to use?
>
> Carsten
>
> > regards,
> >
> > Karl
> >
> > On Mon, Mar 27, 2017 at 8:52 PM, Justin Edelson
> > <justin@justinedelson.com <javascript:;>> wrote:
> >> As part of the Commons JSON migration (kudos to all those plugging away
> at
> >> this thankless task), I see that some dependencies are being created
> >> directly to org.apache.sling.commons.johnzon, e.g.
> >> https://github.com/apache/sling/blob/trunk/bundles/
> extensions/adapter/pom.xml#L89
> >> .
> >>
> >> IIUC, we should really be depending upon the javax.json API, not our
> >> bundling of it. While I don't see any problems related to this right
> now,
> >> it seems like we could end up accidentally creating a dependency to the
> >> Johnzon implementation (or our wrapper of the Johnzon implementation).
> >>
> >> WDYT?
> >
> >
> >
>
>
>
>
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziegeler@apache.org <javascript:;>
>
--
Karl Pauls
karlpauls@gmail.com
Re: Maven dependency to org.apache.sling.commons.johnzon
Posted by Carsten Ziegeler <cz...@apache.org>.
Karl Pauls wrote
> I agree. I'm not at the point where I can commit anything so all the
> patches are subject to clean-up and I wouldn't want them to get out
> before that. Carsten jumped the gun somewhat on this one but I'll
> clean-up when I'm ready to commit all of this.
>
:) I just applied one of your patches to spare the pain of merging.
So what are the coordinates to use?
Carsten
> regards,
>
> Karl
>
> On Mon, Mar 27, 2017 at 8:52 PM, Justin Edelson
> <ju...@justinedelson.com> wrote:
>> As part of the Commons JSON migration (kudos to all those plugging away at
>> this thankless task), I see that some dependencies are being created
>> directly to org.apache.sling.commons.johnzon, e.g.
>> https://github.com/apache/sling/blob/trunk/bundles/extensions/adapter/pom.xml#L89
>> .
>>
>> IIUC, we should really be depending upon the javax.json API, not our
>> bundling of it. While I don't see any problems related to this right now,
>> it seems like we could end up accidentally creating a dependency to the
>> Johnzon implementation (or our wrapper of the Johnzon implementation).
>>
>> WDYT?
>
>
>
--
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org
Re: Maven dependency to org.apache.sling.commons.johnzon
Posted by Karl Pauls <ka...@gmail.com>.
I agree. I'm not at the point where I can commit anything so all the
patches are subject to clean-up and I wouldn't want them to get out
before that. Carsten jumped the gun somewhat on this one but I'll
clean-up when I'm ready to commit all of this.
regards,
Karl
On Mon, Mar 27, 2017 at 8:52 PM, Justin Edelson
<ju...@justinedelson.com> wrote:
> As part of the Commons JSON migration (kudos to all those plugging away at
> this thankless task), I see that some dependencies are being created
> directly to org.apache.sling.commons.johnzon, e.g.
> https://github.com/apache/sling/blob/trunk/bundles/extensions/adapter/pom.xml#L89
> .
>
> IIUC, we should really be depending upon the javax.json API, not our
> bundling of it. While I don't see any problems related to this right now,
> it seems like we could end up accidentally creating a dependency to the
> Johnzon implementation (or our wrapper of the Johnzon implementation).
>
> WDYT?
--
Karl Pauls
karlpauls@gmail.com