You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Rick Hillegas (JIRA)" <ji...@apache.org> on 2010/06/29 17:23:49 UTC
[jira] Created: (DERBY-4725) Fix message build so that double
quotes aren't inserted for English messages.
Fix message build so that double quotes aren't inserted for English messages.
-----------------------------------------------------------------------------
Key: DERBY-4725
URL: https://issues.apache.org/jira/browse/DERBY-4725
Project: Derby
Issue Type: Improvement
Components: Localization
Affects Versions: 10.6.1.0
Reporter: Rick Hillegas
Priority: Minor
When messages_en.properties is generated from messages.xml, single quotes are turned into double quotes. For instance, the text for 42XAC is turned into
''INCREMENT BY'' value can not be zero.
This doesn't seem to cause any harm. MessageFormat does the right thing and strips out the extra quote. If the messages only have single quotes, MessageFormat also does the right thing and leaves the phrase single-quoted. The double quotes, however, are confusing to the people who are localizing the 10.6 messages. There would be less confusion if the build did not insert extra quotes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4725) Fix message build so that double
quotes aren't inserted for English messages.
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883680#action_12883680 ]
Knut Anders Hatlen commented on DERBY-4725:
-------------------------------------------
I tested the following code:
String pattern = "Don't use single quotes! They're no good!";
String msg = MessageFormat.format(pattern, new Object[0]);
System.out.println(msg);
And here's what was printed:
Dont use single quotes! Theyre no good!
Also, some of our messages already use a single quote instead of double quotes. One example is this message in the Italian translation:
42X34=Esiste un parametro ? nell'elenco di selezione. Ci\u00F2 non \u00E8 consentito.
Here's what it looks like when the error is raised:
ij> select ? from sysibm.sysdummy1;
ERRORE 42X34: Esiste un parametro ? nellelenco di selezione. Ciò non è consentito.
Note that it says "nellelenco" instead of "nell'elenco". So it seems to me that we should rather try to use double quotes consistently instead of moving to single quotes.
> Fix message build so that double quotes aren't inserted for English messages.
> -----------------------------------------------------------------------------
>
> Key: DERBY-4725
> URL: https://issues.apache.org/jira/browse/DERBY-4725
> Project: Derby
> Issue Type: Improvement
> Components: Localization
> Affects Versions: 10.6.1.0
> Reporter: Rick Hillegas
> Priority: Minor
>
> When messages_en.properties is generated from messages.xml, single quotes are turned into double quotes. For instance, the text for 42XAC is turned into
> ''INCREMENT BY'' value can not be zero.
> This doesn't seem to cause any harm. MessageFormat does the right thing and strips out the extra quote. If the messages only have single quotes, MessageFormat also does the right thing and leaves the phrase single-quoted. The double quotes, however, are confusing to the people who are localizing the 10.6 messages. There would be less confusion if the build did not insert extra quotes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4725) Fix message build so that double
quotes aren't inserted for English messages.
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883696#action_12883696 ]
Rick Hillegas commented on DERBY-4725:
--------------------------------------
Thanks for digging into this, Knut. The issue comes up because of the localization work being done on the 10.6 messages. As you have noticed, quoting isn't done consistently across our messages. I'm not confident that the messages appear correctly today on all possible vms. This is an area of Derby which is largely untested.
> Fix message build so that double quotes aren't inserted for English messages.
> -----------------------------------------------------------------------------
>
> Key: DERBY-4725
> URL: https://issues.apache.org/jira/browse/DERBY-4725
> Project: Derby
> Issue Type: Improvement
> Components: Localization
> Affects Versions: 10.6.1.0
> Reporter: Rick Hillegas
> Priority: Minor
>
> When messages_en.properties is generated from messages.xml, single quotes are turned into double quotes. For instance, the text for 42XAC is turned into
> ''INCREMENT BY'' value can not be zero.
> This doesn't seem to cause any harm. MessageFormat does the right thing and strips out the extra quote. If the messages only have single quotes, MessageFormat also does the right thing and leaves the phrase single-quoted. The double quotes, however, are confusing to the people who are localizing the 10.6 messages. There would be less confusion if the build did not insert extra quotes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-4725) Fix message build so that double quotes
aren't inserted for English messages.
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Hillegas closed DERBY-4725.
--------------------------------
Resolution: Invalid
Since the messages appear correctly today, it is safest not to attempt this.
> Fix message build so that double quotes aren't inserted for English messages.
> -----------------------------------------------------------------------------
>
> Key: DERBY-4725
> URL: https://issues.apache.org/jira/browse/DERBY-4725
> Project: Derby
> Issue Type: Improvement
> Components: Localization
> Affects Versions: 10.6.1.0
> Reporter: Rick Hillegas
> Priority: Minor
>
> When messages_en.properties is generated from messages.xml, single quotes are turned into double quotes. For instance, the text for 42XAC is turned into
> ''INCREMENT BY'' value can not be zero.
> This doesn't seem to cause any harm. MessageFormat does the right thing and strips out the extra quote. If the messages only have single quotes, MessageFormat also does the right thing and leaves the phrase single-quoted. The double quotes, however, are confusing to the people who are localizing the 10.6 messages. There would be less confusion if the build did not insert extra quotes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4725) Fix message build so that double
quotes aren't inserted for English messages.
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883673#action_12883673 ]
Knut Anders Hatlen commented on DERBY-4725:
-------------------------------------------
The way I read the javadoc for MessageFormat, our message files won't be well-formed if we change them as suggested. Do we feel confident that all JVMs will behave as described above when they see a single quote?
I noticed this section in MessageFormat's javadoc, by the way:
Warning:
The rules for using quotes within message format patterns unfortunately have shown to be somewhat confusing. In particular, it isn't always obvious to localizers whether single quotes need to be doubled or not. Make sure to inform localizers about the rules, and tell them (for example, by using comments in resource bundle source files) which strings will be processed by MessageFormat. Note that localizers may need to use single quotes in translated strings where the original version doesn't have them.
> Fix message build so that double quotes aren't inserted for English messages.
> -----------------------------------------------------------------------------
>
> Key: DERBY-4725
> URL: https://issues.apache.org/jira/browse/DERBY-4725
> Project: Derby
> Issue Type: Improvement
> Components: Localization
> Affects Versions: 10.6.1.0
> Reporter: Rick Hillegas
> Priority: Minor
>
> When messages_en.properties is generated from messages.xml, single quotes are turned into double quotes. For instance, the text for 42XAC is turned into
> ''INCREMENT BY'' value can not be zero.
> This doesn't seem to cause any harm. MessageFormat does the right thing and strips out the extra quote. If the messages only have single quotes, MessageFormat also does the right thing and leaves the phrase single-quoted. The double quotes, however, are confusing to the people who are localizing the 10.6 messages. There would be less confusion if the build did not insert extra quotes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.