You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Subroto Sanyal (Created) (JIRA)" <ji...@apache.org> on 2011/12/07 05:23:40 UTC
[jira] [Created] (MAPREDUCE-3516) Possible NPE in
org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect(K key, V value,
int partition)
Possible NPE in org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect(K key, V value, int partition)
-------------------------------------------------------------------------------------------------------
Key: MAPREDUCE-3516
URL: https://issues.apache.org/jira/browse/MAPREDUCE-3516
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: mrv2
Affects Versions: 0.23.0, 0.20.205.0, 0.20.203.0, 0.20.2, 0.20.1
Reporter: Subroto Sanyal
Assignee: Subroto Sanyal
*org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect* accepts a pair of Key and Value. There is chance that if somehow if a Null value or Key is passed to the method, we can end up having NPE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3516) Possible NPE in
org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect(K key, V value,
int partition)
Posted by "Subroto Sanyal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176154#comment-13176154 ]
Subroto Sanyal commented on MAPREDUCE-3516:
-------------------------------------------
Hi Harsh,
I agree, passing null can be user's mistake/error but, I feel framework should be capable of handling it rather than just exposing bare NPE.
> Possible NPE in org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect(K key, V value, int partition)
> -------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3516
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3516
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.20.1, 0.20.2, 0.20.203.0, 0.20.205.0, 0.23.0
> Reporter: Subroto Sanyal
> Assignee: Subroto Sanyal
>
> *org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect* accepts a pair of Key and Value. There is chance that if somehow if a Null value or Key is passed to the method, we can end up having NPE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3516) Possible NPE in
org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect(K key, V value,
int partition)
Posted by "Harsh J (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-3516:
-------------------------------
Status: Open (was: Patch Available)
> Possible NPE in org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect(K key, V value, int partition)
> -------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3516
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3516
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.0, 0.20.205.0, 0.20.203.0, 0.20.2, 0.20.1
> Reporter: Subroto Sanyal
> Assignee: Subroto Sanyal
> Attachments: MAPREDUCE-3516.patch
>
>
> *org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect* accepts a pair of Key and Value. There is chance that if somehow if a Null value or Key is passed to the method, we can end up having NPE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3516) Possible NPE in
org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect(K key, V value,
int partition)
Posted by "Harsh J (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191131#comment-13191131 ]
Harsh J commented on MAPREDUCE-3516:
------------------------------------
Change is fine (maybe add a test case to not regress? Should be easy to extend existing tests to cover this null check).
Does this not affect trunk btw? Can we have a patch for that as well, if it does? :)
Also, please do not include unrelated changes (Such as import statement rearrangements or cleanups). It is alright to file them as a separate JIRA instead.
> Possible NPE in org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect(K key, V value, int partition)
> -------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3516
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3516
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.20.1, 0.20.2, 0.20.203.0, 0.20.205.0, 0.23.0
> Reporter: Subroto Sanyal
> Assignee: Subroto Sanyal
> Attachments: MAPREDUCE-3516.patch
>
>
> *org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect* accepts a pair of Key and Value. There is chance that if somehow if a Null value or Key is passed to the method, we can end up having NPE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3516) Possible NPE in
org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect(K key, V value,
int partition)
Posted by "Harsh J (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-3516:
-------------------------------
Target Version/s: 0.24.0 (was: 1.1.0)
All fixes and features must first go to trunk if needed. Backports may be discussed later, depending on need and criticality.
> Possible NPE in org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect(K key, V value, int partition)
> -------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3516
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3516
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.20.1, 0.20.2, 0.20.203.0, 0.20.205.0, 0.23.0
> Reporter: Subroto Sanyal
> Assignee: Subroto Sanyal
> Attachments: MAPREDUCE-3516.patch
>
>
> *org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect* accepts a pair of Key and Value. There is chance that if somehow if a Null value or Key is passed to the method, we can end up having NPE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3516) Possible NPE in
org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect(K key, V value,
int partition)
Posted by "Harsh J (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176308#comment-13176308 ]
Harsh J commented on MAPREDUCE-3516:
------------------------------------
I'm +1 for better error messages over javadocs. I think this is more of an user-error situation, than it is a behavior/warning.
Would this regress any stuff with various serializations, that may even accept a 'null' as some valid k/v? Or does that have no chance to pass at all, since we attempt to call general methods on top of the key/value instances?
> Possible NPE in org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect(K key, V value, int partition)
> -------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3516
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3516
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.20.1, 0.20.2, 0.20.203.0, 0.20.205.0, 0.23.0
> Reporter: Subroto Sanyal
> Assignee: Subroto Sanyal
>
> *org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect* accepts a pair of Key and Value. There is chance that if somehow if a Null value or Key is passed to the method, we can end up having NPE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3516) Possible NPE in
org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect(K key, V value,
int partition)
Posted by "Harsh J (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176102#comment-13176102 ]
Harsh J commented on MAPREDUCE-3516:
------------------------------------
Doesn't this fall under the user-error land? Is this open to add-on guards that catch NPEs and throw up appropriate messages? I'm fine with that -- just asking if that is the goal of this JIRA.
> Possible NPE in org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect(K key, V value, int partition)
> -------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3516
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3516
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.20.1, 0.20.2, 0.20.203.0, 0.20.205.0, 0.23.0
> Reporter: Subroto Sanyal
> Assignee: Subroto Sanyal
>
> *org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect* accepts a pair of Key and Value. There is chance that if somehow if a Null value or Key is passed to the method, we can end up having NPE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3516) Possible NPE in
org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect(K key, V value,
int partition)
Posted by "Subroto Sanyal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Subroto Sanyal updated MAPREDUCE-3516:
--------------------------------------
Target Version/s: 1.1.0
> Possible NPE in org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect(K key, V value, int partition)
> -------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3516
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3516
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.20.1, 0.20.2, 0.20.203.0, 0.20.205.0, 0.23.0
> Reporter: Subroto Sanyal
> Assignee: Subroto Sanyal
> Attachments: MAPREDUCE-3516.patch
>
>
> *org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect* accepts a pair of Key and Value. There is chance that if somehow if a Null value or Key is passed to the method, we can end up having NPE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3516) Possible NPE in
org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect(K key, V value,
int partition)
Posted by "Bhallamudi Venkata Siva Kamesh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176241#comment-13176241 ]
Bhallamudi Venkata Siva Kamesh commented on MAPREDUCE-3516:
-----------------------------------------------------------
I think updating the API doc is enough, just like some of the Java lib APIs does.
{noformat}
Throws:
NullPointerException - If the key or value argument is null.
{noformat}
> Possible NPE in org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect(K key, V value, int partition)
> -------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3516
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3516
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.20.1, 0.20.2, 0.20.203.0, 0.20.205.0, 0.23.0
> Reporter: Subroto Sanyal
> Assignee: Subroto Sanyal
>
> *org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect* accepts a pair of Key and Value. There is chance that if somehow if a Null value or Key is passed to the method, we can end up having NPE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3516) Possible NPE in
org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect(K key, V value,
int partition)
Posted by "Subroto Sanyal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Subroto Sanyal updated MAPREDUCE-3516:
--------------------------------------
Status: Patch Available (was: Open)
> Possible NPE in org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect(K key, V value, int partition)
> -------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3516
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3516
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.0, 0.20.205.0, 0.20.203.0, 0.20.2, 0.20.1
> Reporter: Subroto Sanyal
> Assignee: Subroto Sanyal
> Attachments: MAPREDUCE-3516.patch
>
>
> *org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect* accepts a pair of Key and Value. There is chance that if somehow if a Null value or Key is passed to the method, we can end up having NPE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3516) Possible NPE in
org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect(K key, V value,
int partition)
Posted by "Harsh J (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176534#comment-13176534 ]
Harsh J commented on MAPREDUCE-3516:
------------------------------------
Yes, I guessed so too. The {{.getClass}} stuff we do for type checking will be the death of 'null' at entry itself.
Otherwise, the serializers are now entirely pluggable and are type agnostic -- they are not limited to just Writables and if I wanted to write a generic serializer with <Object, Object>, I could as well do that (and nulls may be OK then, sometimes). This is what I was wondering about -- but given the first point, I think it is not possible to pass a genuine null at all.
I think it is alright to look for NPEs before the map output buffer runs into them (while doing those getClass stuff) and show a proper message ("Received k/v was null" or so?).
> Possible NPE in org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect(K key, V value, int partition)
> -------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3516
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3516
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.20.1, 0.20.2, 0.20.203.0, 0.20.205.0, 0.23.0
> Reporter: Subroto Sanyal
> Assignee: Subroto Sanyal
>
> *org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect* accepts a pair of Key and Value. There is chance that if somehow if a Null value or Key is passed to the method, we can end up having NPE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3516) Possible NPE in
org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect(K key, V value,
int partition)
Posted by "Subroto Sanyal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176525#comment-13176525 ]
Subroto Sanyal commented on MAPREDUCE-3516:
-------------------------------------------
@Harsh
If I am not wrong, the K/V will be *Writables* on which some methods will be exceuted like:
* {noformat}key.getClass(){noformat}
* {noformat}public void serialize(Writable w) throws IOException {
w.write(dataOut);
}{noformat}
So I feel passing *null* to key/value will not be accepted by the framework. If user wants then they can use *NullWritable* for any such purpose.
What do you say?
> Possible NPE in org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect(K key, V value, int partition)
> -------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3516
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3516
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.20.1, 0.20.2, 0.20.203.0, 0.20.205.0, 0.23.0
> Reporter: Subroto Sanyal
> Assignee: Subroto Sanyal
>
> *org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect* accepts a pair of Key and Value. There is chance that if somehow if a Null value or Key is passed to the method, we can end up having NPE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3516) Possible NPE in
org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect(K key, V value,
int partition)
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191124#comment-13191124 ]
Hadoop QA commented on MAPREDUCE-3516:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12511487/MAPREDUCE-3516.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1651//console
This message is automatically generated.
> Possible NPE in org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect(K key, V value, int partition)
> -------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3516
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3516
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.20.1, 0.20.2, 0.20.203.0, 0.20.205.0, 0.23.0
> Reporter: Subroto Sanyal
> Assignee: Subroto Sanyal
> Attachments: MAPREDUCE-3516.patch
>
>
> *org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect* accepts a pair of Key and Value. There is chance that if somehow if a Null value or Key is passed to the method, we can end up having NPE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3516) Possible NPE in
org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect(K key, V value,
int partition)
Posted by "Subroto Sanyal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191121#comment-13191121 ]
Subroto Sanyal commented on MAPREDUCE-3516:
-------------------------------------------
Request review for the patch....
> Possible NPE in org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect(K key, V value, int partition)
> -------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3516
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3516
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.20.1, 0.20.2, 0.20.203.0, 0.20.205.0, 0.23.0
> Reporter: Subroto Sanyal
> Assignee: Subroto Sanyal
> Attachments: MAPREDUCE-3516.patch
>
>
> *org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect* accepts a pair of Key and Value. There is chance that if somehow if a Null value or Key is passed to the method, we can end up having NPE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3516) Possible NPE in
org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect(K key, V value,
int partition)
Posted by "Subroto Sanyal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191120#comment-13191120 ]
Subroto Sanyal commented on MAPREDUCE-3516:
-------------------------------------------
The patch is for Hadoop 1.1.0.
The patch makes _null_ checks for key and value and further it removes few unused imports.
> Possible NPE in org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect(K key, V value, int partition)
> -------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3516
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3516
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.20.1, 0.20.2, 0.20.203.0, 0.20.205.0, 0.23.0
> Reporter: Subroto Sanyal
> Assignee: Subroto Sanyal
> Attachments: MAPREDUCE-3516.patch
>
>
> *org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect* accepts a pair of Key and Value. There is chance that if somehow if a Null value or Key is passed to the method, we can end up having NPE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3516) Possible NPE in
org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect(K key, V value,
int partition)
Posted by "Subroto Sanyal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Subroto Sanyal updated MAPREDUCE-3516:
--------------------------------------
Attachment: MAPREDUCE-3516.patch
> Possible NPE in org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect(K key, V value, int partition)
> -------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3516
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3516
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.20.1, 0.20.2, 0.20.203.0, 0.20.205.0, 0.23.0
> Reporter: Subroto Sanyal
> Assignee: Subroto Sanyal
> Attachments: MAPREDUCE-3516.patch
>
>
> *org.apache.hadoop.mapred.MapTask.MapOutputBuffer.collect* accepts a pair of Key and Value. There is chance that if somehow if a Null value or Key is passed to the method, we can end up having NPE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira