[GitHub] samskalicky commented on a change in pull request #12427: Improved test for BilinearSampler

[GitBox <gi...@apache.org>]

samskalicky commented on a change in pull request #12427: Improved test for BilinearSampler
URL: https://github.com/apache/incubator-mxnet/pull/12427#discussion_r214492082
 
 

 ##########
 File path: tests/python/gpu/test_operator_gpu.py
 ##########
 @@ -1918,6 +1918,65 @@ def test_softmax_activation():
         assert_almost_equal(cpu_a.grad.asnumpy(), gpu_a.grad.asnumpy(),
                 atol = 1e-3, rtol = 1e-3)
 
+
+@with_seed()
+def test_bilinear_sampler_versions():
 
 Review comment:
   why is this test function being added to test_operator_gpu.py when the old one was in test_operator.py? Do we have a similar test function just for CPU too, or do we now need to run GPU tests to test the CPU implementation for this case?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services