[GitHub] [spark] yikf commented on a diff in pull request #37177: [SPARK-39765][SQL] Logging the exception of detect JDBC table exist

[GitBox <gi...@apache.org>]

yikf commented on code in PR #37177:
URL: https://github.com/apache/spark/pull/37177#discussion_r920874034


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala:
##########
@@ -71,7 +71,16 @@ object JdbcUtils extends Logging with SQLConfHelper {
       } finally {
         statement.close()
       }
-    }.isSuccess
+    } match {
+      case Success(_) => true
+      // This may be a known `TableAlreadyExist` exception, which is normal and proves that the
+      // table does not exist, but perhaps some other exception, which in fact does exist, will
+      // cause an error when renewing the table later. We need to know about the exception stack

Review Comment:
   No, end users see `warn` level only.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org