You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by David Smiley <ds...@apache.org> on 2015/04/12 21:02:10 UTC
Review Request 33114: LUCENE-6196 Geo3D
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33114/
-----------------------------------------------------------
Review request for lucene.
Repository: lucene
Description
-------
LUCENE-6196 Geo3D
Diffs
-----
trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/Geo3dShape.java PRE-CREATION
trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/Bounds.java PRE-CREATION
trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoArea.java PRE-CREATION
trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoAreaFactory.java PRE-CREATION
trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoBBox.java PRE-CREATION
trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoBBoxFactory.java PRE-CREATION
trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoBaseExtendedShape.java PRE-CREATION
trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoCircle.java PRE-CREATION
trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoCompositeMembershipShape.java PRE-CREATION
trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoConvexPolygon.java PRE-CREATION
trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoDistance.java PRE-CREATION
trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoDistanceShape.java PRE-CREATION
trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoLatitudeZone.java PRE-CREATION
trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoLongitudeSlice.java PRE-CREATION
trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoMembershipShape.java PRE-CREATION
trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoPath.java PRE-CREATION
trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoPoint.java PRE-CREATION
trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoPolygonFactory.java PRE-CREATION
trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoRectangle.java PRE-CREATION
trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoShape.java PRE-CREATION
trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoSizeable.java PRE-CREATION
trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoWideLongitudeSlice.java PRE-CREATION
trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoWideRectangle.java PRE-CREATION
trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoWorld.java PRE-CREATION
trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/Membership.java PRE-CREATION
trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/Plane.java PRE-CREATION
trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/SidedPlane.java PRE-CREATION
trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/Tools.java PRE-CREATION
trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/Vector.java PRE-CREATION
trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/package-info.java PRE-CREATION
trunk/lucene/spatial/src/test/org/apache/lucene/spatial/prefix/RandomSpatialOpStrategyTestCase.java 1672923
trunk/lucene/spatial/src/test/org/apache/lucene/spatial/spatial4j/Geo3dRptTest.java PRE-CREATION
trunk/lucene/spatial/src/test/org/apache/lucene/spatial/spatial4j/geo3d/GeoBBoxTest.java PRE-CREATION
trunk/lucene/spatial/src/test/org/apache/lucene/spatial/spatial4j/geo3d/GeoCircleTest.java PRE-CREATION
trunk/lucene/spatial/src/test/org/apache/lucene/spatial/spatial4j/geo3d/GeoConvexPolygonTest.java PRE-CREATION
trunk/lucene/spatial/src/test/org/apache/lucene/spatial/spatial4j/geo3d/GeoPathTest.java PRE-CREATION
trunk/lucene/spatial/src/test/org/apache/lucene/spatial/spatial4j/geo3d/GeoPolygonTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/33114/diff/
Testing
-------
Thanks,
David Smiley
Re: Review Request 33114: LUCENE-6196 Geo3D
Posted by Karl Wright <Da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33114/#review79826
-----------------------------------------------------------
New test added assumes GeoPoint coordinates are in degrees, but they are in fact in radians in the geo3d package.
- Karl Wright
On April 12, 2015, 7:02 p.m., David Smiley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33114/
> -----------------------------------------------------------
>
> (Updated April 12, 2015, 7:02 p.m.)
>
>
> Review request for lucene.
>
>
> Repository: lucene
>
>
> Description
> -------
>
> LUCENE-6196 Geo3D
>
>
> Diffs
> -----
>
> trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/Geo3dShape.java PRE-CREATION
> trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/Bounds.java PRE-CREATION
> trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoArea.java PRE-CREATION
> trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoAreaFactory.java PRE-CREATION
> trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoBBox.java PRE-CREATION
> trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoBBoxFactory.java PRE-CREATION
> trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoBaseExtendedShape.java PRE-CREATION
> trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoCircle.java PRE-CREATION
> trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoCompositeMembershipShape.java PRE-CREATION
> trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoConvexPolygon.java PRE-CREATION
> trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoDistance.java PRE-CREATION
> trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoDistanceShape.java PRE-CREATION
> trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoLatitudeZone.java PRE-CREATION
> trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoLongitudeSlice.java PRE-CREATION
> trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoMembershipShape.java PRE-CREATION
> trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoPath.java PRE-CREATION
> trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoPoint.java PRE-CREATION
> trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoPolygonFactory.java PRE-CREATION
> trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoRectangle.java PRE-CREATION
> trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoShape.java PRE-CREATION
> trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoSizeable.java PRE-CREATION
> trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoWideLongitudeSlice.java PRE-CREATION
> trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoWideRectangle.java PRE-CREATION
> trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/GeoWorld.java PRE-CREATION
> trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/Membership.java PRE-CREATION
> trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/Plane.java PRE-CREATION
> trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/SidedPlane.java PRE-CREATION
> trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/Tools.java PRE-CREATION
> trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/Vector.java PRE-CREATION
> trunk/lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/geo3d/package-info.java PRE-CREATION
> trunk/lucene/spatial/src/test/org/apache/lucene/spatial/prefix/RandomSpatialOpStrategyTestCase.java 1672923
> trunk/lucene/spatial/src/test/org/apache/lucene/spatial/spatial4j/Geo3dRptTest.java PRE-CREATION
> trunk/lucene/spatial/src/test/org/apache/lucene/spatial/spatial4j/geo3d/GeoBBoxTest.java PRE-CREATION
> trunk/lucene/spatial/src/test/org/apache/lucene/spatial/spatial4j/geo3d/GeoCircleTest.java PRE-CREATION
> trunk/lucene/spatial/src/test/org/apache/lucene/spatial/spatial4j/geo3d/GeoConvexPolygonTest.java PRE-CREATION
> trunk/lucene/spatial/src/test/org/apache/lucene/spatial/spatial4j/geo3d/GeoPathTest.java PRE-CREATION
> trunk/lucene/spatial/src/test/org/apache/lucene/spatial/spatial4j/geo3d/GeoPolygonTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33114/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Smiley
>
>