You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by chibenwa <gi...@git.apache.org> on 2015/11/04 14:43:21 UTC
[GitHub] james-project pull request: JAMES-1635 Increase embedded Cassandra...
GitHub user chibenwa opened a pull request:
https://github.com/apache/james-project/pull/17
JAMES-1635 Increase embedded Cassandra startup timeout
Increase embedded Cassandra startup timeout to the value configured in CassandraCluster used for unit tests.
This will avoid tests to fail on less effective computers.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chibenwa/james-project JAMES-1635
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/james-project/pull/17.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17
----
commit 6dee03a010ccc37441089dc62394577a18f7ad3c
Author: benwa <bt...@linagora.com>
Date: 2015-11-04T11:39:15Z
JAMES-1635 Increase embedded Cassandra startup timeout
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[GitHub] james-project pull request: JAMES-1635 Increase embedded Cassandra...
Posted by aduprat <gi...@git.apache.org>.
Github user aduprat commented on a diff in the pull request:
https://github.com/apache/james-project/pull/17#discussion_r43881372
--- Diff: backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/CassandraCluster.java ---
@@ -42,10 +42,12 @@
private static final long SLEEP_BEFORE_RETRY = 200;
private static final int MAX_RETRY = 200;
+ private static final long EMBEDDED_CASSANDRA_TIMEOUT = MAX_RETRY * SLEEP_BEFORE_RETRY;
--- End diff --
I would prefer an independent value, as the MAX_RETRY & SLEEP_BEFORE_RETRY don't make sense for this, IMHO.
You may also add the unit in the constant name.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[GitHub] james-project pull request: JAMES-1635 Increase embedded Cassandra...
Posted by chibenwa <gi...@git.apache.org>.
Github user chibenwa commented on the pull request:
https://github.com/apache/james-project/pull/17#issuecomment-160107688
Committed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[GitHub] james-project pull request: JAMES-1635 Increase embedded Cassandra...
Posted by chibenwa <gi...@git.apache.org>.
Github user chibenwa closed the pull request at:
https://github.com/apache/james-project/pull/17
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[GitHub] james-project pull request: JAMES-1635 Increase embedded Cassandra...
Posted by aduprat <gi...@git.apache.org>.
Github user aduprat commented on the pull request:
https://github.com/apache/james-project/pull/17#issuecomment-159527041
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[GitHub] james-project pull request: JAMES-1635 Increase embedded Cassandra...
Posted by chibenwa <gi...@git.apache.org>.
Github user chibenwa commented on a diff in the pull request:
https://github.com/apache/james-project/pull/17#discussion_r43896960
--- Diff: backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/CassandraCluster.java ---
@@ -42,10 +42,12 @@
private static final long SLEEP_BEFORE_RETRY = 200;
private static final int MAX_RETRY = 200;
+ private static final long EMBEDDED_CASSANDRA_TIMEOUT = MAX_RETRY * SLEEP_BEFORE_RETRY;
--- End diff --
Ok for the unit.
I do not agree with you for the timeout independent value. I do not want Cassandra unit to throw before the expected timeout value expressed by the retry loop. I'm OK with it throwing after that. For me it make perfect sense.
In fact SLEEP_BEFORE_RETRY should also indicate its value
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org