You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/06/25 03:21:06 UTC

[GitHub] [apisix] zuiyangqingzhou commented on a change in pull request #4479: fix: Multiple request-id bug

zuiyangqingzhou commented on a change in pull request #4479:
URL: https://github.com/apache/apisix/pull/4479#discussion_r658446054



##########
File path: apisix/plugins/request-id.lua
##########
@@ -49,7 +49,7 @@ function _M.rewrite(conf, ctx)
     end
 
     if conf.include_in_response then
-        ctx.x_request_id = uuid_val
+        ctx[conf.header_name] = uuid_val

Review comment:
       I don’t really understand the intention of adding a prefix, because header_name is originally defined by the user. He should know what the definition of header_name looks like.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org