You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/06/13 00:36:54 UTC
[kudu-CR] tidy: add and fix modernize-use-emplace and shrink-to-fit
Hello Dan Burkert, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7162
to review the following change.
Change subject: tidy: add and fix modernize-use-emplace and shrink-to-fit
......................................................................
tidy: add and fix modernize-use-emplace and shrink-to-fit
No fixes for shrink-to-fit. emplace found a bunch.
Change-Id: Ie5a9569e335e11e110336dbc4800441a61bc375c
---
M src/kudu/.clang-tidy
M src/kudu/benchmarks/tpch/tpch_real_world.cc
M src/kudu/cfile/bloomfile.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/encoding-test.cc
M src/kudu/client/meta_cache.cc
M src/kudu/client/predicate-test.cc
M src/kudu/codegen/codegen-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/schema.cc
M src/kudu/common/wire_protocol.cc
M src/kudu/consensus/quorum_util.cc
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/gutil/strings/join.cc
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/integration-tests/alter_table-randomized-test.cc
M src/kudu/integration-tests/client-stress-test.cc
M src/kudu/integration-tests/create-table-itest.cc
M src/kudu/integration-tests/delete_table-itest.cc
M src/kudu/integration-tests/disk_reservation-itest.cc
M src/kudu/integration-tests/exactly_once_writes-itest.cc
M src/kudu/integration-tests/external_mini_cluster.cc
M src/kudu/integration-tests/flex_partitioning-itest.cc
M src/kudu/integration-tests/linked_list-test.cc
M src/kudu/integration-tests/master-stress-test.cc
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/mini_cluster.cc
M src/kudu/integration-tests/open-readonly-fs-itest.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/tablet_copy_client_session-itest.cc
M src/kudu/integration-tests/tablet_replacement-itest.cc
M src/kudu/integration-tests/version_migration-test.cc
M src/kudu/master/ts_descriptor.cc
M src/kudu/rpc/rpc_stub-test.cc
M src/kudu/server/default-path-handlers.cc
M src/kudu/server/server_base.cc
M src/kudu/server/webserver.cc
M src/kudu/tablet/deltamemstore.cc
M src/kudu/tablet/diskrowset-test.cc
M src/kudu/tablet/lock_manager-test.cc
M src/kudu/tablet/memrowset-test.cc
M src/kudu/tablet/metadata-test.cc
M src/kudu/tablet/rowset_tree.cc
M src/kudu/tablet/tablet-schema-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/tool_main.cc
M src/kudu/tserver/tablet_copy_service-test.cc
M src/kudu/util/compression/compression-test.cc
M src/kudu/util/debug/trace_event_impl.cc
M src/kudu/util/interval_tree-test.cc
M src/kudu/util/knapsack_solver-test.cc
M src/kudu/util/path_util.cc
M src/kudu/util/pstack_watcher.cc
M src/kudu/util/trace-test.cc
57 files changed, 257 insertions(+), 255 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/7162/1
--
To view, visit http://gerrit.cloudera.org:8080/7162
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie5a9569e335e11e110336dbc4800441a61bc375c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
[kudu-CR] tidy: add and fix modernize-use-emplace and shrink-to-fit
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: tidy: add and fix modernize-use-emplace and shrink-to-fit
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7162
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5a9569e335e11e110336dbc4800441a61bc375c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] tidy: add and fix modernize-use-emplace and shrink-to-fit
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: tidy: add and fix modernize-use-emplace and shrink-to-fit
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7162
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5a9569e335e11e110336dbc4800441a61bc375c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No
[kudu-CR] tidy: add and fix modernize-use-emplace and shrink-to-fit
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: tidy: add and fix modernize-use-emplace and shrink-to-fit
......................................................................
Patch Set 2: Verified+1
test failure unrelated
--
To view, visit http://gerrit.cloudera.org:8080/7162
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5a9569e335e11e110336dbc4800441a61bc375c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] tidy: add and fix modernize-use-emplace and shrink-to-fit
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: tidy: add and fix modernize-use-emplace and shrink-to-fit
......................................................................
tidy: add and fix modernize-use-emplace and shrink-to-fit
No fixes for shrink-to-fit. emplace found a bunch.
Change-Id: Ie5a9569e335e11e110336dbc4800441a61bc375c
Reviewed-on: http://gerrit.cloudera.org:8080/7162
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/.clang-tidy
M src/kudu/benchmarks/tpch/tpch_real_world.cc
M src/kudu/cfile/bloomfile.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/encoding-test.cc
M src/kudu/client/meta_cache.cc
M src/kudu/client/predicate-test.cc
M src/kudu/codegen/codegen-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/row.h
M src/kudu/common/schema.cc
M src/kudu/common/wire_protocol.cc
M src/kudu/consensus/quorum_util.cc
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/gutil/strings/join.cc
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/integration-tests/alter_table-randomized-test.cc
M src/kudu/integration-tests/client-stress-test.cc
M src/kudu/integration-tests/create-table-itest.cc
M src/kudu/integration-tests/delete_table-itest.cc
M src/kudu/integration-tests/disk_reservation-itest.cc
M src/kudu/integration-tests/exactly_once_writes-itest.cc
M src/kudu/integration-tests/external_mini_cluster.cc
M src/kudu/integration-tests/flex_partitioning-itest.cc
M src/kudu/integration-tests/linked_list-test-util.h
M src/kudu/integration-tests/linked_list-test.cc
M src/kudu/integration-tests/master-stress-test.cc
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/mini_cluster.cc
M src/kudu/integration-tests/open-readonly-fs-itest.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/tablet_copy_client_session-itest.cc
M src/kudu/integration-tests/tablet_replacement-itest.cc
M src/kudu/integration-tests/ts_itest-base.h
M src/kudu/integration-tests/version_migration-test.cc
M src/kudu/master/ts_descriptor.cc
M src/kudu/rpc/rpc_stub-test.cc
M src/kudu/server/default-path-handlers.cc
M src/kudu/server/server_base.cc
M src/kudu/server/webserver.cc
M src/kudu/tablet/deltamemstore.cc
M src/kudu/tablet/diskrowset-test.cc
M src/kudu/tablet/local_tablet_writer.h
M src/kudu/tablet/lock_manager-test.cc
M src/kudu/tablet/memrowset-test.cc
M src/kudu/tablet/metadata-test.cc
M src/kudu/tablet/rowset_tree.cc
M src/kudu/tablet/tablet-schema-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/tool_main.cc
M src/kudu/tserver/tablet_copy_service-test.cc
M src/kudu/tserver/tablet_server-test-base.h
M src/kudu/util/compression/compression-test.cc
M src/kudu/util/debug/trace_event_impl.cc
M src/kudu/util/interval_tree-test.cc
M src/kudu/util/knapsack_solver-test.cc
M src/kudu/util/path_util.cc
M src/kudu/util/pstack_watcher.cc
M src/kudu/util/trace-test.cc
62 files changed, 273 insertions(+), 272 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Todd Lipcon: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7162
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie5a9569e335e11e110336dbc4800441a61bc375c
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] tidy: add and fix modernize-use-emplace and shrink-to-fit
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7162
to look at the new patch set (#2).
Change subject: tidy: add and fix modernize-use-emplace and shrink-to-fit
......................................................................
tidy: add and fix modernize-use-emplace and shrink-to-fit
No fixes for shrink-to-fit. emplace found a bunch.
Change-Id: Ie5a9569e335e11e110336dbc4800441a61bc375c
---
M src/kudu/.clang-tidy
M src/kudu/benchmarks/tpch/tpch_real_world.cc
M src/kudu/cfile/bloomfile.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/encoding-test.cc
M src/kudu/client/meta_cache.cc
M src/kudu/client/predicate-test.cc
M src/kudu/codegen/codegen-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/row.h
M src/kudu/common/schema.cc
M src/kudu/common/wire_protocol.cc
M src/kudu/consensus/quorum_util.cc
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/gutil/strings/join.cc
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/integration-tests/alter_table-randomized-test.cc
M src/kudu/integration-tests/client-stress-test.cc
M src/kudu/integration-tests/create-table-itest.cc
M src/kudu/integration-tests/delete_table-itest.cc
M src/kudu/integration-tests/disk_reservation-itest.cc
M src/kudu/integration-tests/exactly_once_writes-itest.cc
M src/kudu/integration-tests/external_mini_cluster.cc
M src/kudu/integration-tests/flex_partitioning-itest.cc
M src/kudu/integration-tests/linked_list-test-util.h
M src/kudu/integration-tests/linked_list-test.cc
M src/kudu/integration-tests/master-stress-test.cc
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/mini_cluster.cc
M src/kudu/integration-tests/open-readonly-fs-itest.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/tablet_copy_client_session-itest.cc
M src/kudu/integration-tests/tablet_replacement-itest.cc
M src/kudu/integration-tests/ts_itest-base.h
M src/kudu/integration-tests/version_migration-test.cc
M src/kudu/master/ts_descriptor.cc
M src/kudu/rpc/rpc_stub-test.cc
M src/kudu/server/default-path-handlers.cc
M src/kudu/server/server_base.cc
M src/kudu/server/webserver.cc
M src/kudu/tablet/deltamemstore.cc
M src/kudu/tablet/diskrowset-test.cc
M src/kudu/tablet/local_tablet_writer.h
M src/kudu/tablet/lock_manager-test.cc
M src/kudu/tablet/memrowset-test.cc
M src/kudu/tablet/metadata-test.cc
M src/kudu/tablet/rowset_tree.cc
M src/kudu/tablet/tablet-schema-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/tool_main.cc
M src/kudu/tserver/tablet_copy_service-test.cc
M src/kudu/tserver/tablet_server-test-base.h
M src/kudu/util/compression/compression-test.cc
M src/kudu/util/debug/trace_event_impl.cc
M src/kudu/util/interval_tree-test.cc
M src/kudu/util/knapsack_solver-test.cc
M src/kudu/util/path_util.cc
M src/kudu/util/pstack_watcher.cc
M src/kudu/util/trace-test.cc
62 files changed, 273 insertions(+), 272 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/7162/2
--
To view, visit http://gerrit.cloudera.org:8080/7162
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie5a9569e335e11e110336dbc4800441a61bc375c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot