You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/17 04:04:55 UTC
[GitHub] [nuttx] GUIDINGLI opened a new pull request, #8158: assert: fix build break
GUIDINGLI opened a new pull request, #8158:
URL: https://github.com/apache/nuttx/pull/8158
## Summary
assert: fix build break
misc/assert.c: In function 'show_tasks':
Error: misc/assert.c:411:10: error: format '%p' expects argument of type 'void *', but argument 3 has type 'uintptr_t' {aka 'long unsigned int'} [-Werror=format=]
411 | _alert(" ---- ---"
| ^~~~~~~~~~~~~~
......
424 | , up_get_intstackbase()
| ~~~~~~~~~~~~~~~~~~~~~
| |
| uintptr_t {aka long unsigned int}
Signed-off-by: ligd <li...@xiaomi.com>
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on pull request #8158: assert: fix build break
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #8158:
URL: https://github.com/apache/nuttx/pull/8158#issuecomment-1384861961
Why not just to cast to `void *` and leave `%p`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on pull request #8158: assert: fix build break
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #8158:
URL: https://github.com/apache/nuttx/pull/8158#issuecomment-1385028793
> > What about 64bit architectures? Or we expect pointers only in lower 32 bit address space?
>
> uintptr_t can handle both 32bit and 64bit arch
>
>
> > Why not just cast to `void *` and leave `%p`?
>
> %p can't add the modifier (e.g., 08).
But shouldn't it be 16 modifier for 64 bit pointers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8158: assert: fix build break
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #8158:
URL: https://github.com/apache/nuttx/pull/8158#discussion_r1072029996
##########
sched/misc/assert.c:
##########
@@ -329,7 +331,7 @@ static void dump_task(FAR struct tcb_s *tcb, FAR void *arg)
#ifdef CONFIG_SMP
" %4d"
#endif
- " %p"
+ " %0*p"
Review Comment:
Build complaints somewhere around here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] GUIDINGLI commented on pull request #8158: assert: fix build break
Posted by GitBox <gi...@apache.org>.
GUIDINGLI commented on PR #8158:
URL: https://github.com/apache/nuttx/pull/8158#issuecomment-1385025928
@xiaoxiang781216 @pkarashchenko @jerpelea
Please help to re-trigger, this is download fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis merged pull request #8158: assert: fix build break
Posted by GitBox <gi...@apache.org>.
acassis merged PR #8158:
URL: https://github.com/apache/nuttx/pull/8158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8158: assert: fix build break
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #8158:
URL: https://github.com/apache/nuttx/pull/8158#issuecomment-1384866802
> What about 64bit architectures? Or we expect pointers only in lower 32 bit address space?
uintptr_t can handle both 32bit and 64bit arch
> Why not just cast to `void *` and leave `%p`?
%p can't add the modifier (e.g., 08).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8158: assert: fix build break
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #8158:
URL: https://github.com/apache/nuttx/pull/8158#issuecomment-1385068794
> > > What about 64bit architectures? Or we expect pointers only in lower 32 bit address space?
> >
> >
> > uintptr_t can handle both 32bit and 64bit arch
> > > Why not just cast to `void *` and leave `%p`?
> >
> >
> > %p can't add the modifier (e.g., 08).
>
> But shouldn't it be 16 modifier for 64 bit pointers?
Oh, yes you are right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org