[GitHub] [pinot] vvivekiyer commented on pull request #10368: [multistage] Fix AVG Return Type

["vvivekiyer (via GitHub)" <gi...@apache.org>]

vvivekiyer commented on PR #10368:
URL: https://github.com/apache/pinot/pull/10368#issuecomment-1453000480

   > can you also add a test in runtime to make sure avg on a big decimal column returns a big decimal value? (a simple 2 big-decimal that taking an avg resulting in a double-overflowed result should be suffice)
   
   @walterddr Oh yeah, I tried adding it earlier. There's a existing issue where none of the aggregation functions work on BIG_DECIMAL columns 😅 . I'll spend some time tomorrow debugging and fixing it.  We can incorporate the fix in this PR or merge this PR and create a separate one for BIG_DECIMAL aggregate functions. I'm ok either way. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org