You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2016/06/07 09:24:09 UTC

Review Request 48328: LENS-1171: TestMetastoreService is creating/destroying session in each test

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48328/
-----------------------------------------------------------

Review request for lens.


Bugs: LENS-1171
    https://issues.apache.org/jira/browse/LENS-1171


Repository: lens


Description
-------

Session can be created at the start and can be destroyed at the end. This will be an improvement wrt test running time.


Diffs
-----

  lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 5424404567060009ca27edab814f9b6cf82a594a 

Diff: https://reviews.apache.org/r/48328/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 48328: LENS-1171: TestMetastoreService is creating/destroying session in each test

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48328/#review136586
-----------------------------------------------------------


Ship it!




Ship It!

- Amareshwari Sriramadasu


On June 7, 2016, 9:24 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48328/
> -----------------------------------------------------------
> 
> (Updated June 7, 2016, 9:24 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1171
>     https://issues.apache.org/jira/browse/LENS-1171
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Session can be created at the start and can be destroyed at the end. This will be an improvement wrt test running time.
> 
> 
> Diffs
> -----
> 
>   lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 5424404567060009ca27edab814f9b6cf82a594a 
> 
> Diff: https://reviews.apache.org/r/48328/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>


Re: Review Request 48328: LENS-1171: TestMetastoreService is creating/destroying session in each test

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48328/
-----------------------------------------------------------

(Updated June 8, 2016, 7:25 p.m.)


Review request for lens.


Bugs: LENS-1171
    https://issues.apache.org/jira/browse/LENS-1171


Repository: lens


Description
-------

Session can be created at the start and can be destroyed at the end. This will be an improvement wrt test running time.


Diffs (updated)
-----

  lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 5424404567060009ca27edab814f9b6cf82a594a 

Diff: https://reviews.apache.org/r/48328/diff/


Testing
-------


Thanks,

Rajat Khandelwal