You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "huanliwang-db (via GitHub)" <gi...@apache.org> on 2025/10/31 20:29:28 UTC
[PR] [SPARK-54118] Improve the put/merge operation in ListState when there are multiple values [spark]
huanliwang-db opened a new pull request, #52820:
URL: https://github.com/apache/spark/pull/52820
In SS TWS, when we do the put(array) operation in liststate, we put the first element and then merge the remaining elements one by one. so if we want to put an array with 100 elements, it means we need do 1 put + 99 merges. This can result in worse performance than a single put operation for the entire array.
Similar, we have the same issue in merge(array)
Ran the benchmark with inputRate = 1M keys/second - 1M key cardinality, here are the results for the batch duration with TWS in SS
Before:
```
Batch Duration (ms)
p50 666.00
p90 899.70
p95 969.35
p99 1081.94
```
After
```
Batch Duration (ms)
p50 488
p90 576
p95 609
p99 713
```
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Improve the existing `put(array)` and `merge(array)` implementation to reduce the number of rocksdb operations.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
performance improvement
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
existing UT and new UT
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54118][SS] Improve the put/merge operation in ListState when there are multiple values [spark]
Posted by "huanliwang-db (via GitHub)" <gi...@apache.org>.
huanliwang-db commented on code in PR #52820:
URL: https://github.com/apache/spark/pull/52820#discussion_r2482803309
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBSuite.scala:
##########
@@ -2015,6 +2015,58 @@ class RocksDBSuite extends AlsoTestWithRocksDBFeatures with SharedSparkSession
}
}
+ test("RocksDB: ensure putList / mergeList operation correctness") {
Review Comment:
yes, especially this test case: https://github.com/apache/spark/blob/master/sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/ListStateSuite.scala#L104
In this case, we do the array put and array appendList which I think should provide sufficient test coverage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54118][SS] Improve the put/merge operation in ListState when there are multiple values [spark]
Posted by "anishshri-db (via GitHub)" <gi...@apache.org>.
anishshri-db closed pull request #52820: [SPARK-54118][SS] Improve the put/merge operation in ListState when there are multiple values
URL: https://github.com/apache/spark/pull/52820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54118][SS] Improve the put/merge operation in ListState when there are multiple values [spark]
Posted by "anishshri-db (via GitHub)" <gi...@apache.org>.
anishshri-db commented on code in PR #52820:
URL: https://github.com/apache/spark/pull/52820#discussion_r2482782836
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala:
##########
@@ -991,6 +992,70 @@ class RocksDB(
changelogWriter.foreach(_.put(keyWithPrefix, value))
}
+ /**
+ * Convert the given list of value row bytes into a single byte array. The returned array
+ * bytes supports additional values to be later merged to it.
+ */
+ private def getListValuesInArrayByte(values: List[Array[Byte]]): Array[Byte] = {
+
Review Comment:
nit: extra newline ?
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreProvider.scala:
##########
@@ -305,6 +330,28 @@ private[sql] class RocksDBStateStoreProvider
rocksDB.put(kvEncoder._1.encodeKey(key), kvEncoder._2.encodeValue(value), colFamilyName)
}
+ override def putList(
+ key: UnsafeRow,
+ values: Array[UnsafeRow],
+ colFamilyName: String): Unit = {
+ validateAndTransitionState(UPDATE)
+ verify(state == UPDATING, "Cannot put after already committed or aborted")
+ verify(key != null, "Key cannot be null")
+ require(values != null, "Cannot put a null value")
+ values.foreach(v => require(v != null, "Cannot put a null value in the array"))
+ verifyColFamilyOperations("put", colFamilyName)
+
+ val kvEncoder = keyValueEncoderMap.get(colFamilyName)
+ verify(
+ kvEncoder._2.supportsMultipleValuesPerKey,
+ "Multiple values put operation requires an encoder" +
Review Comment:
nit: `Multi-value put operations`
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBSuite.scala:
##########
@@ -2015,6 +2015,58 @@ class RocksDBSuite extends AlsoTestWithRocksDBFeatures with SharedSparkSession
}
}
+ test("RocksDB: ensure putList / mergeList operation correctness") {
Review Comment:
Do we have enough coverage for list state tests ?
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala:
##########
@@ -208,6 +208,16 @@ trait StateStore extends ReadStateStore {
value: UnsafeRow,
colFamilyName: String = StateStore.DEFAULT_COL_FAMILY_NAME): Unit
+ /**
+ * Put a new list of non-null value for a non-null key. Implementations must be aware that the
Review Comment:
nit: `non-null values for a`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org