You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@yunikorn.apache.org by "Manikandan R (Jira)" <ji...@apache.org> on 2023/07/13 07:09:00 UTC
[jira] [Comment Edited] (YUNIKORN-1863) Remove unused code in processUserConfig and processGroupConfig
[ https://issues.apache.org/jira/browse/YUNIKORN-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742683#comment-17742683 ]
Manikandan R edited comment on YUNIKORN-1863 at 7/13/23 7:08 AM:
-----------------------------------------------------------------
Yes, you are right. Even I had come across while working on other PR (not raised yet) couple of days back and covered it too. Handling the wildcard cases inside those process methods is not required as it has been stored in different map and skipped earlier. Stored map would be used in a separate code path. Merged your pr changes. Thanks.
was (Author: mani):
Yes, you are right. Even I had come across while working on other PR (not raised yet) couple of days back and covered it too. Merged your pr changes. Thanks.
> Remove unused code in processUserConfig and processGroupConfig
> --------------------------------------------------------------
>
> Key: YUNIKORN-1863
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1863
> Project: Apache YuniKorn
> Issue Type: Sub-task
> Components: core - scheduler
> Reporter: PoAn Yang
> Assignee: PoAn Yang
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.4.0
>
>
> The wildcard and empty string cases are checked in [internalProcessConfig|https://github.com/apache/yunikorn-core/blob/1f1d67d76a720a07488a61dc39a17eb0f04a0b28/pkg/scheduler/ugm/manager.go#L315]. We don't need to do it again in [processUserConfig|https://github.com/apache/yunikorn-core/blob/1f1d67d76a720a07488a61dc39a17eb0f04a0b28/pkg/scheduler/ugm/manager.go#L383] and [processGroupConfig|https://github.com/apache/yunikorn-core/blob/1f1d67d76a720a07488a61dc39a17eb0f04a0b28/pkg/scheduler/ugm/manager.go#L409].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org