You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/07/08 15:50:41 UTC

[GitHub] [arrow-rs] tustvold opened a new issue, #4488: Interval Negation Incorrect

tustvold opened a new issue, #4488:
URL: https://github.com/apache/arrow-rs/issues/4488

   **Describe the bug**
   <!--
   A clear and concise description of what the bug is.
   -->
   
   The negate kernels are incorrect for interval types as they fail to take into account that the values are composite
   
   **To Reproduce**
   <!--
   Steps to reproduce the behavior:
   -->
   
   ```
   #[test]
   fn test_negate() {
       let a =
           IntervalMonthDayNanoArray::from(vec![IntervalMonthDayNanoType::make_value(
               1, -5, 2,
           )]);
       let negated = negate(&a).unwrap();
       assert_eq!(
           negated.value(0),
           IntervalMonthDayNanoType::make_value(-1, 5, -2)
       );
   }
   ```
   
   **Expected behavior**
   <!--
   A clear and concise description of what you expected to happen.
   -->
   
   **Additional context**
   <!--
   Add any other context about the problem here.
   -->
   
   We should probably deprecate the generic kernels and implement new kernels as part of #1047 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold closed issue #4488: Interval Negation Incorrect

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold closed issue #4488: Interval Negation Incorrect
URL: https://github.com/apache/arrow-rs/issues/4488


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold commented on issue #4488: Interval Negation Incorrect

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on issue #4488:
URL: https://github.com/apache/arrow-rs/issues/4488#issuecomment-1636154710

   `label_issue.py` automatically added labels {'arrow'} from #4494


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org