You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "AnonHxy (via GitHub)" <gi...@apache.org> on 2023/08/08 14:37:44 UTC
[GitHub] [pulsar] AnonHxy opened a new pull request, #20952: [improve][bk] Improve getIsolationGroup by avoid creating arrayList
AnonHxy opened a new pull request, #20952:
URL: https://github.com/apache/pulsar/pull/20952
### Motivation
Minor improve `getIsolationGroup` by avoid creating arrayList. And it' beneficial to GC
### Modifications
`new HashSet<>(Arrays.asList(...))` -> `Sets.newHashSet(...)`
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: https://github.com/AnonHxy/pulsar/pull/43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #20952: [improve][bk] Improve getIsolationGroup by avoid creating arrayList
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #20952:
URL: https://github.com/apache/pulsar/pull/20952#issuecomment-1675658706
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/20952?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#20952](https://app.codecov.io/gh/apache/pulsar/pull/20952?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (df3da9f) into [master](https://app.codecov.io/gh/apache/pulsar/commit/98628845aa94b416b0c3711b5a15819ade549c57?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9862884) will **increase** coverage by `39.53%`.
> Report is 1 commits behind head on master.
> The diff coverage is `57.14%`.
[](https://app.codecov.io/gh/apache/pulsar/pull/20952?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #20952 +/- ##
=============================================
+ Coverage 33.53% 73.07% +39.53%
- Complexity 12174 32136 +19962
=============================================
Files 1621 1875 +254
Lines 126919 139406 +12487
Branches 13851 15329 +1478
=============================================
+ Hits 42561 101868 +59307
+ Misses 78745 29484 -49261
- Partials 5613 8054 +2441
```
| Flag | Coverage Δ | |
|---|---|---|
| inttests | `24.21% <0.00%> (-0.07%)` | :arrow_down: |
| systests | `25.07% <0.00%> (?)` | |
| unittests | `72.37% <57.14%> (+40.31%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files Changed](https://app.codecov.io/gh/apache/pulsar/pull/20952?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...rization/MultiRolesTokenAuthorizationProvider.java](https://app.codecov.io/gh/apache/pulsar/pull/20952?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9icm9rZXIvYXV0aG9yaXphdGlvbi9NdWx0aVJvbGVzVG9rZW5BdXRob3JpemF0aW9uUHJvdmlkZXIuamF2YQ==) | `60.43% <40.00%> (+60.43%)` | :arrow_up: |
| [...areness/IsolatedBookieEnsemblePlacementPolicy.java](https://app.codecov.io/gh/apache/pulsar/pull/20952?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9ib29raWUvcmFja2F3YXJlbmVzcy9Jc29sYXRlZEJvb2tpZUVuc2VtYmxlUGxhY2VtZW50UG9saWN5LmphdmE=) | `89.60% <100.00%> (+89.59%)` | :arrow_up: |
... and [1520 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/20952/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy merged pull request #20952: [improve][bk] Improve getIsolationGroup by avoid creating arrayList
Posted by "AnonHxy (via GitHub)" <gi...@apache.org>.
AnonHxy merged PR #20952:
URL: https://github.com/apache/pulsar/pull/20952
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- closed pull request #20952: [improve][bk] Improve getIsolationGroup by avoid creating arrayList
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- closed pull request #20952: [improve][bk] Improve getIsolationGroup by avoid creating arrayList
URL: https://github.com/apache/pulsar/pull/20952
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org